| Message ID | 20231216115717.2285930-1-haokexin@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | PM: Remove the mention of freezer_count() in comment | expand |
On Sat, Dec 16, 2023 at 12:57 PM Kevin Hao <haokexin@gmail.com> wrote: > > The freezer_count() has been removed by commit f5d39b020809 > ("freezer,sched: Rewrite core freezer logic"). > > Signed-off-by: Kevin Hao <haokexin@gmail.com> > --- > kernel/power/main.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/kernel/power/main.c b/kernel/power/main.c > index f6425ae3e8b0..768c07155d53 100644 > --- a/kernel/power/main.c > +++ b/kernel/power/main.c > @@ -61,8 +61,7 @@ EXPORT_SYMBOL_GPL(lock_system_sleep); > void unlock_system_sleep(unsigned int flags) > { > /* > - * Don't use freezer_count() because we don't want the call to > - * try_to_freeze() here. > + * Don't call try_to_freeze() here. > * > * Reason: > * Fundamentally, we just don't need it, because freezing condition IMV, it would be better to remove the entire comment from unlock_system_sleep(), because there is no particular purpose for having it after the freezer changes.
On Tue, Dec 19, 2023 at 09:21:26PM +0100, Rafael J. Wysocki wrote: > On Sat, Dec 16, 2023 at 12:57 PM Kevin Hao <haokexin@gmail.com> wrote: > > > > The freezer_count() has been removed by commit f5d39b020809 > > ("freezer,sched: Rewrite core freezer logic"). > > > > Signed-off-by: Kevin Hao <haokexin@gmail.com> > > --- > > kernel/power/main.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/kernel/power/main.c b/kernel/power/main.c > > index f6425ae3e8b0..768c07155d53 100644 > > --- a/kernel/power/main.c > > +++ b/kernel/power/main.c > > @@ -61,8 +61,7 @@ EXPORT_SYMBOL_GPL(lock_system_sleep); > > void unlock_system_sleep(unsigned int flags) > > { > > /* > > - * Don't use freezer_count() because we don't want the call to > > - * try_to_freeze() here. > > + * Don't call try_to_freeze() here. > > * > > * Reason: > > * Fundamentally, we just don't need it, because freezing condition > > IMV, it would be better to remove the entire comment from > unlock_system_sleep(), because there is no particular purpose for > having it after the freezer changes. Sure. V2 is coming. Thanks, Kevin
diff --git a/kernel/power/main.c b/kernel/power/main.c index f6425ae3e8b0..768c07155d53 100644 --- a/kernel/power/main.c +++ b/kernel/power/main.c @@ -61,8 +61,7 @@ EXPORT_SYMBOL_GPL(lock_system_sleep); void unlock_system_sleep(unsigned int flags) { /* - * Don't use freezer_count() because we don't want the call to - * try_to_freeze() here. + * Don't call try_to_freeze() here. * * Reason: * Fundamentally, we just don't need it, because freezing condition
The freezer_count() has been removed by commit f5d39b020809 ("freezer,sched: Rewrite core freezer logic"). Signed-off-by: Kevin Hao <haokexin@gmail.com> --- kernel/power/main.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)