[edk2] ArmPkg/DefaultExceptionHandlerLib: trim module name in backtrace output

Message ID CAKv+Gu-nQtbzj14U+K+nkwgZKaU0JZfmFkMHftmU9-FaQnU4jA@mail.gmail.com
State New
Headers show

Commit Message

Ard Biesheuvel Sept. 9, 2016, 1:04 p.m.
On 9 September 2016 at 12:26, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> On Fri, Sep 09, 2016 at 08:35:21AM +0100, Ard Biesheuvel wrote:

>> As reported by Vishal, the new backtrace output would be more useful if

>> it did not contain the full absolute path of each module in the list.

>> So strip off everything up to the last forward slash or backslash in the

>> string.

>>

>> Example output:

>>

>>   IRQ Exception at 0x000000005EF110E0

>>   DxeCore.dll loaded at 0x000000005EEED000

>>   called from DxeCore.dll (0x000000005EF121F0) loaded at 0x000000005EEED000

>>   called from DxeCore.dll (0x000000005EF1289C) loaded at 0x000000005EEED000

>>   called from DxeCore.dll (0x000000005EEFB6B4) loaded at 0x000000005EEED000

>>   called from DxeCore.dll (0x000000005EEFAA44) loaded at 0x000000005EEED000

>>   called from DxeCore.dll (0x000000005EEFB450) loaded at 0x000000005EEED000

>>   called from DxeCore.dll (0x000000005EEF938C) loaded at 0x000000005EEED000

>>   called from DxeCore.dll (0x000000005EEF8D04) loaded at 0x000000005EEED000

>>   called from DxeCore.dll (0x000000005EEFA8E8) loaded at 0x000000005EEED000

>>   called from DxeCore.dll (0x000000005EEF3C14) loaded at 0x000000005EEED000

>>   called from DxeCore.dll (0x000000005EEF3E48) loaded at 0x000000005EEED000

>>   called from DxeCore.dll (0x000000005EF0C838) loaded at 0x000000005EEED000

>>   called from DxeCore.dll (0x000000005EEEF70C) loaded at 0x000000005EEED000

>>   called from DxeCore.dll (0x000000005EEEE93C) loaded at 0x000000005EEED000

>>   called from DxeCore.dll (0x000000005EEEE024) loaded at 0x000000005EEED000

>>

>> Suggested-by: "Oliyil Kunnil, Vishal" <vishalo@qti.qualcomm.com>

>> Contributed-under: TianoCore Contribution Agreement 1.0

>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

>

> Yes, that is cleaner.

> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

>


Pushed, with the below folded in to prevent the RELEASE build from
breaking on an 'unused function'

Thanks,
Ard.


_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Patch

--- a/ArmPkg/Library/DefaultExceptionHandlerLib/AArch64/DefaultExceptionHandler.c
+++ b/ArmPkg/Library/DefaultExceptionHandlerLib/AArch64/DefaultExceptionHandler.c
@@ -119,6 +119,7 @@  DescribeExceptionSyndrome (
   DEBUG ((EFI_D_ERROR, "\n %a \n", Message));
 }

+#ifndef MDEPKG_NDEBUG
 STATIC
 CONST CHAR8 *
 BaseName (
@@ -136,6 +137,7 @@  BaseName (
   }
   return Str;
 }
+#endif

 /**
   This is the default action to take on an unexpected exception