| Message ID | 20231230045105.91351-3-sergeantsagara@protonmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | wifi: b43: Various QoS-related fixes | expand |
Hi Rahul, On Sat, Dec 30, 2023 at 3:52 PM Rahul Rameshbabu <sergeantsagara@protonmail.com> wrote: > > When QoS is disabled, the queue priority value will not map to the correct > ieee80211 queue since there is only one queue. Stop/wake queue 0 when QoS > is disabled to prevent trying to stop/wake a non-existent queue and failing > to stop/wake the actual queue instantiated. > > Log of issue before change (with kernel parameter qos=0): > [ +5.112651] ------------[ cut here ]------------ > [ +0.000005] WARNING: CPU: 7 PID: 25513 at net/mac80211/util.c:449 __ieee80211_wake_queue+0xd5/0x180 [mac80211] > [ +0.000067] Modules linked in: b43(O) snd_seq_dummy snd_hrtimer snd_seq snd_seq_device nft_chain_nat xt_MASQUERADE nf_nat xfrm_user xfrm_algo xt_addrtype overlay ccm af_packet amdgpu snd_hda_codec_cirrus snd_hda_codec_generic ledtrig_audio drm_exec amdxcp gpu_sched xt_conntrack nf_conntrack nf_defrag_ipv6 nf_defrag_ipv4 ip6t_rpfilter ipt_rpfilter xt_pkttype xt_LOG nf_log_syslog xt_tcpudp nft_compat nf_tables nfnetlink sch_fq_codel btusb uinput iTCO_wdt ctr btrtl intel_pmc_bxt i915 intel_rapl_msr mei_hdcp mei_pxp joydev at24 watchdog btintel atkbd libps2 serio radeon btbcm vivaldi_fmap btmtk intel_rapl_common snd_hda_codec_hdmi bluetooth uvcvideo nls_iso8859_1 applesmc nls_cp437 x86_pkg_temp_thermal snd_hda_intel intel_powerclamp vfat videobuf2_vmalloc coretemp fat snd_intel_dspcfg crc32_pclmul uvc polyval_clmulni snd_intel_sdw_acpi loop videobuf2_memops snd_hda_codec tun drm_suballoc_helper polyval_generic drm_ttm_helper drm_buddy tap ecdh_generic videobuf2_v4l2 gf128mul macvlan ttm ghash_clmulni_intel ecc tg3 > [ +0.000044] videodev bridge snd_hda_core rapl crc16 drm_display_helper cec mousedev snd_hwdep evdev intel_cstate bcm5974 hid_appleir videobuf2_common stp mac_hid libphy snd_pcm drm_kms_helper acpi_als mei_me intel_uncore llc mc snd_timer intel_gtt industrialio_triggered_buffer apple_mfi_fastcharge i2c_i801 mei snd lpc_ich agpgart ptp i2c_smbus thunderbolt apple_gmux i2c_algo_bit kfifo_buf video industrialio soundcore pps_core wmi tiny_power_button sbs sbshc button ac cordic bcma mac80211 cfg80211 ssb rfkill libarc4 kvm_intel kvm drm irqbypass fuse backlight firmware_class efi_pstore configfs efivarfs dmi_sysfs ip_tables x_tables autofs4 dm_crypt cbc encrypted_keys trusted asn1_encoder tee tpm rng_core input_leds hid_apple led_class hid_generic usbhid hid sd_mod t10_pi crc64_rocksoft crc64 crc_t10dif crct10dif_generic ahci libahci libata uhci_hcd ehci_pci ehci_hcd crct10dif_pclmul crct10dif_common sha512_ssse3 sha512_generic sha256_ssse3 sha1_ssse3 aesni_intel usbcore scsi_mod libaes crypto_simd cryptd scsi_common > [ +0.000055] usb_common rtc_cmos btrfs blake2b_generic libcrc32c crc32c_generic crc32c_intel xor raid6_pq dm_snapshot dm_bufio dm_mod dax [last unloaded: b43(O)] > [ +0.000009] CPU: 7 PID: 25513 Comm: irq/17-b43 Tainted: G W O 6.6.7 #1-NixOS > [ +0.000003] Hardware name: Apple Inc. MacBookPro8,3/Mac-942459F5819B171B, BIOS 87.0.0.0.0 06/13/2019 > [ +0.000001] RIP: 0010:__ieee80211_wake_queue+0xd5/0x180 [mac80211] > [ +0.000046] Code: 00 45 85 e4 0f 85 9b 00 00 00 48 8d bd 40 09 00 00 f0 48 0f ba ad 48 09 00 00 00 72 0f 5b 5d 41 5c 41 5d 41 5e e9 cb 6d 3c d0 <0f> 0b 5b 5d 41 5c 41 5d 41 5e c3 cc cc cc cc 48 8d b4 16 94 00 00 > [ +0.000002] RSP: 0018:ffffc90003c77d60 EFLAGS: 00010097 > [ +0.000001] RAX: 0000000000000001 RBX: 0000000000000002 RCX: 0000000000000000 > [ +0.000001] RDX: 0000000000000000 RSI: 0000000000000002 RDI: ffff88820b924900 > [ +0.000002] RBP: ffff88820b924900 R08: ffffc90003c77d90 R09: 000000000003bfd0 > [ +0.000001] R10: ffff88820b924900 R11: ffffc90003c77c68 R12: 0000000000000000 > [ +0.000001] R13: 0000000000000000 R14: ffffc90003c77d90 R15: ffffffffc0fa6f40 > [ +0.000001] FS: 0000000000000000(0000) GS:ffff88846fb80000(0000) knlGS:0000000000000000 > [ +0.000001] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > [ +0.000001] CR2: 00007fafda7ae008 CR3: 000000046d220005 CR4: 00000000000606e0 > [ +0.000002] Call Trace: > [ +0.000003] <TASK> > [ +0.000001] ? __ieee80211_wake_queue+0xd5/0x180 [mac80211] > [ +0.000044] ? __warn+0x81/0x130 > [ +0.000005] ? __ieee80211_wake_queue+0xd5/0x180 [mac80211] > [ +0.000045] ? report_bug+0x171/0x1a0 > [ +0.000004] ? handle_bug+0x41/0x70 > [ +0.000004] ? exc_invalid_op+0x17/0x70 > [ +0.000003] ? asm_exc_invalid_op+0x1a/0x20 > [ +0.000005] ? __ieee80211_wake_queue+0xd5/0x180 [mac80211] > [ +0.000043] ieee80211_wake_queue+0x4a/0x80 [mac80211] > [ +0.000044] b43_dma_handle_txstatus+0x29c/0x3a0 [b43] > [ +0.000016] ? __pfx_irq_thread_fn+0x10/0x10 > [ +0.000002] b43_handle_txstatus+0x61/0x80 [b43] > [ +0.000012] b43_interrupt_thread_handler+0x3f9/0x6b0 [b43] > [ +0.000011] irq_thread_fn+0x23/0x60 > [ +0.000002] irq_thread+0xfe/0x1c0 > [ +0.000002] ? __pfx_irq_thread_dtor+0x10/0x10 > [ +0.000001] ? __pfx_irq_thread+0x10/0x10 > [ +0.000001] kthread+0xe8/0x120 > [ +0.000003] ? __pfx_kthread+0x10/0x10 > [ +0.000003] ret_from_fork+0x34/0x50 > [ +0.000002] ? __pfx_kthread+0x10/0x10 > [ +0.000002] ret_from_fork_asm+0x1b/0x30 > [ +0.000004] </TASK> > [ +0.000001] ---[ end trace 0000000000000000 ]--- > > [ +0.000065] ------------[ cut here ]------------ > [ +0.000001] WARNING: CPU: 0 PID: 56077 at net/mac80211/util.c:514 __ieee80211_stop_queue+0xcc/0xe0 [mac80211] > [ +0.000077] Modules linked in: b43(O) snd_seq_dummy snd_hrtimer snd_seq snd_seq_device nft_chain_nat xt_MASQUERADE nf_nat xfrm_user xfrm_algo xt_addrtype overlay ccm af_packet amdgpu snd_hda_codec_cirrus snd_hda_codec_generic ledtrig_audio drm_exec amdxcp gpu_sched xt_conntrack nf_conntrack nf_defrag_ipv6 nf_defrag_ipv4 ip6t_rpfilter ipt_rpfilter xt_pkttype xt_LOG nf_log_syslog xt_tcpudp nft_compat nf_tables nfnetlink sch_fq_codel btusb uinput iTCO_wdt ctr btrtl intel_pmc_bxt i915 intel_rapl_msr mei_hdcp mei_pxp joydev at24 watchdog btintel atkbd libps2 serio radeon btbcm vivaldi_fmap btmtk intel_rapl_common snd_hda_codec_hdmi bluetooth uvcvideo nls_iso8859_1 applesmc nls_cp437 x86_pkg_temp_thermal snd_hda_intel intel_powerclamp vfat videobuf2_vmalloc coretemp fat snd_intel_dspcfg crc32_pclmul uvc polyval_clmulni snd_intel_sdw_acpi loop videobuf2_memops snd_hda_codec tun drm_suballoc_helper polyval_generic drm_ttm_helper drm_buddy tap ecdh_generic videobuf2_v4l2 gf128mul macvlan ttm ghash_clmulni_intel ecc tg3 > [ +0.000073] videodev bridge snd_hda_core rapl crc16 drm_display_helper cec mousedev snd_hwdep evdev intel_cstate bcm5974 hid_appleir videobuf2_common stp mac_hid libphy snd_pcm drm_kms_helper acpi_als mei_me intel_uncore llc mc snd_timer intel_gtt industrialio_triggered_buffer apple_mfi_fastcharge i2c_i801 mei snd lpc_ich agpgart ptp i2c_smbus thunderbolt apple_gmux i2c_algo_bit kfifo_buf video industrialio soundcore pps_core wmi tiny_power_button sbs sbshc button ac cordic bcma mac80211 cfg80211 ssb rfkill libarc4 kvm_intel kvm drm irqbypass fuse backlight firmware_class efi_pstore configfs efivarfs dmi_sysfs ip_tables x_tables autofs4 dm_crypt cbc encrypted_keys trusted asn1_encoder tee tpm rng_core input_leds hid_apple led_class hid_generic usbhid hid sd_mod t10_pi crc64_rocksoft crc64 crc_t10dif crct10dif_generic ahci libahci libata uhci_hcd ehci_pci ehci_hcd crct10dif_pclmul crct10dif_common sha512_ssse3 sha512_generic sha256_ssse3 sha1_ssse3 aesni_intel usbcore scsi_mod libaes crypto_simd cryptd scsi_common > [ +0.000084] usb_common rtc_cmos btrfs blake2b_generic libcrc32c crc32c_generic crc32c_intel xor raid6_pq dm_snapshot dm_bufio dm_mod dax [last unloaded: b43] > [ +0.000012] CPU: 0 PID: 56077 Comm: kworker/u16:17 Tainted: G W O 6.6.7 #1-NixOS > [ +0.000003] Hardware name: Apple Inc. MacBookPro8,3/Mac-942459F5819B171B, BIOS 87.0.0.0.0 06/13/2019 > [ +0.000001] Workqueue: phy7 b43_tx_work [b43] > [ +0.000019] RIP: 0010:__ieee80211_stop_queue+0xcc/0xe0 [mac80211] > [ +0.000076] Code: 74 11 48 8b 78 08 0f b7 d6 89 e9 4c 89 e6 e8 ab f4 00 00 65 ff 0d 9c b7 34 3f 0f 85 55 ff ff ff 0f 1f 44 00 00 e9 4b ff ff ff <0f> 0b 5b 5d 41 5c 41 5d c3 cc cc cc cc 0f 1f 80 00 00 00 00 90 90 > [ +0.000002] RSP: 0000:ffffc90004157d50 EFLAGS: 00010097 > [ +0.000002] RAX: 0000000000000001 RBX: 0000000000000002 RCX: 0000000000000000 > [ +0.000002] RDX: 0000000000000000 RSI: 0000000000000002 RDI: ffff8882d65d0900 > [ +0.000002] RBP: 0000000000000000 R08: 0000000000000001 R09: 0000000000000001 > [ +0.000001] R10: 00000000000000ff R11: ffff88814d0155a0 R12: ffff8882d65d0900 > [ +0.000002] R13: 0000000000000000 R14: ffff8881002d2800 R15: 00000000000000d0 > [ +0.000002] FS: 0000000000000000(0000) GS:ffff88846f800000(0000) knlGS:0000000000000000 > [ +0.000003] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > [ +0.000002] CR2: 00007f2e8c10c880 CR3: 0000000385b66005 CR4: 00000000000606f0 > [ +0.000002] Call Trace: > [ +0.000001] <TASK> > [ +0.000001] ? __ieee80211_stop_queue+0xcc/0xe0 [mac80211] > [ +0.000075] ? __warn+0x81/0x130 > [ +0.000004] ? __ieee80211_stop_queue+0xcc/0xe0 [mac80211] > [ +0.000075] ? report_bug+0x171/0x1a0 > [ +0.000005] ? handle_bug+0x41/0x70 > [ +0.000003] ? exc_invalid_op+0x17/0x70 > [ +0.000004] ? asm_exc_invalid_op+0x1a/0x20 > [ +0.000004] ? __ieee80211_stop_queue+0xcc/0xe0 [mac80211] > [ +0.000076] ieee80211_stop_queue+0x36/0x50 [mac80211] > [ +0.000077] b43_dma_tx+0x550/0x780 [b43] > [ +0.000023] b43_tx_work+0x90/0x130 [b43] > [ +0.000018] process_one_work+0x174/0x340 > [ +0.000003] worker_thread+0x27b/0x3a0 > [ +0.000004] ? __pfx_worker_thread+0x10/0x10 > [ +0.000002] kthread+0xe8/0x120 > [ +0.000003] ? __pfx_kthread+0x10/0x10 > [ +0.000004] ret_from_fork+0x34/0x50 > [ +0.000002] ? __pfx_kthread+0x10/0x10 > [ +0.000003] ret_from_fork_asm+0x1b/0x30 > [ +0.000006] </TASK> > [ +0.000001] ---[ end trace 0000000000000000 ]--- > > Fixes: e6f5b934fba8 ("b43: Add QOS support") > Signed-off-by: Rahul Rameshbabu <sergeantsagara@protonmail.com> > --- > drivers/net/wireless/broadcom/b43/dma.c | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/wireless/broadcom/b43/dma.c b/drivers/net/wireless/broadcom/b43/dma.c > index 760d1a28edc6..68671de27569 100644 > --- a/drivers/net/wireless/broadcom/b43/dma.c > +++ b/drivers/net/wireless/broadcom/b43/dma.c > @@ -1399,7 +1399,10 @@ int b43_dma_tx(struct b43_wldev *dev, struct sk_buff *skb) > should_inject_overflow(ring)) { > /* This TX ring is full. */ > unsigned int skb_mapping = skb_get_queue_mapping(skb); > - ieee80211_stop_queue(dev->wl->hw, skb_mapping); > + if (dev->qos_enabled) > + ieee80211_stop_queue(dev->wl->hw, skb_mapping); > + else > + ieee80211_stop_queue(dev->wl->hw, 0); Would this be a little cleaner if we only look up the queue mapping if QOS is enabled? I.e. unsigned int skb_mapping = 0; if (dev->qos_enabled) { skb_mapping = skb_get_queue_mapping(skb); } ieee80211_stop_queue(dev->wl->hw, skb_mapping); Thanks,
On Sat, 30 Dec 2023 18:48:45 +1100 Julian Calaby <julian.calaby@gmail.com> wrote: > > --- a/drivers/net/wireless/broadcom/b43/dma.c > > +++ b/drivers/net/wireless/broadcom/b43/dma.c > > @@ -1399,7 +1399,10 @@ int b43_dma_tx(struct b43_wldev *dev, struct sk_buff *skb) > > should_inject_overflow(ring)) { > > /* This TX ring is full. */ > > unsigned int skb_mapping = skb_get_queue_mapping(skb); > > - ieee80211_stop_queue(dev->wl->hw, skb_mapping); > > + if (dev->qos_enabled) > > + ieee80211_stop_queue(dev->wl->hw, skb_mapping); > > + else > > + ieee80211_stop_queue(dev->wl->hw, 0); > > Would this be a little cleaner if we only look up the queue mapping if > QOS is enabled? I.e. No. It would break the other uses of skb_mapping. But I am wondering why skb_mapping is non-zero in the first place. I think the actual bug might be somewhere else.
On Sat, 30 Dec, 2023 14:40:36 +0100 Michael Büsch <m@bues.ch> wrote: > [[PGP Signed Part:Undecided]] > On Sat, 30 Dec 2023 18:48:45 +1100 > Julian Calaby <julian.calaby@gmail.com> wrote: >> > --- a/drivers/net/wireless/broadcom/b43/dma.c >> > +++ b/drivers/net/wireless/broadcom/b43/dma.c >> > @@ -1399,7 +1399,10 @@ int b43_dma_tx(struct b43_wldev *dev, struct sk_buff *skb) >> > should_inject_overflow(ring)) { >> > /* This TX ring is full. */ >> > unsigned int skb_mapping = skb_get_queue_mapping(skb); >> > - ieee80211_stop_queue(dev->wl->hw, skb_mapping); >> > + if (dev->qos_enabled) >> > + ieee80211_stop_queue(dev->wl->hw, skb_mapping); >> > + else >> > + ieee80211_stop_queue(dev->wl->hw, 0); >> >> Would this be a little cleaner if we only look up the queue mapping if >> QOS is enabled? I.e. > > No. It would break the other uses of skb_mapping. > > But I am wondering why skb_mapping is non-zero in the first place. > I think the actual bug might be somewhere else. Right, skb_mapping is used to map to the correct software structures DMA mapped to the device. The reason the mapping for the best effort queue (the default/defacto when QoS is disabled) is not zero is due to the way initialization of the queues/rings occurs in the driver. The best effort queue is mapped as the third queue, which leads to this issue when QoS is disabled. Would it make more sense to change the mappings in initialization such that the best effort queue is by default mapped to zero, so we would not need such conditionals? -- Thanks, Rahul Rameshbabu
On Sat, 30 Dec 2023 17:15:18 +0000 Rahul Rameshbabu <sergeantsagara@protonmail.com> wrote: > On Sat, 30 Dec, 2023 14:40:36 +0100 Michael Büsch <m@bues.ch> wrote: > > [[PGP Signed Part:Undecided]] > > On Sat, 30 Dec 2023 18:48:45 +1100 > > Julian Calaby <julian.calaby@gmail.com> wrote: > >> > --- a/drivers/net/wireless/broadcom/b43/dma.c > >> > +++ b/drivers/net/wireless/broadcom/b43/dma.c > >> > @@ -1399,7 +1399,10 @@ int b43_dma_tx(struct b43_wldev *dev, struct sk_buff *skb) > >> > should_inject_overflow(ring)) { > >> > /* This TX ring is full. */ > >> > unsigned int skb_mapping = skb_get_queue_mapping(skb); > >> > - ieee80211_stop_queue(dev->wl->hw, skb_mapping); > >> > + if (dev->qos_enabled) > >> > + ieee80211_stop_queue(dev->wl->hw, skb_mapping); > >> > + else > >> > + ieee80211_stop_queue(dev->wl->hw, 0); > >> > >> Would this be a little cleaner if we only look up the queue mapping if > >> QOS is enabled? I.e. > > > > No. It would break the other uses of skb_mapping. > > > > But I am wondering why skb_mapping is non-zero in the first place. > > I think the actual bug might be somewhere else. > > Right, skb_mapping is used to map to the correct software structures DMA > mapped to the device. The reason the mapping for the best effort queue > (the default/defacto when QoS is disabled) is not zero is due to the way > initialization of the queues/rings occurs in the driver. The best effort > queue is mapped as the third queue, which leads to this issue when QoS > is disabled. Would it make more sense to change the mappings in > initialization such that the best effort queue is by default mapped to > zero, so we would not need such conditionals? Maybe it is a good idea to find the patch that broke non-QoS. That possibly helps to understand the situation. Non-QoS used to work just fine.
On Sat, 30 Dec, 2023 18:41:13 +0100 Michael Büsch <m@bues.ch> wrote: > [[PGP Signed Part:Undecided]] > On Sat, 30 Dec 2023 17:15:18 +0000 > Rahul Rameshbabu <sergeantsagara@protonmail.com> wrote: > >> On Sat, 30 Dec, 2023 14:40:36 +0100 Michael Büsch <m@bues.ch> wrote: >> > [[PGP Signed Part:Undecided]] >> > On Sat, 30 Dec 2023 18:48:45 +1100 >> > Julian Calaby <julian.calaby@gmail.com> wrote: >> >> > --- a/drivers/net/wireless/broadcom/b43/dma.c >> >> > +++ b/drivers/net/wireless/broadcom/b43/dma.c >> >> > @@ -1399,7 +1399,10 @@ int b43_dma_tx(struct b43_wldev *dev, struct sk_buff *skb) >> >> > should_inject_overflow(ring)) { >> >> > /* This TX ring is full. */ >> >> > unsigned int skb_mapping = skb_get_queue_mapping(skb); >> >> > - ieee80211_stop_queue(dev->wl->hw, skb_mapping); >> >> > + if (dev->qos_enabled) >> >> > + ieee80211_stop_queue(dev->wl->hw, skb_mapping); >> >> > + else >> >> > + ieee80211_stop_queue(dev->wl->hw, 0); >> >> >> >> Would this be a little cleaner if we only look up the queue mapping if >> >> QOS is enabled? I.e. >> > >> > No. It would break the other uses of skb_mapping. >> > >> > But I am wondering why skb_mapping is non-zero in the first place. >> > I think the actual bug might be somewhere else. >> >> Right, skb_mapping is used to map to the correct software structures DMA >> mapped to the device. The reason the mapping for the best effort queue >> (the default/defacto when QoS is disabled) is not zero is due to the way >> initialization of the queues/rings occurs in the driver. The best effort >> queue is mapped as the third queue, which leads to this issue when QoS >> is disabled. Would it make more sense to change the mappings in >> initialization such that the best effort queue is by default mapped to >> zero, so we would not need such conditionals? > > Maybe it is a good idea to find the patch that broke non-QoS. > That possibly helps to understand the situation. > > Non-QoS used to work just fine. I did some git analysis, and I actually believe that this issue has been present since the commit e6f5b934fba8 ("b43: Add QOS support"). Before then, non-QOS would not trigger this issue. There is a cosmetic change after this commit, b27faf8ebf25 ("b43: Rename the DMA ring pointers"), but this change does not introduce the issue (but makes it more obvious). I think the reason nobody has ever reported this is that even when the warnings are triggered, everything appears to work fine. I think therefore the two options are the following. 1. Remap the BE queue to 0 instead of the BK queue. 2. Use this kind of conditional to handle the mapping when QoS is disabled. -- Thanks, Rahul Rameshbabu
diff --git a/drivers/net/wireless/broadcom/b43/dma.c b/drivers/net/wireless/broadcom/b43/dma.c index 760d1a28edc6..68671de27569 100644 --- a/drivers/net/wireless/broadcom/b43/dma.c +++ b/drivers/net/wireless/broadcom/b43/dma.c @@ -1399,7 +1399,10 @@ int b43_dma_tx(struct b43_wldev *dev, struct sk_buff *skb) should_inject_overflow(ring)) { /* This TX ring is full. */ unsigned int skb_mapping = skb_get_queue_mapping(skb); - ieee80211_stop_queue(dev->wl->hw, skb_mapping); + if (dev->qos_enabled) + ieee80211_stop_queue(dev->wl->hw, skb_mapping); + else + ieee80211_stop_queue(dev->wl->hw, 0); dev->wl->tx_queue_stopped[skb_mapping] = true; ring->stopped = true; if (b43_debug(dev, B43_DBG_DMAVERBOSE)) { @@ -1570,7 +1573,10 @@ void b43_dma_handle_txstatus(struct b43_wldev *dev, } else { /* If the driver queue is running wake the corresponding * mac80211 queue. */ - ieee80211_wake_queue(dev->wl->hw, ring->queue_prio); + if (dev->qos_enabled) + ieee80211_wake_queue(dev->wl->hw, ring->queue_prio); + else + ieee80211_wake_queue(dev->wl->hw, 0); if (b43_debug(dev, B43_DBG_DMAVERBOSE)) { b43dbg(dev->wl, "Woke up TX ring %d\n", ring->index); }
When QoS is disabled, the queue priority value will not map to the correct ieee80211 queue since there is only one queue. Stop/wake queue 0 when QoS is disabled to prevent trying to stop/wake a non-existent queue and failing to stop/wake the actual queue instantiated. Log of issue before change (with kernel parameter qos=0): [ +5.112651] ------------[ cut here ]------------ [ +0.000005] WARNING: CPU: 7 PID: 25513 at net/mac80211/util.c:449 __ieee80211_wake_queue+0xd5/0x180 [mac80211] [ +0.000067] Modules linked in: b43(O) snd_seq_dummy snd_hrtimer snd_seq snd_seq_device nft_chain_nat xt_MASQUERADE nf_nat xfrm_user xfrm_algo xt_addrtype overlay ccm af_packet amdgpu snd_hda_codec_cirrus snd_hda_codec_generic ledtrig_audio drm_exec amdxcp gpu_sched xt_conntrack nf_conntrack nf_defrag_ipv6 nf_defrag_ipv4 ip6t_rpfilter ipt_rpfilter xt_pkttype xt_LOG nf_log_syslog xt_tcpudp nft_compat nf_tables nfnetlink sch_fq_codel btusb uinput iTCO_wdt ctr btrtl intel_pmc_bxt i915 intel_rapl_msr mei_hdcp mei_pxp joydev at24 watchdog btintel atkbd libps2 serio radeon btbcm vivaldi_fmap btmtk intel_rapl_common snd_hda_codec_hdmi bluetooth uvcvideo nls_iso8859_1 applesmc nls_cp437 x86_pkg_temp_thermal snd_hda_intel intel_powerclamp vfat videobuf2_vmalloc coretemp fat snd_intel_dspcfg crc32_pclmul uvc polyval_clmulni snd_intel_sdw_acpi loop videobuf2_memops snd_hda_codec tun drm_suballoc_helper polyval_generic drm_ttm_helper drm_buddy tap ecdh_generic videobuf2_v4l2 gf128mul macvlan ttm ghash_clmulni_intel ecc tg3 [ +0.000044] videodev bridge snd_hda_core rapl crc16 drm_display_helper cec mousedev snd_hwdep evdev intel_cstate bcm5974 hid_appleir videobuf2_common stp mac_hid libphy snd_pcm drm_kms_helper acpi_als mei_me intel_uncore llc mc snd_timer intel_gtt industrialio_triggered_buffer apple_mfi_fastcharge i2c_i801 mei snd lpc_ich agpgart ptp i2c_smbus thunderbolt apple_gmux i2c_algo_bit kfifo_buf video industrialio soundcore pps_core wmi tiny_power_button sbs sbshc button ac cordic bcma mac80211 cfg80211 ssb rfkill libarc4 kvm_intel kvm drm irqbypass fuse backlight firmware_class efi_pstore configfs efivarfs dmi_sysfs ip_tables x_tables autofs4 dm_crypt cbc encrypted_keys trusted asn1_encoder tee tpm rng_core input_leds hid_apple led_class hid_generic usbhid hid sd_mod t10_pi crc64_rocksoft crc64 crc_t10dif crct10dif_generic ahci libahci libata uhci_hcd ehci_pci ehci_hcd crct10dif_pclmul crct10dif_common sha512_ssse3 sha512_generic sha256_ssse3 sha1_ssse3 aesni_intel usbcore scsi_mod libaes crypto_simd cryptd scsi_common [ +0.000055] usb_common rtc_cmos btrfs blake2b_generic libcrc32c crc32c_generic crc32c_intel xor raid6_pq dm_snapshot dm_bufio dm_mod dax [last unloaded: b43(O)] [ +0.000009] CPU: 7 PID: 25513 Comm: irq/17-b43 Tainted: G W O 6.6.7 #1-NixOS [ +0.000003] Hardware name: Apple Inc. MacBookPro8,3/Mac-942459F5819B171B, BIOS 87.0.0.0.0 06/13/2019 [ +0.000001] RIP: 0010:__ieee80211_wake_queue+0xd5/0x180 [mac80211] [ +0.000046] Code: 00 45 85 e4 0f 85 9b 00 00 00 48 8d bd 40 09 00 00 f0 48 0f ba ad 48 09 00 00 00 72 0f 5b 5d 41 5c 41 5d 41 5e e9 cb 6d 3c d0 <0f> 0b 5b 5d 41 5c 41 5d 41 5e c3 cc cc cc cc 48 8d b4 16 94 00 00 [ +0.000002] RSP: 0018:ffffc90003c77d60 EFLAGS: 00010097 [ +0.000001] RAX: 0000000000000001 RBX: 0000000000000002 RCX: 0000000000000000 [ +0.000001] RDX: 0000000000000000 RSI: 0000000000000002 RDI: ffff88820b924900 [ +0.000002] RBP: ffff88820b924900 R08: ffffc90003c77d90 R09: 000000000003bfd0 [ +0.000001] R10: ffff88820b924900 R11: ffffc90003c77c68 R12: 0000000000000000 [ +0.000001] R13: 0000000000000000 R14: ffffc90003c77d90 R15: ffffffffc0fa6f40 [ +0.000001] FS: 0000000000000000(0000) GS:ffff88846fb80000(0000) knlGS:0000000000000000 [ +0.000001] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ +0.000001] CR2: 00007fafda7ae008 CR3: 000000046d220005 CR4: 00000000000606e0 [ +0.000002] Call Trace: [ +0.000003] <TASK> [ +0.000001] ? __ieee80211_wake_queue+0xd5/0x180 [mac80211] [ +0.000044] ? __warn+0x81/0x130 [ +0.000005] ? __ieee80211_wake_queue+0xd5/0x180 [mac80211] [ +0.000045] ? report_bug+0x171/0x1a0 [ +0.000004] ? handle_bug+0x41/0x70 [ +0.000004] ? exc_invalid_op+0x17/0x70 [ +0.000003] ? asm_exc_invalid_op+0x1a/0x20 [ +0.000005] ? __ieee80211_wake_queue+0xd5/0x180 [mac80211] [ +0.000043] ieee80211_wake_queue+0x4a/0x80 [mac80211] [ +0.000044] b43_dma_handle_txstatus+0x29c/0x3a0 [b43] [ +0.000016] ? __pfx_irq_thread_fn+0x10/0x10 [ +0.000002] b43_handle_txstatus+0x61/0x80 [b43] [ +0.000012] b43_interrupt_thread_handler+0x3f9/0x6b0 [b43] [ +0.000011] irq_thread_fn+0x23/0x60 [ +0.000002] irq_thread+0xfe/0x1c0 [ +0.000002] ? __pfx_irq_thread_dtor+0x10/0x10 [ +0.000001] ? __pfx_irq_thread+0x10/0x10 [ +0.000001] kthread+0xe8/0x120 [ +0.000003] ? __pfx_kthread+0x10/0x10 [ +0.000003] ret_from_fork+0x34/0x50 [ +0.000002] ? __pfx_kthread+0x10/0x10 [ +0.000002] ret_from_fork_asm+0x1b/0x30 [ +0.000004] </TASK> [ +0.000001] ---[ end trace 0000000000000000 ]--- [ +0.000065] ------------[ cut here ]------------ [ +0.000001] WARNING: CPU: 0 PID: 56077 at net/mac80211/util.c:514 __ieee80211_stop_queue+0xcc/0xe0 [mac80211] [ +0.000077] Modules linked in: b43(O) snd_seq_dummy snd_hrtimer snd_seq snd_seq_device nft_chain_nat xt_MASQUERADE nf_nat xfrm_user xfrm_algo xt_addrtype overlay ccm af_packet amdgpu snd_hda_codec_cirrus snd_hda_codec_generic ledtrig_audio drm_exec amdxcp gpu_sched xt_conntrack nf_conntrack nf_defrag_ipv6 nf_defrag_ipv4 ip6t_rpfilter ipt_rpfilter xt_pkttype xt_LOG nf_log_syslog xt_tcpudp nft_compat nf_tables nfnetlink sch_fq_codel btusb uinput iTCO_wdt ctr btrtl intel_pmc_bxt i915 intel_rapl_msr mei_hdcp mei_pxp joydev at24 watchdog btintel atkbd libps2 serio radeon btbcm vivaldi_fmap btmtk intel_rapl_common snd_hda_codec_hdmi bluetooth uvcvideo nls_iso8859_1 applesmc nls_cp437 x86_pkg_temp_thermal snd_hda_intel intel_powerclamp vfat videobuf2_vmalloc coretemp fat snd_intel_dspcfg crc32_pclmul uvc polyval_clmulni snd_intel_sdw_acpi loop videobuf2_memops snd_hda_codec tun drm_suballoc_helper polyval_generic drm_ttm_helper drm_buddy tap ecdh_generic videobuf2_v4l2 gf128mul macvlan ttm ghash_clmulni_intel ecc tg3 [ +0.000073] videodev bridge snd_hda_core rapl crc16 drm_display_helper cec mousedev snd_hwdep evdev intel_cstate bcm5974 hid_appleir videobuf2_common stp mac_hid libphy snd_pcm drm_kms_helper acpi_als mei_me intel_uncore llc mc snd_timer intel_gtt industrialio_triggered_buffer apple_mfi_fastcharge i2c_i801 mei snd lpc_ich agpgart ptp i2c_smbus thunderbolt apple_gmux i2c_algo_bit kfifo_buf video industrialio soundcore pps_core wmi tiny_power_button sbs sbshc button ac cordic bcma mac80211 cfg80211 ssb rfkill libarc4 kvm_intel kvm drm irqbypass fuse backlight firmware_class efi_pstore configfs efivarfs dmi_sysfs ip_tables x_tables autofs4 dm_crypt cbc encrypted_keys trusted asn1_encoder tee tpm rng_core input_leds hid_apple led_class hid_generic usbhid hid sd_mod t10_pi crc64_rocksoft crc64 crc_t10dif crct10dif_generic ahci libahci libata uhci_hcd ehci_pci ehci_hcd crct10dif_pclmul crct10dif_common sha512_ssse3 sha512_generic sha256_ssse3 sha1_ssse3 aesni_intel usbcore scsi_mod libaes crypto_simd cryptd scsi_common [ +0.000084] usb_common rtc_cmos btrfs blake2b_generic libcrc32c crc32c_generic crc32c_intel xor raid6_pq dm_snapshot dm_bufio dm_mod dax [last unloaded: b43] [ +0.000012] CPU: 0 PID: 56077 Comm: kworker/u16:17 Tainted: G W O 6.6.7 #1-NixOS [ +0.000003] Hardware name: Apple Inc. MacBookPro8,3/Mac-942459F5819B171B, BIOS 87.0.0.0.0 06/13/2019 [ +0.000001] Workqueue: phy7 b43_tx_work [b43] [ +0.000019] RIP: 0010:__ieee80211_stop_queue+0xcc/0xe0 [mac80211] [ +0.000076] Code: 74 11 48 8b 78 08 0f b7 d6 89 e9 4c 89 e6 e8 ab f4 00 00 65 ff 0d 9c b7 34 3f 0f 85 55 ff ff ff 0f 1f 44 00 00 e9 4b ff ff ff <0f> 0b 5b 5d 41 5c 41 5d c3 cc cc cc cc 0f 1f 80 00 00 00 00 90 90 [ +0.000002] RSP: 0000:ffffc90004157d50 EFLAGS: 00010097 [ +0.000002] RAX: 0000000000000001 RBX: 0000000000000002 RCX: 0000000000000000 [ +0.000002] RDX: 0000000000000000 RSI: 0000000000000002 RDI: ffff8882d65d0900 [ +0.000002] RBP: 0000000000000000 R08: 0000000000000001 R09: 0000000000000001 [ +0.000001] R10: 00000000000000ff R11: ffff88814d0155a0 R12: ffff8882d65d0900 [ +0.000002] R13: 0000000000000000 R14: ffff8881002d2800 R15: 00000000000000d0 [ +0.000002] FS: 0000000000000000(0000) GS:ffff88846f800000(0000) knlGS:0000000000000000 [ +0.000003] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ +0.000002] CR2: 00007f2e8c10c880 CR3: 0000000385b66005 CR4: 00000000000606f0 [ +0.000002] Call Trace: [ +0.000001] <TASK> [ +0.000001] ? __ieee80211_stop_queue+0xcc/0xe0 [mac80211] [ +0.000075] ? __warn+0x81/0x130 [ +0.000004] ? __ieee80211_stop_queue+0xcc/0xe0 [mac80211] [ +0.000075] ? report_bug+0x171/0x1a0 [ +0.000005] ? handle_bug+0x41/0x70 [ +0.000003] ? exc_invalid_op+0x17/0x70 [ +0.000004] ? asm_exc_invalid_op+0x1a/0x20 [ +0.000004] ? __ieee80211_stop_queue+0xcc/0xe0 [mac80211] [ +0.000076] ieee80211_stop_queue+0x36/0x50 [mac80211] [ +0.000077] b43_dma_tx+0x550/0x780 [b43] [ +0.000023] b43_tx_work+0x90/0x130 [b43] [ +0.000018] process_one_work+0x174/0x340 [ +0.000003] worker_thread+0x27b/0x3a0 [ +0.000004] ? __pfx_worker_thread+0x10/0x10 [ +0.000002] kthread+0xe8/0x120 [ +0.000003] ? __pfx_kthread+0x10/0x10 [ +0.000004] ret_from_fork+0x34/0x50 [ +0.000002] ? __pfx_kthread+0x10/0x10 [ +0.000003] ret_from_fork_asm+0x1b/0x30 [ +0.000006] </TASK> [ +0.000001] ---[ end trace 0000000000000000 ]--- Fixes: e6f5b934fba8 ("b43: Add QOS support") Signed-off-by: Rahul Rameshbabu <sergeantsagara@protonmail.com> --- drivers/net/wireless/broadcom/b43/dma.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)