diff mbox series

arm64: dts: qcom: sdm845-oneplus-common: improve DAI node naming

Message ID 20231229200245.259689-1-david@ixit.cz
State Accepted
Commit afe9867a0c0e10ba618c15d4ef6f8699872f6cc3
Headers show
Series arm64: dts: qcom: sdm845-oneplus-common: improve DAI node naming | expand

Commit Message

David Heidelberg Dec. 29, 2023, 8:02 p.m. UTC
Make it easier to understand what the reg in those nodes is by using the
constants provided by qcom,q6dsp-lpass-ports.h.

Name nodes according to dt-binding expectations.

Fix for
```
arch/arm64/boot/dts/qcom/sdm845-oneplus-enchilada.dtb: service@4: dais: Unevaluated properties are not allowed ('qi2s@22', 'qi2s@23' were unexpected)
```

Fixes: b7b734286856 ("arm64: dts: qcom: sdm845-oneplus-*: add audio devices")
Signed-off-by: David Heidelberg <david@ixit.cz>
---
 arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

Bjorn Andersson Jan. 28, 2024, 5:45 p.m. UTC | #1
On Fri, 29 Dec 2023 21:02:33 +0100, David Heidelberg wrote:
> Make it easier to understand what the reg in those nodes is by using the
> constants provided by qcom,q6dsp-lpass-ports.h.
> 
> Name nodes according to dt-binding expectations.
> 
> Fix for
> ```
> arch/arm64/boot/dts/qcom/sdm845-oneplus-enchilada.dtb: service@4: dais: Unevaluated properties are not allowed ('qi2s@22', 'qi2s@23' were unexpected)
> ```
> 
> [...]

Applied, thanks!

[1/1] arm64: dts: qcom: sdm845-oneplus-common: improve DAI node naming
      commit: 278d3807d304c90e59edb61aa7ed8a05e1e836bf

Best regards,
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
index e821103d49c0..46e25c53829a 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
@@ -508,13 +508,13 @@  led-1 {
 };
 
 &q6afedai {
-	qi2s@22 {
-		reg = <22>;
+	dai@22 {
+		reg = <QUATERNARY_MI2S_RX>;
 		qcom,sd-lines = <1>;
 	};
 
-	qi2s@23 {
-		reg = <23>;
+	dai@23 {
+		reg = <QUATERNARY_MI2S_TX>;
 		qcom,sd-lines = <0>;
 	};
 };