diff mbox

power: ab8500: cleanup with list_first_entry_or_null()

Message ID 1473704601-3217-1-git-send-email-yamada.masahiro@socionext.com
State Accepted
Commit f04f7aef7f6aafdc0ba54c6b9670cd11f9d9200a
Headers show

Commit Message

Masahiro Yamada Sept. 12, 2016, 6:23 p.m. UTC 
The combo of list_empty() check and return list_first_entry()
can be replaced with list_first_entry_or_null().

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

---

 drivers/power/ab8500_fg.c | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

-- 
1.9.1
diff mbox

Patch

diff --git a/drivers/power/ab8500_fg.c b/drivers/power/ab8500_fg.c
index 5a36cf8..84b7fa9 100644
--- a/drivers/power/ab8500_fg.c
+++ b/drivers/power/ab8500_fg.c
@@ -245,13 +245,8 @@  static LIST_HEAD(ab8500_fg_list);
  */
 struct ab8500_fg *ab8500_fg_get(void)
 {
-	struct ab8500_fg *fg;
-
-	if (list_empty(&ab8500_fg_list))
-		return NULL;
-
-	fg = list_first_entry(&ab8500_fg_list, struct ab8500_fg, node);
-	return fg;
+	return list_first_entry_or_null(&ab8500_fg_list, struct ab8500_fg,
+					node);
 }
 
 /* Main battery properties */