| Message ID | 20240105130404.301172-7-gatien.chevallier@foss.st.com |
|---|---|
| State | New |
| Headers | show |
| Series | Introduce STM32 Firewall framework | expand |
On Fri, Jan 5, 2024 at 5:03 AM Gatien Chevallier <gatien.chevallier@foss.st.com> wrote: > > Allows tracking dependencies between devices and their access > controller. > > Signed-off-by: Gatien Chevallier <gatien.chevallier@foss.st.com> > Acked-by: Rob Herring <robh@kernel.org> Please cc me on fw_devlink patches. Also, this patch is breaking the norm below. Please send a fix up patch. > --- > Changes in V9: > - Added Rob's review tag > > Changes in V6: > - Renamed access-controller to access-controllers > > Changes in V5: > - Rename feature-domain* to access-control* > > Patch not present in V1 > > drivers/of/property.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/of/property.c b/drivers/of/property.c > index afdaefbd03f6..7f737eac91b2 100644 > --- a/drivers/of/property.c > +++ b/drivers/of/property.c > @@ -1268,6 +1268,7 @@ DEFINE_SIMPLE_PROP(leds, "leds", NULL) > DEFINE_SIMPLE_PROP(backlight, "backlight", NULL) > DEFINE_SIMPLE_PROP(panel, "panel", NULL) > DEFINE_SIMPLE_PROP(msi_parent, "msi-parent", "#msi-cells") > +DEFINE_SIMPLE_PROP(access_controllers, "access-controllers", "#access-controller-cells") > DEFINE_SUFFIX_PROP(regulators, "-supply", NULL) > DEFINE_SUFFIX_PROP(gpio, "-gpio", "#gpio-cells") > > @@ -1363,6 +1364,7 @@ static const struct supplier_bindings of_supplier_bindings[] = { > { .parse_prop = parse_regulators, }, > { .parse_prop = parse_gpio, }, > { .parse_prop = parse_gpios, }, > + { .parse_prop = parse_access_controllers, }, All the simple properties are listed before the suffix ones as the suffix checks are more expensive. So, you should have inserted this right before the suffix properties. Also, there's a merge conflict in linux-next. So make sure you take that into account when sending the fix up and picking the order. -Saravana > {} > }; > > -- > 2.35.3 >
Hi Saravana On 4/24/24 07:57, Saravana Kannan wrote: > On Fri, Jan 5, 2024 at 5:03 AM Gatien Chevallier > <gatien.chevallier@foss.st.com> wrote: >> >> Allows tracking dependencies between devices and their access >> controller. >> >> Signed-off-by: Gatien Chevallier <gatien.chevallier@foss.st.com> >> Acked-by: Rob Herring <robh@kernel.org> > > Please cc me on fw_devlink patches. Also, this patch is breaking the > norm below. Please send a fix up patch. > >> --- >> Changes in V9: >> - Added Rob's review tag >> >> Changes in V6: >> - Renamed access-controller to access-controllers >> >> Changes in V5: >> - Rename feature-domain* to access-control* >> >> Patch not present in V1 >> >> drivers/of/property.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/of/property.c b/drivers/of/property.c >> index afdaefbd03f6..7f737eac91b2 100644 >> --- a/drivers/of/property.c >> +++ b/drivers/of/property.c >> @@ -1268,6 +1268,7 @@ DEFINE_SIMPLE_PROP(leds, "leds", NULL) >> DEFINE_SIMPLE_PROP(backlight, "backlight", NULL) >> DEFINE_SIMPLE_PROP(panel, "panel", NULL) >> DEFINE_SIMPLE_PROP(msi_parent, "msi-parent", "#msi-cells") >> +DEFINE_SIMPLE_PROP(access_controllers, "access-controllers", "#access-controller-cells") >> DEFINE_SUFFIX_PROP(regulators, "-supply", NULL) >> DEFINE_SUFFIX_PROP(gpio, "-gpio", "#gpio-cells") >> >> @@ -1363,6 +1364,7 @@ static const struct supplier_bindings of_supplier_bindings[] = { >> { .parse_prop = parse_regulators, }, >> { .parse_prop = parse_gpio, }, >> { .parse_prop = parse_gpios, }, >> + { .parse_prop = parse_access_controllers, }, > > All the simple properties are listed before the suffix ones as the > suffix checks are more expensive. So, you should have inserted this > right before the suffix properties. Also, there's a merge conflict in > linux-next. So make sure you take that into account when sending the > fix up and picking the order. I'm fixing the stm32-next branch by inserting { .parse_prop = parse_access_controllers, }, just before { .parse_prop = parse_regulators, }, > > -Saravana > >> {} >> }; > >> >> -- >> 2.35.3 >>
diff --git a/drivers/of/property.c b/drivers/of/property.c index afdaefbd03f6..7f737eac91b2 100644 --- a/drivers/of/property.c +++ b/drivers/of/property.c @@ -1268,6 +1268,7 @@ DEFINE_SIMPLE_PROP(leds, "leds", NULL) DEFINE_SIMPLE_PROP(backlight, "backlight", NULL) DEFINE_SIMPLE_PROP(panel, "panel", NULL) DEFINE_SIMPLE_PROP(msi_parent, "msi-parent", "#msi-cells") +DEFINE_SIMPLE_PROP(access_controllers, "access-controllers", "#access-controller-cells") DEFINE_SUFFIX_PROP(regulators, "-supply", NULL) DEFINE_SUFFIX_PROP(gpio, "-gpio", "#gpio-cells") @@ -1363,6 +1364,7 @@ static const struct supplier_bindings of_supplier_bindings[] = { { .parse_prop = parse_regulators, }, { .parse_prop = parse_gpio, }, { .parse_prop = parse_gpios, }, + { .parse_prop = parse_access_controllers, }, {} };