| Message ID | 20240108135421.684263-4-tmaimon77@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | None | expand |
Hi Krzysztof, Thanks for your comment. On Wed, 10 Jan 2024 at 23:01, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 08/01/2024 14:54, Tomer Maimon wrote: > > rst node name and compatible property modified since clock and reset are > > handled in the same memory region. > > > > Signed-off-by: Tomer Maimon <tmaimon77@gmail.com> > > --- > > arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi b/arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi > > index 868454ae6bde..f72c5a03d04c 100644 > > --- a/arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi > > +++ b/arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi > > @@ -93,8 +93,8 @@ gcr: gcr@800000 { > > reg = <0x800000 0x1000>; > > }; > > > > - rst: rst@801000 { > > - compatible = "nuvoton,npcm750-rst", "syscon", "simple-mfd"; > > + clk_rst: syscon@801000 { > > + compatible = "nuvoton,npcm750-clk-rst", "syscon", "simple-mfd"; > > NAK. This breakes the users, is not justified, is not explained. Sorry, I didn't understand, which user it is breaking? there isn't a device tree node that uses the rst node. Should I explain it better in the commit message? > > Best regards, > Krzysztof > Best regards, Tomer
On 16/01/2024 20:51, Tomer Maimon wrote: > Hi Krzysztof, > > Thanks for your comment. > > On Wed, 10 Jan 2024 at 23:01, Krzysztof Kozlowski > <krzysztof.kozlowski@linaro.org> wrote: >> >> On 08/01/2024 14:54, Tomer Maimon wrote: >>> rst node name and compatible property modified since clock and reset are >>> handled in the same memory region. >>> >>> Signed-off-by: Tomer Maimon <tmaimon77@gmail.com> >>> --- >>> arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi b/arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi >>> index 868454ae6bde..f72c5a03d04c 100644 >>> --- a/arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi >>> +++ b/arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi >>> @@ -93,8 +93,8 @@ gcr: gcr@800000 { >>> reg = <0x800000 0x1000>; >>> }; >>> >>> - rst: rst@801000 { >>> - compatible = "nuvoton,npcm750-rst", "syscon", "simple-mfd"; >>> + clk_rst: syscon@801000 { >>> + compatible = "nuvoton,npcm750-clk-rst", "syscon", "simple-mfd"; >> >> NAK. This breakes the users, is not justified, is not explained. > Sorry, I didn't understand, which user it is breaking? there isn't a > device tree node that uses the rst node. Any user of this DTS. > Should I explain it better in the commit message? I doubt that you can find proper reason, because "I want different name" is not valid. It's just compatible, it cannot be changed just because you add new property. Best regards, Krzysztof
diff --git a/arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi b/arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi index 868454ae6bde..f72c5a03d04c 100644 --- a/arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi +++ b/arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi @@ -93,8 +93,8 @@ gcr: gcr@800000 { reg = <0x800000 0x1000>; }; - rst: rst@801000 { - compatible = "nuvoton,npcm750-rst", "syscon", "simple-mfd"; + clk_rst: syscon@801000 { + compatible = "nuvoton,npcm750-clk-rst", "syscon", "simple-mfd"; reg = <0x801000 0x6C>; }; };
rst node name and compatible property modified since clock and reset are handled in the same memory region. Signed-off-by: Tomer Maimon <tmaimon77@gmail.com> --- arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)