| Message ID | 1473834587-22526-1-git-send-email-baoyou.xie@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
On Wednesday, September 14, 2016 2:29:47 PM CEST Baoyou Xie wrote: > We get 1 warning when building kernel with W=1: > drivers/clk/versatile/clk-realview.c:54:13: warning: no previous prototype for 'realview_clk_init' [-Wmissing-prototypes] > > In fact, this function is declared in clk-realview.h, > so this patch add missing header dependencies. > > Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org> > Please leave this one for now. We are in the process of removing the last caller of this function, and should just remove the header file and the function definition in the next release. Arnd
On Wed, Sep 14, 2016 at 9:31 AM, Arnd Bergmann <arnd@arndb.de> wrote: > On Wednesday, September 14, 2016 2:29:47 PM CEST Baoyou Xie wrote: >> We get 1 warning when building kernel with W=1: >> drivers/clk/versatile/clk-realview.c:54:13: warning: no previous prototype for 'realview_clk_init' [-Wmissing-prototypes] >> >> In fact, this function is declared in clk-realview.h, >> so this patch add missing header dependencies. >> >> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org> >> > > Please leave this one for now. We are in the process of removing the > last caller of this function, and should just remove the header file > and the function definition in the next release. +1 on this, leave it. I can clean it up for v4.10 or even for an -rc if you want it real neat in v4.9. Yours, Linus Walleij
On Wednesday, September 14, 2016 11:04:29 AM CEST Linus Walleij wrote: > On Wed, Sep 14, 2016 at 9:31 AM, Arnd Bergmann <arnd@arndb.de> wrote: > > On Wednesday, September 14, 2016 2:29:47 PM CEST Baoyou Xie wrote: > >> We get 1 warning when building kernel with W=1: > >> drivers/clk/versatile/clk-realview.c:54:13: warning: no previous prototype for 'realview_clk_init' [-Wmissing-prototypes] > >> > >> In fact, this function is declared in clk-realview.h, > >> so this patch add missing header dependencies. > >> > >> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org> > >> > > > > Please leave this one for now. We are in the process of removing the > > last caller of this function, and should just remove the header file > > and the function definition in the next release. > > +1 on this, leave it. I can clean it up for v4.10 or even > for an -rc if you want it real neat in v4.9. > I think v4.10 is fine: Baoyou has done a great job so far fixing a lot of those warnings, but we already know that there will be a lot remaining after v4.9, so v4.10 is the earliest possible version in which we can turn on the warning by default. Arnd
diff --git a/drivers/clk/versatile/clk-realview.c b/drivers/clk/versatile/clk-realview.c index c56efc7..f662fd1 100644 --- a/drivers/clk/versatile/clk-realview.c +++ b/drivers/clk/versatile/clk-realview.c @@ -10,6 +10,7 @@ #include <linux/err.h> #include <linux/io.h> #include <linux/clk-provider.h> +#include <linux/platform_data/clk-realview.h> #include "clk-icst.h"
We get 1 warning when building kernel with W=1: drivers/clk/versatile/clk-realview.c:54:13: warning: no previous prototype for 'realview_clk_init' [-Wmissing-prototypes] In fact, this function is declared in clk-realview.h, so this patch add missing header dependencies. Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org> --- drivers/clk/versatile/clk-realview.c | 1 + 1 file changed, 1 insertion(+) -- 2.7.4