diff mbox series

[2/2] smbios: fix matching issues for table types

Message ID 20240111143936.983448-2-ilias.apalodimas@linaro.org
State Accepted
Commit b6488caa1fd1a528718e15b87dfe980f366b88b3
Headers show
Series [1/2] smbios: shorten sysinfo_str declarations and use | expand

Commit Message

Ilias Apalodimas Jan. 11, 2024, 2:39 p.m. UTC 
commit 738b34668f28 ("smbios: Fallback to the default DT if sysinfo nodes are missing")
allowed the code to fallback and fill in SMBIOS tables with properties
from the compatible and product nodes of the DT, in case the
'smbios,sysinfo' node is missing.
That works fine for Type1/2 tables, but for other types we need to
match the smbios,sysinfo subnode name as well. So add it to the
smbios_ctx and check it during the sysinfo <-> DT mathcing

Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
---
We still lack selftests for smbios code.
Heinrich started an effort here [0]. I'll update that once his series gets merged

[0]
https://lore.kernel.org/u-boot/20231223004429.247301-4-xypron.glpk@gmx.de/#t

 lib/smbios.c | 45 ++++++++++++++++++++++++++++-----------------
 1 file changed, 28 insertions(+), 17 deletions(-)

--
2.37.2

Comments

Tom Rini Jan. 19, 2024, 4:09 p.m. UTC | #1 
On Thu, Jan 11, 2024 at 04:39:36PM +0200, Ilias Apalodimas wrote:

> commit 738b34668f28 ("smbios: Fallback to the default DT if sysinfo nodes are missing")
> allowed the code to fallback and fill in SMBIOS tables with properties
> from the compatible and product nodes of the DT, in case the
> 'smbios,sysinfo' node is missing.
> That works fine for Type1/2 tables, but for other types we need to
> match the smbios,sysinfo subnode name as well. So add it to the
> smbios_ctx and check it during the sysinfo <-> DT mathcing
> 
> Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>

Applied to u-boot/master, thanks!
diff mbox series

Patch

diff --git a/lib/smbios.c b/lib/smbios.c
index 47db410a2141..64e65bfd6f93 100644
--- a/lib/smbios.c
+++ b/lib/smbios.c
@@ -54,32 +54,38 @@  DECLARE_GLOBAL_DATA_PTR;
  *
  */
 struct map_sysinfo {
+	const char *si_node;
 	const char *si_str;
 	const char *dt_str;
 	int max;
 };

 static const struct map_sysinfo sysinfo_to_dt[] = {
-	{ .si_str = "product", .dt_str = "model", 2 },
-	{ .si_str = "manufacturer", .dt_str = "compatible", 1 },
+	{ .si_node = "system", .si_str = "product", .dt_str = "model", 2 },
+	{ .si_node = "system", .si_str = "manufacturer", .dt_str = "compatible", 1 },
+	{ .si_node = "baseboard", .si_str = "product", .dt_str = "model", 2 },
+	{ .si_node = "baseboard", .si_str = "manufacturer", .dt_str = "compatible", 1 },
 };

 /**
  * struct smbios_ctx - context for writing SMBIOS tables
  *
- * @node:	node containing the information to write (ofnode_null() if none)
- * @dev:	sysinfo device to use (NULL if none)
- * @eos:	end-of-string pointer for the table being processed. This is set
- *		up when we start processing a table
- * @next_ptr:	pointer to the start of the next string to be added. When the
- *		table is nopt empty, this points to the byte after the \0 of the
- *		previous string.
- * @last_str:	points to the last string that was written to the table, or NULL
- *		if none
+ * @node:		node containing the information to write (ofnode_null()
+ *			if none)
+ * @dev:		sysinfo device to use (NULL if none)
+ * @subnode_name:	sysinfo subnode_name. Used for DT fallback
+ * @eos:		end-of-string pointer for the table being processed.
+ *			This is set up when we start processing a table
+ * @next_ptr:		pointer to the start of the next string to be added.
+ *			When the table is not empty, this points to the byte
+ *			after the \0 of the previous string.
+ * @last_str:		points to the last string that was written to the table,
+ *			or NULL if none
  */
 struct smbios_ctx {
 	ofnode node;
 	struct udevice *dev;
+	const char *subnode_name;
 	char *eos;
 	char *next_ptr;
 	char *last_str;
@@ -108,12 +114,13 @@  struct smbios_write_method {
 	const char *subnode_name;
 };

-static const struct map_sysinfo *convert_sysinfo_to_dt(const char *si)
+static const struct map_sysinfo *convert_sysinfo_to_dt(const char *node, const char *si)
 {
 	int i;

 	for (i = 0; i < ARRAY_SIZE(sysinfo_to_dt); i++) {
-		if (!strcmp(si, sysinfo_to_dt[i].si_str))
+		if (node && !strcmp(node, sysinfo_to_dt[i].si_node) &&
+		    !strcmp(si, sysinfo_to_dt[i].si_str))
 			return &sysinfo_to_dt[i];
 	}

@@ -233,7 +240,7 @@  static int smbios_add_prop_si(struct smbios_ctx *ctx, const char *prop,
 		} else {
 			const struct map_sysinfo *nprop;

-			nprop = convert_sysinfo_to_dt(prop);
+			nprop = convert_sysinfo_to_dt(ctx->subnode_name, prop);
 			get_str_from_dt(nprop, str_dt, sizeof(str_dt));
 			str = (const char *)str_dt;
 		}
@@ -574,9 +581,13 @@  ulong write_smbios_table(ulong addr)
 		int tmp;

 		method = &smbios_write_funcs[i];
-		if (IS_ENABLED(CONFIG_OF_CONTROL) && method->subnode_name)
-			ctx.node = ofnode_find_subnode(parent_node,
-						       method->subnode_name);
+		ctx.subnode_name = NULL;
+		if (method->subnode_name) {
+			ctx.subnode_name = method->subnode_name;
+			if (IS_ENABLED(CONFIG_OF_CONTROL))
+				ctx.node = ofnode_find_subnode(parent_node,
+							       method->subnode_name);
+		}
 		tmp = method->write((ulong *)&addr, handle++, &ctx);

 		max_struct_size = max(max_struct_size, tmp);