diff mbox

[1/7] mfd: max8997-irq: 'inline' should be at the beginning of the declaration

Message ID 20160915104521.14286-2-lee.jones@linaro.org
State Accepted
Commit c646e2b115b0a23a013b91df5c54c8f5d06e607b
Headers show

Commit Message

Lee Jones Sept. 15, 2016, 10:45 a.m. UTC
Reported by [-Wold-style-declaration].

Signed-off-by: Lee Jones <lee.jones@linaro.org>

---
 drivers/mfd/max8997-irq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.9.3

Comments

Arnd Bergmann Sept. 15, 2016, 11:28 a.m. UTC | #1
On Thursday, September 15, 2016 11:45:15 AM CEST Lee Jones wrote:
> -static const inline struct max8997_irq_data *

> +inline static const struct max8997_irq_data *


I think this causes another warning, the order should be
"stastic inline const struct max8997_irq_data".

	Arnd
diff mbox

Patch

diff --git a/drivers/mfd/max8997-irq.c b/drivers/mfd/max8997-irq.c
index b95a46d7..326f17b 100644
--- a/drivers/mfd/max8997-irq.c
+++ b/drivers/mfd/max8997-irq.c
@@ -139,7 +139,7 @@  static void max8997_irq_sync_unlock(struct irq_data *data)
 	mutex_unlock(&max8997->irqlock);
 }
 
-static const inline struct max8997_irq_data *
+inline static const struct max8997_irq_data *
 irq_to_max8997_irq(struct max8997_dev *max8997, struct irq_data *data)
 {
 	return &max8997_irqs[data->hwirq];