diff mbox series

media: staging: imx: controls are from another device, mark this

Message ID f0b81292-3c91-4e89-86da-f31f89dfcd9a@xs4all.nl
State Accepted
Commit 24d9cb1430134608e1c7e7dbcca8b83396ea0dc8
Headers show
Series media: staging: imx: controls are from another device, mark this | expand

Commit Message

Hans Verkuil Jan. 17, 2024, 11:46 a.m. UTC
The last argument of v4l2_ctrl_add_handler() indicates whether the controls
you add are from a control handler owned by another driver (true) or from the
same driver (false). In this case the last argument was incorrectly set to
false. The control handlers are from different devices.

Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
---
diff mbox series

Patch

diff --git a/drivers/staging/media/imx/imx-media-fim.c b/drivers/staging/media/imx/imx-media-fim.c
index e28a33d9dec7..ccbc0371fba2 100644
--- a/drivers/staging/media/imx/imx-media-fim.c
+++ b/drivers/staging/media/imx/imx-media-fim.c
@@ -401,7 +401,7 @@  int imx_media_fim_add_controls(struct imx_media_fim *fim)
 {
 	/* add the FIM controls to the calling subdev ctrl handler */
 	return v4l2_ctrl_add_handler(fim->sd->ctrl_handler,
-				     &fim->ctrl_handler, NULL, false);
+				     &fim->ctrl_handler, NULL, true);
 }

 /* Called by the subdev in its subdev registered callback */