diff mbox series

[1/2] ASoC: dt-bindings: tegra: Document iommus and interconnects for ADMAIF

Message ID 20240118142706.4179146-1-thierry.reding@gmail.com
State New
Headers show
Series [1/2] ASoC: dt-bindings: tegra: Document iommus and interconnects for ADMAIF | expand

Commit Message

Thierry Reding Jan. 18, 2024, 2:27 p.m. UTC 
From: Thierry Reding <treding@nvidia.com>

The ADMAIF is responsible for accessing system memory on behalf of other
components of the APE, so make sure it can be hooked up to an IOMMU and
memory controller.

Signed-off-by: Thierry Reding <treding@nvidia.com>
---
 .../bindings/sound/nvidia,tegra210-admaif.yaml       | 12 ++++++++++++
 1 file changed, 12 insertions(+)

Comments

Rob Herring (Arm) Jan. 30, 2024, 5:56 p.m. UTC | #1 
On Thu, Jan 18, 2024 at 03:27:06PM +0100, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>

Subject prefix is wrong. See patch 1 for correct prefix.

> 
> The HDA controller on Tegra194 and Tegra234 uses a slightly different
> set of clocks and resets, so describe those accurately in the bindings.
> 
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
>  .../bindings/sound/nvidia,tegra30-hda.yaml    | 95 +++++++++++++++++--
>  1 file changed, 85 insertions(+), 10 deletions(-)

Otherwise,

Reviewed-by: Rob Herring <robh@kernel.org>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra210-admaif.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra210-admaif.yaml
index 15ab40aeab1e..59304f02d063 100644
--- a/Documentation/devicetree/bindings/sound/nvidia,tegra210-admaif.yaml
+++ b/Documentation/devicetree/bindings/sound/nvidia,tegra210-admaif.yaml
@@ -39,6 +39,18 @@  properties:
 
   dma-names: true
 
+  iommus:
+    maxItems: 1
+
+  interconnects:
+    description: Description of the interconnect paths for the ADMA interface; see
+      ../interconnect/interconnect.txt for details.
+
+  interconnect-names:
+    items:
+      - const: dma-mem # read
+      - const: write
+
   ports:
     $ref: /schemas/graph.yaml#/properties/ports
     description: |