| Message ID | 1705657530-17975-1-git-send-email-quic_zijuhu@quicinc.com |
|---|---|
| State | Accepted |
| Commit | 64692e12507b3efd71b4ff5596c9742d91f1ffe5 |
| Headers | show |
| Series | [v1] Bluetooth: qca: Fix wrong event type for patch config command | expand |
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=818061 ---Test result--- Test Summary: CheckPatch PASS 0.62 seconds GitLint PASS 0.31 seconds SubjectPrefix PASS 0.12 seconds BuildKernel PASS 27.39 seconds CheckAllWarning PASS 30.22 seconds CheckSparse PASS 35.54 seconds CheckSmatch PASS 98.06 seconds BuildKernel32 PASS 26.69 seconds TestRunnerSetup PASS 427.49 seconds TestRunner_l2cap-tester PASS 22.72 seconds TestRunner_iso-tester PASS 44.71 seconds TestRunner_bnep-tester PASS 6.86 seconds TestRunner_mgmt-tester PASS 151.80 seconds TestRunner_rfcomm-tester PASS 10.65 seconds TestRunner_sco-tester PASS 14.28 seconds TestRunner_ioctl-tester PASS 11.94 seconds TestRunner_mesh-tester PASS 9.63 seconds TestRunner_smp-tester PASS 9.68 seconds TestRunner_userchan-tester PASS 7.08 seconds IncrementalBuild PASS 25.44 seconds --- Regards, Linux Bluetooth
Hello: This patch was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>: On Fri, 19 Jan 2024 17:45:30 +0800 you wrote: > Vendor-specific command patch config has HCI_Command_Complete event as > response, but qca_send_patch_config_cmd() wrongly expects vendor-specific > event for the command, fixed by using right event type. > > Btmon log for the vendor-specific command are shown below: > < HCI Command: Vendor (0x3f|0x0000) plen 5 > 28 01 00 00 00 > > HCI Event: Command Complete (0x0e) plen 5 > Vendor (0x3f|0x0000) ncmd 1 > Status: Success (0x00) > 28 > > [...] Here is the summary with links: - [v1] Bluetooth: qca: Fix wrong event type for patch config command https://git.kernel.org/bluetooth/bluetooth-next/c/64692e12507b You are awesome, thank you!
diff --git a/drivers/bluetooth/btqca.c b/drivers/bluetooth/btqca.c index fdb0fae88d1c..b40b32fa7f1c 100644 --- a/drivers/bluetooth/btqca.c +++ b/drivers/bluetooth/btqca.c @@ -152,7 +152,7 @@ static int qca_send_patch_config_cmd(struct hci_dev *hdev) bt_dev_dbg(hdev, "QCA Patch config"); skb = __hci_cmd_sync_ev(hdev, EDL_PATCH_CMD_OPCODE, sizeof(cmd), - cmd, HCI_EV_VENDOR, HCI_INIT_TIMEOUT); + cmd, 0, HCI_INIT_TIMEOUT); if (IS_ERR(skb)) { err = PTR_ERR(skb); bt_dev_err(hdev, "Sending QCA Patch config failed (%d)", err);
Vendor-specific command patch config has HCI_Command_Complete event as response, but qca_send_patch_config_cmd() wrongly expects vendor-specific event for the command, fixed by using right event type. Btmon log for the vendor-specific command are shown below: < HCI Command: Vendor (0x3f|0x0000) plen 5 28 01 00 00 00 > HCI Event: Command Complete (0x0e) plen 5 Vendor (0x3f|0x0000) ncmd 1 Status: Success (0x00) 28 Fixes: 4fac8a7ac80b ("Bluetooth: btqca: sequential validation") Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com> --- drivers/bluetooth/btqca.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)