| Message ID | 20240120182929.1129183-2-martin@kaiser.cx |
|---|---|
| State | Accepted |
| Commit | f57595788244a838deec2d3be375291327cbc035 |
| Headers | show |
| Series | gpio: vf610: allow disabling the vf610 driver | expand |
On Sat, Jan 20, 2024 at 07:29:27PM +0100, Martin Kaiser wrote: > The vf610 gpio driver is enabled by default for all i.MX machines, > without any option to disable it in a board-specific config file. > > Most i.MX chipsets have no hardware for this driver. Change the default > to enable GPIO_VF610 for SOC_VF610 and disable it otherwise. Hi Martin Please ensure it is compiled when COMPILE_TEST is set. We don't want to reduce build test coverage. Andrew
diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig index 1301cec94f12..353af1a4d0ac 100644 --- a/drivers/gpio/Kconfig +++ b/drivers/gpio/Kconfig @@ -711,7 +711,8 @@ config GPIO_UNIPHIER Say yes here to support UniPhier GPIOs. config GPIO_VF610 - def_bool y + bool "VF610 GPIO support" + default y if SOC_VF610 depends on ARCH_MXC select GPIOLIB_IRQCHIP help
The vf610 gpio driver is enabled by default for all i.MX machines, without any option to disable it in a board-specific config file. Most i.MX chipsets have no hardware for this driver. Change the default to enable GPIO_VF610 for SOC_VF610 and disable it otherwise. Add a text description after the bool type, this makes the driver selectable by make config etc. Fixes: 30a35c07d9e9 ("gpio: vf610: drop the SOC_VF610 dependency for GPIO_VF610") Signed-off-by: Martin Kaiser <martin@kaiser.cx> --- v3: - split the changes into three patches v2: - enable the vf610 gpio driver in the defconfig files for arm_v7 (i.MX7ULP) and arm64 (i.MX8QM, DXL, ULP and i.MX93) drivers/gpio/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)