| Message ID | 1474198793-25108-1-git-send-email-baoyou.xie@linaro.org |
|---|---|
| State | New |
| Headers | show |
> We get 1 warning when building kernel with W=1: > drivers/staging/lustre/lustre/lmv/lmv_obd.c:2774:5: warning: no previous prototype for 'lmv_pack_md' [-Wmissing-prototypes] > > In fact, this function is not declared in any file,but should be > declared in a header file, thus can be recognized in other file. > > So this patch adds the declarations into > drivers/staging/lustre/lustre/include/lustre_lmv.h. > > Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org> > --- > drivers/staging/lustre/lustre/include/lustre_lmv.h | 2 ++ > 1 file changed, 2 insertions(+) Nak. I'm not seeing this error with W=1. Also if you look lmv_pack_md() is only used in lmv_obd.c and the function appears early in the file before it is used, so no prototype missing errors should happen. > diff --git a/drivers/staging/lustre/lustre/include/lustre_lmv.h b/drivers/staging/lustre/lustre/include/lustre_lmv.h > index 085e596..21302c7 100644 > --- a/drivers/staging/lustre/lustre/include/lustre_lmv.h > +++ b/drivers/staging/lustre/lustre/include/lustre_lmv.h > @@ -119,3 +119,5 @@ static inline void lmv_le_to_cpu(union lmv_mds_md *lmv_dst, > } > > +int lmv_pack_md(union lmv_mds_md **lmmp, const struct lmv_stripe_md *lsm, > + int stripe_count); > #endif > -- > 2.7.4 > >
On Sunday, September 18, 2016 8:43:18 PM CEST James Simmons wrote: > > Nak. I'm not seeing this error with W=1. Also if you look > lmv_pack_md() is only used in lmv_obd.c and the function > appears early in the file before it is used, so no prototype > missing errors should happen. So it should be marked "static" and the EXPORT_SYMBOL() removed, right? Arnd
> On Sunday, September 18, 2016 8:43:18 PM CEST James Simmons wrote: > > > > Nak. I'm not seeing this error with W=1. Also if you look > > lmv_pack_md() is only used in lmv_obd.c and the function > > appears early in the file before it is used, so no prototype > > missing errors should happen. > > So it should be marked "static" and the EXPORT_SYMBOL() removed, > right? Already done. See patch [PATCH 109/124] staging: lustre: misc: remove unnecessary EXPORT_SYMBOL which is from Frank Zago which I just pushed to Greg.
diff --git a/drivers/staging/lustre/lustre/include/lustre_lmv.h b/drivers/staging/lustre/lustre/include/lustre_lmv.h index 085e596..21302c7 100644 --- a/drivers/staging/lustre/lustre/include/lustre_lmv.h +++ b/drivers/staging/lustre/lustre/include/lustre_lmv.h @@ -119,3 +119,5 @@ static inline void lmv_le_to_cpu(union lmv_mds_md *lmv_dst, } +int lmv_pack_md(union lmv_mds_md **lmmp, const struct lmv_stripe_md *lsm, + int stripe_count); #endif
We get 1 warning when building kernel with W=1: drivers/staging/lustre/lustre/lmv/lmv_obd.c:2774:5: warning: no previous prototype for 'lmv_pack_md' [-Wmissing-prototypes] In fact, this function is not declared in any file,but should be declared in a header file, thus can be recognized in other file. So this patch adds the declarations into drivers/staging/lustre/lustre/include/lustre_lmv.h. Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org> --- drivers/staging/lustre/lustre/include/lustre_lmv.h | 2 ++ 1 file changed, 2 insertions(+) -- 2.7.4