From patchwork Sun Sep 18 12:07:59 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baoyou Xie X-Patchwork-Id: 76464 Delivered-To: patch@linaro.org Received: by 10.140.106.72 with SMTP id d66csp500780qgf; Sun, 18 Sep 2016 05:08:16 -0700 (PDT) X-Received: by 10.66.245.204 with SMTP id xq12mr13997941pac.37.1474200495976; Sun, 18 Sep 2016 05:08:15 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u9si22632431pax.163.2016.09.18.05.08.15 for ; Sun, 18 Sep 2016 05:08:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-scsi-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-scsi-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=fail (p=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756737AbcIRMIN (ORCPT ); Sun, 18 Sep 2016 08:08:13 -0400 Received: from mail-pa0-f50.google.com ([209.85.220.50]:33275 "EHLO mail-pa0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752031AbcIRMIM (ORCPT ); Sun, 18 Sep 2016 08:08:12 -0400 Received: by mail-pa0-f50.google.com with SMTP id hm5so7431292pac.0 for ; Sun, 18 Sep 2016 05:08:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=JKTmFdJSA5x/j1WDhoRo11DKOw9Vn9/CJKK5Xlh5YXM=; b=QdOJQ/LExImMM07wFeoM2w9QnJ2xx9iTK8Bi2NLdOaXjL9MNtIxjyYIj1UeDwEHUpZ pF/LrSOsZ1A2QQ35yTX5lUVQLOgF3aClJgTEmoUBVLdt6s5VSwIJ7CSyGifkQSdw4AxC 5KOk2Q8KJQZaWqPjSmvXrtPCE5PKZcaOM5Ge8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=JKTmFdJSA5x/j1WDhoRo11DKOw9Vn9/CJKK5Xlh5YXM=; b=jrNv3nEEp4U0yT19KTPZqWTwLNYOD4Hz4hAbZBqKseYUleVbDqBSPS3nZc6P6k7YrD jJBIZqQn1OjjspwcWe1ESwy6rng/sgZ31D3OU3LmQ92dzlFPJiAmazLBCVjvi7xr9eer AvzEkd0fGsabJHKb64MNk5crto7bfuLYl8UkexSPIpvrovT1KFSW8MgeTOC4B/ycK8iN YyBsJvfclNO1MQalSlognaWs9mwoLqYBju+RsjnlstEbMCSQzo3L6agnVEugkDIsOxek 04ZZHGso3yueDluP9ps4sndCxVQEfwLrl0kxzPFr8miB8Slh4MT/54fctKlV02qEBQ1g 9woA== X-Gm-Message-State: AE9vXwPu2lZlAio1rs0WeYbWKCIKFur3yNz66XiaorXpfCwThv11gRSuYQ1x/xvBc07gkR81 X-Received: by 10.67.23.4 with SMTP id hw4mr38415950pad.7.1474200491686; Sun, 18 Sep 2016 05:08:11 -0700 (PDT) Received: from localhost.localdomain ([104.237.91.27]) by smtp.gmail.com with ESMTPSA id i8sm24217609paw.25.2016.09.18.05.08.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 18 Sep 2016 05:08:11 -0700 (PDT) From: Baoyou Xie To: kashyap.desai@avagotech.com, sumit.saxena@avagotech.com, uday.lingala@avagotech.com, jejb@linux.vnet.ibm.com, martin.petersen@oracle.com Cc: megaraidlinux.pdl@avagotech.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, arnd@arndb.de, baoyou.xie@linaro.org, xie.baoyou@zte.com.cn Subject: [PATCH] megaraid_sas: clean function declarations in megaraid_sas_base.c up Date: Sun, 18 Sep 2016 20:07:59 +0800 Message-Id: <1474200479-32042-1-git-send-email-baoyou.xie@linaro.org> X-Mailer: git-send-email 2.7.4 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org We get a few warnings when building kernel with W=1: drivers/scsi/megaraid/megaraid_sas_fusion.c:281:1: warning: no previous prototype for 'megasas_free_cmds_fusion' [-Wmissing-prototypes] drivers/scsi/megaraid/megaraid_sas_fusion.c:714:1: warning: no previous prototype for 'megasas_ioc_init_fusion' [-Wmissing-prototypes] .... In fact, these functions are declared in drivers/scsi/megaraid/megaraid_sas_base.c, but should be declared in a header file, thus can be recognized in other file. So this patch adds the declarations into drivers/scsi/megaraid/megaraid_sas_fusion.h. Signed-off-by: Baoyou Xie --- drivers/scsi/megaraid/megaraid_sas_base.c | 13 ------------- drivers/scsi/megaraid/megaraid_sas_fusion.h | 9 +++++++++ 2 files changed, 9 insertions(+), 13 deletions(-) -- 2.7.4 -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c index 2d62d71..b73b6f3 100644 --- a/drivers/scsi/megaraid/megaraid_sas_base.c +++ b/drivers/scsi/megaraid/megaraid_sas_base.c @@ -189,25 +189,12 @@ u32 megasas_build_and_issue_cmd(struct megasas_instance *instance, struct scsi_cmnd *scmd); static void megasas_complete_cmd_dpc(unsigned long instance_addr); -void -megasas_release_fusion(struct megasas_instance *instance); -int -megasas_ioc_init_fusion(struct megasas_instance *instance); -void -megasas_free_cmds_fusion(struct megasas_instance *instance); -u8 -megasas_get_map_info(struct megasas_instance *instance); -int -megasas_sync_map_info(struct megasas_instance *instance); int wait_and_poll(struct megasas_instance *instance, struct megasas_cmd *cmd, int seconds); -void megasas_reset_reply_desc(struct megasas_instance *instance); void megasas_fusion_ocr_wq(struct work_struct *work); static int megasas_get_ld_vf_affiliation(struct megasas_instance *instance, int initial); -int megasas_check_mpio_paths(struct megasas_instance *instance, - struct scsi_cmnd *scmd); int megasas_issue_dcmd(struct megasas_instance *instance, struct megasas_cmd *cmd) diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.h b/drivers/scsi/megaraid/megaraid_sas_fusion.h index 80eaee2..3fe730a 100644 --- a/drivers/scsi/megaraid/megaraid_sas_fusion.h +++ b/drivers/scsi/megaraid/megaraid_sas_fusion.h @@ -991,5 +991,14 @@ union desc_value { } u; }; +void megasas_free_cmds_fusion(struct megasas_instance *instance); +int megasas_ioc_init_fusion(struct megasas_instance *instance); +u8 megasas_get_map_info(struct megasas_instance *instance); +int megasas_sync_map_info(struct megasas_instance *instance); +void megasas_release_fusion(struct megasas_instance *instance); +void megasas_reset_reply_desc(struct megasas_instance *instance); +int megasas_check_mpio_paths(struct megasas_instance *instance, + struct scsi_cmnd *scmd); +void megasas_fusion_ocr_wq(struct work_struct *work); #endif /* _MEGARAID_SAS_FUSION_H_ */