| Message ID | 1474221526-21195-1-git-send-email-yamada.masahiro@socionext.com |
|---|---|
| State | Superseded |
| Headers | show |
Hi Eric Miao, Haojian Zhuang, Could you pick up this patch, please? 2016-09-19 2:58 GMT+09:00 Masahiro Yamada <yamada.masahiro@socionext.com>: > In many of clk_disable() implementations, it is a no-op for a NULL > pointer input, but this is one of the exceptions. > > Making it treewide consistent will allow clock consumers to call > clk_disable() without NULL pointer check. > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > --- > > Changes in v4: > - Split into per-arch patches > > Changes in v3: > - Return only when clk is NULL. Do not take care of error pointer. > > Changes in v2: > - Rebase on Linux 4.6-rc1 > > arch/arm/mach-mmp/clock.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/arm/mach-mmp/clock.c b/arch/arm/mach-mmp/clock.c > index ac6633d..28fe64c 100644 > --- a/arch/arm/mach-mmp/clock.c > +++ b/arch/arm/mach-mmp/clock.c > @@ -67,6 +67,9 @@ void clk_disable(struct clk *clk) > { > unsigned long flags; > > + if (!clk) > + return; > + > WARN_ON(clk->enabled == 0); > > spin_lock_irqsave(&clocks_lock, flags); > -- > 1.9.1 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- Best Regards Masahiro Yamada
diff --git a/arch/arm/mach-mmp/clock.c b/arch/arm/mach-mmp/clock.c index ac6633d..28fe64c 100644 --- a/arch/arm/mach-mmp/clock.c +++ b/arch/arm/mach-mmp/clock.c @@ -67,6 +67,9 @@ void clk_disable(struct clk *clk) { unsigned long flags; + if (!clk) + return; + WARN_ON(clk->enabled == 0); spin_lock_irqsave(&clocks_lock, flags);
In many of clk_disable() implementations, it is a no-op for a NULL pointer input, but this is one of the exceptions. Making it treewide consistent will allow clock consumers to call clk_disable() without NULL pointer check. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> --- Changes in v4: - Split into per-arch patches Changes in v3: - Return only when clk is NULL. Do not take care of error pointer. Changes in v2: - Rebase on Linux 4.6-rc1 arch/arm/mach-mmp/clock.c | 3 +++ 1 file changed, 3 insertions(+) -- 1.9.1