| Message ID | 20240125163408.1595135-4-peter.maydell@linaro.org |
|---|---|
| State | Accepted |
| Headers | show |
| Series | Clean up includes | expand |
On 25/1/24 17:34, Peter Maydell wrote: > This commit was created with scripts/clean-includes: > ./scripts/clean-includes --git disas/riscv disas/riscv*[ch] > > All .c should include qemu/osdep.h first. The script performs three > related cleanups: > > * Ensure .c files include qemu/osdep.h first. > * Including it in a .h is redundant, since the .c already includes > it. Drop such inclusions. > * Likewise, including headers qemu/osdep.h includes is redundant. > Drop these, too. > > Signed-off-by: Peter Maydell <peter.maydell@linaro.org> > --- > disas/riscv.h | 1 - > disas/riscv-xthead.c | 1 + > disas/riscv-xventana.c | 1 + > 3 files changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
On Thu, Jan 25, 2024 at 04:34:01PM +0000, Peter Maydell wrote: > Date: Thu, 25 Jan 2024 16:34:01 +0000 > From: Peter Maydell <peter.maydell@linaro.org> > Subject: [PATCH 03/10] disas/riscv: Clean up includes > X-Mailer: git-send-email 2.34.1 > > This commit was created with scripts/clean-includes: > ./scripts/clean-includes --git disas/riscv disas/riscv*[ch] > > All .c should include qemu/osdep.h first. The script performs three > related cleanups: > > * Ensure .c files include qemu/osdep.h first. > * Including it in a .h is redundant, since the .c already includes > it. Drop such inclusions. > * Likewise, including headers qemu/osdep.h includes is redundant. > Drop these, too. > > Signed-off-by: Peter Maydell <peter.maydell@linaro.org> > --- > disas/riscv.h | 1 - > disas/riscv-xthead.c | 1 + > disas/riscv-xventana.c | 1 + > 3 files changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Zhao Liu <zhao1.liu@intel.com> > > diff --git a/disas/riscv.h b/disas/riscv.h > index 19e5ed2ce63..16a08e4895c 100644 > --- a/disas/riscv.h > +++ b/disas/riscv.h > @@ -7,7 +7,6 @@ > #ifndef DISAS_RISCV_H > #define DISAS_RISCV_H > > -#include "qemu/osdep.h" > #include "target/riscv/cpu_cfg.h" > > /* types */ > diff --git a/disas/riscv-xthead.c b/disas/riscv-xthead.c > index 99da679d16c..fcca326d1c3 100644 > --- a/disas/riscv-xthead.c > +++ b/disas/riscv-xthead.c > @@ -4,6 +4,7 @@ > * SPDX-License-Identifier: GPL-2.0-or-later > */ > > +#include "qemu/osdep.h" > #include "disas/riscv.h" > #include "disas/riscv-xthead.h" > > diff --git a/disas/riscv-xventana.c b/disas/riscv-xventana.c > index a0224d1fb31..cd694f15f32 100644 > --- a/disas/riscv-xventana.c > +++ b/disas/riscv-xventana.c > @@ -4,6 +4,7 @@ > * SPDX-License-Identifier: GPL-2.0-or-later > */ > > +#include "qemu/osdep.h" > #include "disas/riscv.h" > #include "disas/riscv-xventana.h" > > -- > 2.34.1 > >
On 1/26/24 02:34, Peter Maydell wrote: > This commit was created with scripts/clean-includes: > ./scripts/clean-includes --git disas/riscv disas/riscv*[ch] > > All .c should include qemu/osdep.h first. The script performs three > related cleanups: > > * Ensure .c files include qemu/osdep.h first. > * Including it in a .h is redundant, since the .c already includes > it. Drop such inclusions. > * Likewise, including headers qemu/osdep.h includes is redundant. > Drop these, too. > > Signed-off-by: Peter Maydell<peter.maydell@linaro.org> > --- > disas/riscv.h | 1 - > disas/riscv-xthead.c | 1 + > disas/riscv-xventana.c | 1 + > 3 files changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
On Fri, Jan 26, 2024 at 4:04 AM Peter Maydell <peter.maydell@linaro.org> wrote: > > This commit was created with scripts/clean-includes: > ./scripts/clean-includes --git disas/riscv disas/riscv*[ch] > > All .c should include qemu/osdep.h first. The script performs three > related cleanups: > > * Ensure .c files include qemu/osdep.h first. > * Including it in a .h is redundant, since the .c already includes > it. Drop such inclusions. > * Likewise, including headers qemu/osdep.h includes is redundant. > Drop these, too. > > Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Reviewed-by: Alistair Francis <alistair.francis@wdc.com> Alistair > --- > disas/riscv.h | 1 - > disas/riscv-xthead.c | 1 + > disas/riscv-xventana.c | 1 + > 3 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/disas/riscv.h b/disas/riscv.h > index 19e5ed2ce63..16a08e4895c 100644 > --- a/disas/riscv.h > +++ b/disas/riscv.h > @@ -7,7 +7,6 @@ > #ifndef DISAS_RISCV_H > #define DISAS_RISCV_H > > -#include "qemu/osdep.h" > #include "target/riscv/cpu_cfg.h" > > /* types */ > diff --git a/disas/riscv-xthead.c b/disas/riscv-xthead.c > index 99da679d16c..fcca326d1c3 100644 > --- a/disas/riscv-xthead.c > +++ b/disas/riscv-xthead.c > @@ -4,6 +4,7 @@ > * SPDX-License-Identifier: GPL-2.0-or-later > */ > > +#include "qemu/osdep.h" > #include "disas/riscv.h" > #include "disas/riscv-xthead.h" > > diff --git a/disas/riscv-xventana.c b/disas/riscv-xventana.c > index a0224d1fb31..cd694f15f32 100644 > --- a/disas/riscv-xventana.c > +++ b/disas/riscv-xventana.c > @@ -4,6 +4,7 @@ > * SPDX-License-Identifier: GPL-2.0-or-later > */ > > +#include "qemu/osdep.h" > #include "disas/riscv.h" > #include "disas/riscv-xventana.h" > > -- > 2.34.1 > >
diff --git a/disas/riscv.h b/disas/riscv.h index 19e5ed2ce63..16a08e4895c 100644 --- a/disas/riscv.h +++ b/disas/riscv.h @@ -7,7 +7,6 @@ #ifndef DISAS_RISCV_H #define DISAS_RISCV_H -#include "qemu/osdep.h" #include "target/riscv/cpu_cfg.h" /* types */ diff --git a/disas/riscv-xthead.c b/disas/riscv-xthead.c index 99da679d16c..fcca326d1c3 100644 --- a/disas/riscv-xthead.c +++ b/disas/riscv-xthead.c @@ -4,6 +4,7 @@ * SPDX-License-Identifier: GPL-2.0-or-later */ +#include "qemu/osdep.h" #include "disas/riscv.h" #include "disas/riscv-xthead.h" diff --git a/disas/riscv-xventana.c b/disas/riscv-xventana.c index a0224d1fb31..cd694f15f32 100644 --- a/disas/riscv-xventana.c +++ b/disas/riscv-xventana.c @@ -4,6 +4,7 @@ * SPDX-License-Identifier: GPL-2.0-or-later */ +#include "qemu/osdep.h" #include "disas/riscv.h" #include "disas/riscv-xventana.h"
This commit was created with scripts/clean-includes: ./scripts/clean-includes --git disas/riscv disas/riscv*[ch] All .c should include qemu/osdep.h first. The script performs three related cleanups: * Ensure .c files include qemu/osdep.h first. * Including it in a .h is redundant, since the .c already includes it. Drop such inclusions. * Likewise, including headers qemu/osdep.h includes is redundant. Drop these, too. Signed-off-by: Peter Maydell <peter.maydell@linaro.org> --- disas/riscv.h | 1 - disas/riscv-xthead.c | 1 + disas/riscv-xventana.c | 1 + 3 files changed, 2 insertions(+), 1 deletion(-)