| Message ID | 20240129204717.9091-1-semen.protsenko@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | MAINTAINERS: Add entry for Samsung Exynos850 SoC | expand |
On 30/01/2024 08:29, Krzysztof Kozlowski wrote: > On 29/01/2024 21:47, Sam Protsenko wrote: >> Add maintainers entry for the Samsung Exynos850 SoC based platforms. >> >> Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org> >> --- >> MAINTAINERS | 10 ++++++++++ >> 1 file changed, 10 insertions(+) >> >> diff --git a/MAINTAINERS b/MAINTAINERS >> index 939f6dd0ef6a..77c10cc669f8 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -19281,6 +19281,16 @@ B: mailto:linux-samsung-soc@vger.kernel.org >> F: Documentation/devicetree/bindings/sound/samsung* >> F: sound/soc/samsung/ >> >> +SAMSUNG EXYNOS850 SoC SUPPORT >> +M: Sam Protsenko <semen.protsenko@linaro.org> >> +L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers) >> +L: linux-samsung-soc@vger.kernel.org > > Sorry, but I am still against individual SoC entries in maintainers, > like I replied multiple times and pointed to the updated > get_maintainers.pl script to fetch emails from boards. I retract my earlier statement. Some background: I was really hoping that scripts/get_maintainers.pl patch, which adds fetching emails from files (e.g. DTS), will be picked up, but it has been few years, few resends and there is no conclusion. I don't think it will be ever merged, thus this email. Since C files do not have in-file "maintainer" entry and particular drivers have MAINTAINERS-file entries, then why DTS should be different? I'll take the patch after merge window. +Cc few other folks, I understand that with lei/lore filters one can easily track patches sent for particular boards or SoCs, but being listed in MAINTAINERS have a bit bigger meaning. Therefore if any of you consider / want to add themself to MAINTAINERS for particular DTS, then go ahead. By DTS I mean: particular boards (e.g. Galaxy Tab 3 family) or particular SoC (e.g. Exynos850 like here). Best regards, Krzysztof
> -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Sent: Friday, July 26, 2024 8:47 PM > To: Sam Protsenko <semen.protsenko@linaro.org> > Cc: Alim Akhtar <alim.akhtar@samsung.com>; Peter Griffin > <peter.griffin@linaro.org>; linux-arm-kernel@lists.infradead.org; linux- > samsung-soc@vger.kernel.org; linux-kernel@vger.kernel.org; Chanwoo Choi > <cw00.choi@samsung.com>; Marek Szyprowski > <m.szyprowski@samsung.com>; Peter Griffin <peter.griffin@linaro.org>; > Jaewon Kim <jaewon02.kim@samsung.com>; Mateusz Majewski > <m.majewski2@samsung.com>; Henrik Grimler <henrik@grimler.se>; David > Virag <virag.david003@gmail.com>; Artur Weber <aweber.kernel@gmail.com>; > Raymond Hackley <raymondhackley@protonmail.com> > Subject: Re: [PATCH] MAINTAINERS: Add entry for Samsung Exynos850 SoC > > On 30/01/2024 08:29, Krzysztof Kozlowski wrote: > > On 29/01/2024 21:47, Sam Protsenko wrote: > >> Add maintainers entry for the Samsung Exynos850 SoC based platforms. > >> > >> Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org> > >> --- > >> MAINTAINERS | 10 ++++++++++ > >> 1 file changed, 10 insertions(+) > >> > >> diff --git a/MAINTAINERS b/MAINTAINERS index > >> 939f6dd0ef6a..77c10cc669f8 100644 > >> --- a/MAINTAINERS > >> +++ b/MAINTAINERS > >> @@ -19281,6 +19281,16 @@ B: mailto:linux-samsung- > soc@vger.kernel.org > >> F: Documentation/devicetree/bindings/sound/samsung* > >> F: sound/soc/samsung/ > >> > >> +SAMSUNG EXYNOS850 SoC SUPPORT > >> +M: Sam Protsenko <semen.protsenko@linaro.org> > >> +L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers) > >> +L: linux-samsung-soc@vger.kernel.org > > > > Sorry, but I am still against individual SoC entries in maintainers, > > like I replied multiple times and pointed to the updated > > get_maintainers.pl script to fetch emails from boards. > > I retract my earlier statement. > > Some background: I was really hoping that scripts/get_maintainers.pl patch, > which adds fetching emails from files (e.g. DTS), will be picked up, but it has > been few years, few resends and there is no conclusion. I don't think it will be > ever merged, thus this email. > > Since C files do not have in-file "maintainer" entry and particular drivers have > MAINTAINERS-file entries, then why DTS should be different? > Not sure what was the discussion in past, do you think this need some discussion in LPC? > I'll take the patch after merge window. > > +Cc few other folks, > > I understand that with lei/lore filters one can easily track patches sent for > particular boards or SoCs, but being listed in MAINTAINERS have a bit bigger > meaning. Therefore if any of you consider / want to add themself to > MAINTAINERS for particular DTS, then go ahead. By DTS I > mean: particular boards (e.g. Galaxy Tab 3 family) or particular SoC (e.g. > Exynos850 like here). > Actually it is being confusing. Completely agreed that "MAINTAINERS have a bit bigger". By adding each DTS/SoC/Board MAINTAINERS entry, are those members expected to send pull requests? If so, that leads to more confusion and overhead. > Best regards, > Krzysztof
On 26/07/2024 18:08, Alim Akhtar wrote: > > >> -----Original Message----- >> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> Sent: Friday, July 26, 2024 8:47 PM >> To: Sam Protsenko <semen.protsenko@linaro.org> >> Cc: Alim Akhtar <alim.akhtar@samsung.com>; Peter Griffin >> <peter.griffin@linaro.org>; linux-arm-kernel@lists.infradead.org; linux- >> samsung-soc@vger.kernel.org; linux-kernel@vger.kernel.org; Chanwoo Choi >> <cw00.choi@samsung.com>; Marek Szyprowski >> <m.szyprowski@samsung.com>; Peter Griffin <peter.griffin@linaro.org>; >> Jaewon Kim <jaewon02.kim@samsung.com>; Mateusz Majewski >> <m.majewski2@samsung.com>; Henrik Grimler <henrik@grimler.se>; David >> Virag <virag.david003@gmail.com>; Artur Weber <aweber.kernel@gmail.com>; >> Raymond Hackley <raymondhackley@protonmail.com> >> Subject: Re: [PATCH] MAINTAINERS: Add entry for Samsung Exynos850 SoC >> >> On 30/01/2024 08:29, Krzysztof Kozlowski wrote: >>> On 29/01/2024 21:47, Sam Protsenko wrote: >>>> Add maintainers entry for the Samsung Exynos850 SoC based platforms. >>>> >>>> Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org> >>>> --- >>>> MAINTAINERS | 10 ++++++++++ >>>> 1 file changed, 10 insertions(+) >>>> >>>> diff --git a/MAINTAINERS b/MAINTAINERS index >>>> 939f6dd0ef6a..77c10cc669f8 100644 >>>> --- a/MAINTAINERS >>>> +++ b/MAINTAINERS >>>> @@ -19281,6 +19281,16 @@ B: mailto:linux-samsung- >> soc@vger.kernel.org >>>> F: Documentation/devicetree/bindings/sound/samsung* >>>> F: sound/soc/samsung/ >>>> >>>> +SAMSUNG EXYNOS850 SoC SUPPORT >>>> +M: Sam Protsenko <semen.protsenko@linaro.org> >>>> +L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers) >>>> +L: linux-samsung-soc@vger.kernel.org >>> >>> Sorry, but I am still against individual SoC entries in maintainers, >>> like I replied multiple times and pointed to the updated >>> get_maintainers.pl script to fetch emails from boards. >> >> I retract my earlier statement. >> >> Some background: I was really hoping that scripts/get_maintainers.pl patch, >> which adds fetching emails from files (e.g. DTS), will be picked up, but it has >> been few years, few resends and there is no conclusion. I don't think it will be >> ever merged, thus this email. >> >> Since C files do not have in-file "maintainer" entry and particular drivers have >> MAINTAINERS-file entries, then why DTS should be different? >> > Not sure what was the discussion in past, do you think this need some discussion in LPC? > >> I'll take the patch after merge window. >> >> +Cc few other folks, >> >> I understand that with lei/lore filters one can easily track patches sent for >> particular boards or SoCs, but being listed in MAINTAINERS have a bit bigger >> meaning. Therefore if any of you consider / want to add themself to >> MAINTAINERS for particular DTS, then go ahead. By DTS I >> mean: particular boards (e.g. Galaxy Tab 3 family) or particular SoC (e.g. >> Exynos850 like here). >> > Actually it is being confusing. Completely agreed that "MAINTAINERS have a bit bigger". > By adding each DTS/SoC/Board MAINTAINERS entry, are those members expected to send pull requests? > If so, that leads to more confusion and overhead. No, just like maintainers of drivers do not send them. The way of handling patches won't change. Best regards, Krzysztof
On Fri, Jul 26, 2024 at 10:17 AM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 30/01/2024 08:29, Krzysztof Kozlowski wrote: > > On 29/01/2024 21:47, Sam Protsenko wrote: > >> Add maintainers entry for the Samsung Exynos850 SoC based platforms. > >> > >> Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org> > >> --- > >> MAINTAINERS | 10 ++++++++++ > >> 1 file changed, 10 insertions(+) > >> > >> diff --git a/MAINTAINERS b/MAINTAINERS > >> index 939f6dd0ef6a..77c10cc669f8 100644 > >> --- a/MAINTAINERS > >> +++ b/MAINTAINERS > >> @@ -19281,6 +19281,16 @@ B: mailto:linux-samsung-soc@vger.kernel.org > >> F: Documentation/devicetree/bindings/sound/samsung* > >> F: sound/soc/samsung/ > >> > >> +SAMSUNG EXYNOS850 SoC SUPPORT > >> +M: Sam Protsenko <semen.protsenko@linaro.org> > >> +L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers) > >> +L: linux-samsung-soc@vger.kernel.org > > > > Sorry, but I am still against individual SoC entries in maintainers, > > like I replied multiple times and pointed to the updated > > get_maintainers.pl script to fetch emails from boards. > > I retract my earlier statement. > > Some background: I was really hoping that scripts/get_maintainers.pl > patch, which adds fetching emails from files (e.g. DTS), will be picked > up, but it has been few years, few resends and there is no conclusion. I > don't think it will be ever merged, thus this email. > > Since C files do not have in-file "maintainer" entry and particular > drivers have MAINTAINERS-file entries, then why DTS should be different? > > I'll take the patch after merge window. > Thank you, Krzysztof! I'll happily look after this platform. Please let me know if you want me to rebase/resend this patch. > +Cc few other folks, > > I understand that with lei/lore filters one can easily track patches > sent for particular boards or SoCs, but being listed in MAINTAINERS have > a bit bigger meaning. Therefore if any of you consider / want to add > themself to MAINTAINERS for particular DTS, then go ahead. By DTS I > mean: particular boards (e.g. Galaxy Tab 3 family) or particular SoC > (e.g. Exynos850 like here). > > Best regards, > Krzysztof >
On Mon, 29 Jan 2024 14:47:17 -0600, Sam Protsenko wrote: > Add maintainers entry for the Samsung Exynos850 SoC based platforms. > > Applied, thanks! [1/1] MAINTAINERS: Add entry for Samsung Exynos850 SoC https://git.kernel.org/krzk/linux/c/265e472e12da17af754f584b6a2f11cedb94fe49 Best regards,
diff --git a/MAINTAINERS b/MAINTAINERS index 939f6dd0ef6a..77c10cc669f8 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -19281,6 +19281,16 @@ B: mailto:linux-samsung-soc@vger.kernel.org F: Documentation/devicetree/bindings/sound/samsung* F: sound/soc/samsung/ +SAMSUNG EXYNOS850 SoC SUPPORT +M: Sam Protsenko <semen.protsenko@linaro.org> +L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers) +L: linux-samsung-soc@vger.kernel.org +S: Maintained +F: Documentation/devicetree/bindings/clock/samsung,exynos850-clock.yaml +F: arch/arm64/boot/dts/exynos/exynos850* +F: drivers/clk/samsung/clk-exynos850.c +F: include/dt-bindings/clock/exynos850.h + SAMSUNG EXYNOS PSEUDO RANDOM NUMBER GENERATOR (RNG) DRIVER M: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> L: linux-crypto@vger.kernel.org
Add maintainers entry for the Samsung Exynos850 SoC based platforms. Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org> --- MAINTAINERS | 10 ++++++++++ 1 file changed, 10 insertions(+)