From patchwork Fri Sep 23 12:08:44 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 76840 Delivered-To: patch@linaro.org Received: by 10.140.106.72 with SMTP id d66csp532388qgf; Fri, 23 Sep 2016 05:08:55 -0700 (PDT) X-Received: by 10.37.39.65 with SMTP id n62mr5318263ybn.86.1474632535526; Fri, 23 Sep 2016 05:08:55 -0700 (PDT) Return-Path: Received: from lists.linaro.org (lists.linaro.org. [54.225.227.206]) by mx.google.com with ESMTP id j2si4913517qke.170.2016.09.23.05.08.52; Fri, 23 Sep 2016 05:08:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linaro-uefi-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) client-ip=54.225.227.206; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linaro-uefi-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) smtp.mailfrom=linaro-uefi-bounces@lists.linaro.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id E364B60EE0; Fri, 23 Sep 2016 12:08:51 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252 X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL autolearn=disabled version=3.4.0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id D6F2760E20; Fri, 23 Sep 2016 12:08:48 +0000 (UTC) X-Original-To: linaro-uefi@lists.linaro.org Delivered-To: linaro-uefi@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id 85A3B60E2F; Fri, 23 Sep 2016 12:08:46 +0000 (UTC) Received: from mail-it0-f53.google.com (mail-it0-f53.google.com [209.85.214.53]) by lists.linaro.org (Postfix) with ESMTPS id 7DC3960DAC for ; Fri, 23 Sep 2016 12:08:45 +0000 (UTC) Received: by mail-it0-f53.google.com with SMTP id o3so12693296ita.1 for ; Fri, 23 Sep 2016 05:08:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=LcKn3LpyoyzUl64Jy5lq8fxIKsOgMXz4FO9bHzSNKGQ=; b=B5mvBThNy4O2nK9RlWLjGDFS+FayEDazHYI6WZHT+j73GNgHnkYHSBjvLvYUoKiuqC Q5pMHOhCpVnmlwxo7gshozBGpwXqrO0ATANWr9yqMQvedR/UA7BDfsNcQBSwiVEg1awy xs7zSZKx4iACu+KpzbE+dicIZaeEHd8zFMnWwkmyCVDHZY8R6Kg4Jc+bmMSAh0XsW5+3 mtoVU950bOl9rhgGER9r/XdV3QEAwbHJygw7p8Qy+XYscS8f8odN3TRpAa5Q3CJSEdmq GHhryD+LhzoVcOooJkQsQSMhUaGl06FbjshSP+O9fzD1Jco4B7rL+63mMPmW2DykPf/n y+kg== X-Gm-Message-State: AA6/9RmC6jCKq7Kxw2X+F8i18tzMZNEmsbALAZXYJccb2iQgJjGwZtBMHgqnfp6KI9Lbv2H1aKb3WDPiuLFQe5v7qiE= X-Received: by 10.36.209.196 with SMTP id w187mr2816053itg.47.1474632525048; Fri, 23 Sep 2016 05:08:45 -0700 (PDT) MIME-Version: 1.0 Received: by 10.36.204.195 with HTTP; Fri, 23 Sep 2016 05:08:44 -0700 (PDT) In-Reply-To: References: <1474588149-42902-1-git-send-email-daniil.egranov@arm.com> <1474588149-42902-3-git-send-email-daniil.egranov@arm.com> From: Ard Biesheuvel Date: Fri, 23 Sep 2016 13:08:44 +0100 Message-ID: To: Daniil Egranov Cc: Linaro UEFI Mailman List Subject: Re: [Linaro-uefi] [PATCH] OpenPlatformPkg/Platforms/ARM/Juno: Add NullDmaLib for ArmJunoPkg/Drivers/PciHostBridgeDxe X-BeenThere: linaro-uefi@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linaro-uefi-bounces@lists.linaro.org Sender: "Linaro-uefi" On 23 September 2016 at 09:02, Ard Biesheuvel wrote: > On 23 September 2016 at 00:49, Daniil Egranov wrote: >> Added NullDmaLib needed for ArmJunoPkg/Drivers/PciHostBridgeDxe with >> the fix for PCI DMA issue on Juno. >> >> Contributed-under: TianoCore Contribution Agreement 1.0 >> Signed-off-by: Daniil Egranov >> --- >> Platforms/ARM/Juno/ArmJuno.dsc | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/Platforms/ARM/Juno/ArmJuno.dsc b/Platforms/ARM/Juno/ArmJuno.dsc >> index 751225a..4456ff6 100644 >> --- a/Platforms/ARM/Juno/ArmJuno.dsc >> +++ b/Platforms/ARM/Juno/ArmJuno.dsc >> @@ -52,6 +52,8 @@ >> # USB Requirements >> UefiUsbLib|MdePkg/Library/UefiUsbLib/UefiUsbLib.inf >> >> + NullDmaLib|EmbeddedPkg/Library/NullDmaLib/NullDmaLib.inf >> + > > Is the PCI host bridge driver the only user of DmaLib on Juno? > If not, are all other PCI bus masters coherent as well? Looking at ArmJunoDxe, it seems that the PCI emulation for USB also uses this library. Are those DMA coherent on Juno? If not, we should add this DmaLib resolution for the PCI root complex driver as Also, the reference to UefiCpuPkg/CpuIo2Dxe/CpuIo2Dxe.inf does not make sense, given that it ASSERT()s on all I/O range accesses. diff --git a/Platforms/ARM/Juno/ArmJuno.dsc b/Platforms/ARM/Juno/ArmJuno.dsc index 751225ab112d..3913bd7caeae 100644 --- a/Platforms/ARM/Juno/ArmJuno.dsc +++ b/Platforms/ARM/Juno/ArmJuno.dsc @@ -277,7 +277,10 @@ # PCI Support # MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf - ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/PciHostBridgeDxe.inf + ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/PciHostBridgeDxe.inf { + + DmaLib|EmbeddedPkg/Library/NullDmaLib/NullDmaLib.inf + } # # SATA Controller