diff mbox

[1/2] regulator: dbx500: remove unused functions in dbx500-prcmu.c

Message ID 1474634842-2140-1-git-send-email-baoyou.xie@linaro.org
State Accepted
Commit 5258beedc30a72b0c21521aa531ed26ad45cb3f7
Headers show

Commit Message

Baoyou Xie Sept. 23, 2016, 12:47 p.m. UTC
We get 2 warnings when building kernel with W=1:
drivers/regulator/dbx500-prcmu.c:78:6: warning: no previous prototype for 'ux500_regulator_suspend_debug' [-Wmissing-prototypes]
drivers/regulator/dbx500-prcmu.c:87:6: warning: no previous prototype for 'ux500_regulator_resume_debug' [-Wmissing-prototypes]

In fact, these functions are unused in
dbx500-prcmu.c, but should be removed.

So this patch removes the unused functions.

Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>

---
 drivers/regulator/dbx500-prcmu.c | 18 ------------------
 1 file changed, 18 deletions(-)

-- 
2.7.4

Comments

Arnd Bergmann Sept. 23, 2016, 1:43 p.m. UTC | #1
On Friday, September 23, 2016 8:47:22 PM CEST Baoyou Xie wrote:
> We get 2 warnings when building kernel with W=1:

> drivers/regulator/dbx500-prcmu.c:78:6: warning: no previous prototype for 'ux500_regulator_suspend_debug' [-Wmissing-prototypes]

> drivers/regulator/dbx500-prcmu.c:87:6: warning: no previous prototype for 'ux500_regulator_resume_debug' [-Wmissing-prototypes]

> 

> In fact, these functions are unused in

> dbx500-prcmu.c, but should be removed.

> 

> So this patch removes the unused functions.

> 

> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>

> 


Good catch,

Acked-by: Arnd Bergmann <arnd@arndb.de>
diff mbox

Patch

diff --git a/drivers/regulator/dbx500-prcmu.c b/drivers/regulator/dbx500-prcmu.c
index 3963dfa..8976141 100644
--- a/drivers/regulator/dbx500-prcmu.c
+++ b/drivers/regulator/dbx500-prcmu.c
@@ -75,24 +75,6 @@  static struct ux500_regulator_debug {
 	u8 *state_after_suspend;
 } rdebug;
 
-void ux500_regulator_suspend_debug(void)
-{
-	int i;
-
-	for (i = 0; i < rdebug.num_regulators; i++)
-		rdebug.state_before_suspend[i] =
-			rdebug.regulator_array[i].is_enabled;
-}
-
-void ux500_regulator_resume_debug(void)
-{
-	int i;
-
-	for (i = 0; i < rdebug.num_regulators; i++)
-		rdebug.state_after_suspend[i] =
-			rdebug.regulator_array[i].is_enabled;
-}
-
 static int ux500_regulator_power_state_cnt_print(struct seq_file *s, void *p)
 {
 	/* print power state count */