diff mbox series

[next] input: ti_am335x_tsc: remove redundant assignment to variable config

Message ID 20240205215940.1851349-1-colin.i.king@gmail.com
State Accepted
Commit 0f82d108028a9dfea20e1c3c0ada1e64403002af
Headers show
Series [next] input: ti_am335x_tsc: remove redundant assignment to variable config | expand

Commit Message

Colin Ian King Feb. 5, 2024, 9:59 p.m. UTC
The variable config is being initialized with a value that is never
read, it is being re-assigned in the next statement. The initialization
is redundant and can be removed.

Cleans up clang scan build warning:
drivers/input/touchscreen/ti_am335x_tsc.c:160:2: warning: Value stored
to 'config' is never read [deadcode.DeadStores]

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
 drivers/input/touchscreen/ti_am335x_tsc.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Dmitry Torokhov Feb. 9, 2024, 6:53 p.m. UTC | #1
On Mon, Feb 05, 2024 at 09:59:40PM +0000, Colin Ian King wrote:
> The variable config is being initialized with a value that is never
> read, it is being re-assigned in the next statement. The initialization
> is redundant and can be removed.
> 
> Cleans up clang scan build warning:
> drivers/input/touchscreen/ti_am335x_tsc.c:160:2: warning: Value stored
> to 'config' is never read [deadcode.DeadStores]
> 
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>

Applied, thank you.
diff mbox series

Patch

diff --git a/drivers/input/touchscreen/ti_am335x_tsc.c b/drivers/input/touchscreen/ti_am335x_tsc.c
index 34324f8512ac..294b7ceded27 100644
--- a/drivers/input/touchscreen/ti_am335x_tsc.c
+++ b/drivers/input/touchscreen/ti_am335x_tsc.c
@@ -157,7 +157,6 @@  static void titsc_step_config(struct titsc *ts_dev)
 			     n++ == 0 ? STEPCONFIG_OPENDLY : 0);
 	}
 
-	config = 0;
 	config = STEPCONFIG_MODE_HWSYNC |
 			STEPCONFIG_AVG_16 | ts_dev->bit_yn |
 			STEPCONFIG_INM_ADCREFM;