From patchwork Fri Sep 30 09:45:02 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baoyou Xie X-Patchwork-Id: 77167 Delivered-To: patch@linaro.org Received: by 10.140.106.72 with SMTP id d66csp183713qgf; Fri, 30 Sep 2016 02:45:32 -0700 (PDT) X-Received: by 10.98.73.202 with SMTP id r71mr10156452pfi.36.1475228732808; Fri, 30 Sep 2016 02:45:32 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 90si3136773pfo.280.2016.09.30.02.45.32 for ; Fri, 30 Sep 2016 02:45:32 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-scsi-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-scsi-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=fail (p=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933002AbcI3Jpa (ORCPT ); Fri, 30 Sep 2016 05:45:30 -0400 Received: from mail-pa0-f54.google.com ([209.85.220.54]:35914 "EHLO mail-pa0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932413AbcI3Jp2 (ORCPT ); Fri, 30 Sep 2016 05:45:28 -0400 Received: by mail-pa0-f54.google.com with SMTP id qn7so37026111pac.3 for ; Fri, 30 Sep 2016 02:45:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=jGCHqBXbV3k4bMa8E70XM04Y2lL9jSAPYFsEVrHyhbE=; b=TD+1WFguAtOofha3UiopdAqmNa+BZeM43JZ4Joe3OKIlnfi6AsJu91UOSL1zBPeob8 XbG/RYZu4uSR8oyeapdoc6WADde2qL1IaRynBdCLSRcPvUEN18QRUoYfeFH9aEoPVAH5 yULVUh/UKIMJsOiBsikVTM9jmTkRDJXEF/YsY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=jGCHqBXbV3k4bMa8E70XM04Y2lL9jSAPYFsEVrHyhbE=; b=QfwyjF72Z7AmJ/iJXeBs7lH3GSYL99R+2SyBhLNjce651M0W4kAVUQdVJ1/0GTVZBZ GR2LBUfB9tyOuEJHFvhMtTzCg00xcqCLZF6TUbFN43u2nZA4F140UZwBEijdITtON9kj mTgDVL0vafrxJlla9gW7XHcxVAF5Sxu6FXLN2JonS+wPBVkIPFh4wxtSDXpuZEA8ifkl L46IK5AvPY0uuRO3smOHeAU9aZtkBx7aJ0jB542i0A+vvO3zgg2wXiA23XContzf3LNr E5D48XqzDX4kffJ6asdwSZ+gbRpBDarFa0PsFRRjEXo5cj0woQupH3C2WUztUS1CbpR5 U7rw== X-Gm-Message-State: AA6/9Rm9NCvjcTH6yDcQA1eOUdMQUqga+ul4pHiM6ZRWcLx/yohhenVoEdHqd+2t/nRE9N2l X-Received: by 10.66.228.226 with SMTP id sl2mr10036842pac.131.1475228727529; Fri, 30 Sep 2016 02:45:27 -0700 (PDT) Received: from localhost.localdomain ([104.237.91.182]) by smtp.gmail.com with ESMTPSA id j1sm26357054pfg.95.2016.09.30.02.45.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 30 Sep 2016 02:45:27 -0700 (PDT) From: Baoyou Xie To: kashyap.desai@avagotech.com, sumit.saxena@avagotech.com, uday.lingala@avagotech.com, jejb@linux.vnet.ibm.com, martin.petersen@oracle.com Cc: megaraidlinux.pdl@avagotech.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, arnd@arndb.de, baoyou.xie@linaro.org, xie.baoyou@zte.com.cn, han.fei@zte.com.cn, tang.qiang007@zte.com.cn Subject: [PATCH 2/2] megaraid_sas: clean function declarations in megaraid_sas_fusion.c up Date: Fri, 30 Sep 2016 17:45:02 +0800 Message-Id: <1475228702-21408-1-git-send-email-baoyou.xie@linaro.org> X-Mailer: git-send-email 2.7.4 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org We get 10 warnings when building kernel with W=1: drivers/scsi/megaraid/megaraid_sas_base.c:213:21: warning: no previous prototype for 'megasas_get_cmd' [-Wmissing-prototypes] drivers/scsi/megaraid/megaraid_sas_base.c:239:1: warning: no previous declaration for 'megasas_return_cmd' [-Wmissing-declarations] drivers/scsi/megaraid/megaraid_sas_base.c:985:1: warning: no previous prototype for 'megasas_issue_polled' [-Wmissing-prototypes] drivers/scsi/megaraid/megaraid_sas_base.c:1923:6: warning: no previous prototype for 'megaraid_sas_kill_hba' [-Wmissing-prototypes] drivers/scsi/megaraid/megaraid_sas_base.c:1952:1: warning: no previous prototype for 'megasas_check_and_restore_queue_depth' [-Wmissing-prototypes] drivers/scsi/megaraid/megaraid_sas_base.c:2030:6: warning: no previous prototype for 'megasas_start_timer' [-Wmissing-prototypes] drivers/scsi/megaraid/megaraid_sas_base.c:2353:5: warning: no previous prototype for 'megasas_sriov_start_heartbeat' [-Wmissing-prototypes] drivers/scsi/megaraid/megaraid_sas_base.c:2423:6: warning: no previous prototype for 'megasas_sriov_heartbeat_handler' [-Wmissing-prototypes] drivers/scsi/megaraid/megaraid_sas_base.c:3865:6: warning: no previous prototype for 'megasas_free_cmds' [-Wmissing-prototypes] drivers/scsi/megaraid/megaraid_sas_base.c:3902:5: warning: no previous prototype for 'megasas_alloc_cmds' [-Wmissing-prototypes] In fact, these functions are declared in drivers/scsi/megaraid/megaraid_sas_fusion.c, but should be declared in a header file. thus can be recognized in other file. So this patch moves the declarations into drivers/scsi/megaraid/megaraid_sas.h. Signed-off-by: Baoyou Xie --- drivers/scsi/megaraid/megaraid_sas.h | 19 +++++++++++++++++++ drivers/scsi/megaraid/megaraid_sas_fusion.c | 20 -------------------- 2 files changed, 19 insertions(+), 20 deletions(-) -- 2.7.4 -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/scsi/megaraid/megaraid_sas.h b/drivers/scsi/megaraid/megaraid_sas.h index ca86c88..d4664ff 100644 --- a/drivers/scsi/megaraid/megaraid_sas.h +++ b/drivers/scsi/megaraid/megaraid_sas.h @@ -2380,4 +2380,23 @@ void megasas_update_sdev_properties(struct scsi_device *sdev); int megasas_reset_fusion(struct Scsi_Host *shost, int reason); int megasas_task_abort_fusion(struct scsi_cmnd *scmd); int megasas_reset_target_fusion(struct scsi_cmnd *scmd); + +struct megasas_cmd *megasas_get_cmd(struct megasas_instance *instance); +void +megasas_return_cmd(struct megasas_instance *instance, struct megasas_cmd *cmd); +int +megasas_issue_polled(struct megasas_instance *instance, + struct megasas_cmd *cmd); +void megaraid_sas_kill_hba(struct megasas_instance *instance); +void +megasas_check_and_restore_queue_depth(struct megasas_instance *instance); +void megasas_start_timer(struct megasas_instance *instance, + struct timer_list *timer, + void *fn, unsigned long interval); +int +megasas_sriov_start_heartbeat(struct megasas_instance *instance, int initial); +void megasas_sriov_heartbeat_handler(unsigned long instance_addr); +void megasas_free_cmds(struct megasas_instance *instance); +int megasas_alloc_cmds(struct megasas_instance *instance); + #endif /*LSI_MEGARAID_SAS_H */ diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c b/drivers/scsi/megaraid/megaraid_sas_fusion.c index 730b525..e562482 100644 --- a/drivers/scsi/megaraid/megaraid_sas_fusion.c +++ b/drivers/scsi/megaraid/megaraid_sas_fusion.c @@ -59,37 +59,17 @@ #include "megaraid_sas.h" -extern void megasas_free_cmds(struct megasas_instance *instance); -extern struct megasas_cmd *megasas_get_cmd(struct megasas_instance - *instance); extern void megasas_complete_cmd(struct megasas_instance *instance, struct megasas_cmd *cmd, u8 alt_status); int wait_and_poll(struct megasas_instance *instance, struct megasas_cmd *cmd, int seconds); - -void -megasas_return_cmd(struct megasas_instance *instance, struct megasas_cmd *cmd); -int megasas_alloc_cmds(struct megasas_instance *instance); int megasas_clear_intr_fusion(struct megasas_register_set __iomem *regs); -int -megasas_issue_polled(struct megasas_instance *instance, - struct megasas_cmd *cmd); -void -megasas_check_and_restore_queue_depth(struct megasas_instance *instance); - int megasas_transition_to_ready(struct megasas_instance *instance, int ocr); -void megaraid_sas_kill_hba(struct megasas_instance *instance); extern u32 megasas_dbg_lvl; -void megasas_sriov_heartbeat_handler(unsigned long instance_addr); -int megasas_sriov_start_heartbeat(struct megasas_instance *instance, - int initial); -void megasas_start_timer(struct megasas_instance *instance, - struct timer_list *timer, - void *fn, unsigned long interval); extern struct megasas_mgmt_info megasas_mgmt_info; extern unsigned int resetwaittime; extern unsigned int dual_qdepth_disable;