diff mbox series

power: supply: axp288_fuel_gauge: Add STCK1A* Intel Compute Sticks to the deny-list

Message ID 20240212090014.13719-1-hdegoede@redhat.com
State Accepted
Commit a9b254892ce1a447b06c5019cbf0e9caeb48c138
Headers show
Series power: supply: axp288_fuel_gauge: Add STCK1A* Intel Compute Sticks to the deny-list | expand

Commit Message

Hans de Goede Feb. 12, 2024, 9 a.m. UTC
Besides the existing STK1A* Cherry Trail based Intel Compute Sticks
already on the deny-list, Intel also made Bay Trail based Compute Sticks
which have a product name of STCK1A* and wich also report a non
existing battery with a random battery charge.

Instead of adding 3 new deny-list entries for the 3 variants of the STCK1A*
sticks consolidate the 2 Cherry Trail STK1AW32SC and STK1A32SC variants
into a single entry with a partial match for STK1A* and add a single new
STCK1A* match for the Bay Trail variants.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 drivers/power/supply/axp288_fuel_gauge.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

Comments

Sebastian Reichel Feb. 16, 2024, 11:11 p.m. UTC | #1
On Mon, 12 Feb 2024 10:00:14 +0100, Hans de Goede wrote:
> Besides the existing STK1A* Cherry Trail based Intel Compute Sticks
> already on the deny-list, Intel also made Bay Trail based Compute Sticks
> which have a product name of STCK1A* and wich also report a non
> existing battery with a random battery charge.
> 
> Instead of adding 3 new deny-list entries for the 3 variants of the STCK1A*
> sticks consolidate the 2 Cherry Trail STK1AW32SC and STK1A32SC variants
> into a single entry with a partial match for STK1A* and add a single new
> STCK1A* match for the Bay Trail variants.
> 
> [...]

Applied, thanks!

[1/1] power: supply: axp288_fuel_gauge: Add STCK1A* Intel Compute Sticks to the deny-list
      commit: a9b254892ce1a447b06c5019cbf0e9caeb48c138

Best regards,
diff mbox series

Patch

diff --git a/drivers/power/supply/axp288_fuel_gauge.c b/drivers/power/supply/axp288_fuel_gauge.c
index 3be6f3b10ea4..967a26096485 100644
--- a/drivers/power/supply/axp288_fuel_gauge.c
+++ b/drivers/power/supply/axp288_fuel_gauge.c
@@ -550,18 +550,20 @@  static const struct dmi_system_id axp288_quirks[] = {
 		.driver_data = (void *)AXP288_QUIRK_NO_BATTERY,
 	},
 	{
-		/* Intel Cherry Trail Compute Stick, Windows version */
+		/* Intel Bay Trail Compute Stick */
 		.matches = {
 			DMI_MATCH(DMI_SYS_VENDOR, "Intel"),
-			DMI_MATCH(DMI_PRODUCT_NAME, "STK1AW32SC"),
+			/* Partial match for STCK1A32WFC STCK1A32FC, STCK1A8LFC variants */
+			DMI_MATCH(DMI_PRODUCT_NAME, "STCK1A"),
 		},
 		.driver_data = (void *)AXP288_QUIRK_NO_BATTERY,
 	},
 	{
-		/* Intel Cherry Trail Compute Stick, version without an OS */
+		/* Intel Cherry Trail Compute Stick */
 		.matches = {
 			DMI_MATCH(DMI_SYS_VENDOR, "Intel"),
-			DMI_MATCH(DMI_PRODUCT_NAME, "STK1A32SC"),
+			/* Partial match for STK1AW32SC and STK1A32SC variants */
+			DMI_MATCH(DMI_PRODUCT_NAME, "STK1A"),
 		},
 		.driver_data = (void *)AXP288_QUIRK_NO_BATTERY,
 	},