From patchwork Mon Oct 3 19:55:14 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Khem Raj X-Patchwork-Id: 77232 Delivered-To: patch@linaro.org Received: by 10.140.106.72 with SMTP id d66csp1847618qgf; Mon, 3 Oct 2016 12:55:18 -0700 (PDT) X-Received: by 10.98.102.148 with SMTP id s20mr41453762pfj.79.1475524518542; Mon, 03 Oct 2016 12:55:18 -0700 (PDT) Return-Path: Received: from mail.openembedded.org (mail.openembedded.org. [140.211.169.62]) by mx.google.com with ESMTP id 13si38326309pfk.66.2016.10.03.12.55.18; Mon, 03 Oct 2016 12:55:18 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of openembedded-core-bounces@lists.openembedded.org designates 140.211.169.62 as permitted sender) client-ip=140.211.169.62; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com; spf=pass (google.com: best guess record for domain of openembedded-core-bounces@lists.openembedded.org designates 140.211.169.62 as permitted sender) smtp.mailfrom=openembedded-core-bounces@lists.openembedded.org; dmarc=fail (p=NONE dis=NONE) header.from=gmail.com Received: from review.yoctoproject.org (localhost [127.0.0.1]) by mail.openembedded.org (Postfix) with ESMTP id D7FD8719D8; Mon, 3 Oct 2016 19:55:15 +0000 (UTC) X-Original-To: openembedded-core@lists.openembedded.org Delivered-To: openembedded-core@lists.openembedded.org Received: from mail-ua0-f194.google.com (mail-ua0-f194.google.com [209.85.217.194]) by mail.openembedded.org (Postfix) with ESMTP id CB45F719B2 for ; Mon, 3 Oct 2016 19:55:13 +0000 (UTC) Received: by mail-ua0-f194.google.com with SMTP id m26so1439529uaa.2 for ; Mon, 03 Oct 2016 12:55:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=gyGDUPGISfa0ma8yJ4kXIqpj7J8eGCC9t375rKVwEqw=; b=mwAwLXTfj+qZqQGNh3NPCkmR8BCaczK9+BTuhhPQauLKX2XVZud+y6+gRkvKW4388r UeoL3INkp620fwzsbO5spREFK+gso83KKVUqsLy175FpuyCMvMKxLESSld5MtIugNNNq lEytNGuzRrOQHdNNfZzG3Hhc9I/DoDfOJQw5xYMW0ysCduSV56iyKkH25G+ra67Gm2mT rbs3bbe/x71oLOX9g/zen6ndgvwKKJ24kPHlKrIBoHwk+JewguAh6pyXe5T4NKht4l8p 6L1ebL2m1nyeJcavrrG6vfJ5Dj78IpsO0NlnAlfwYhYelTCBodm6mguLU1qFlACsIN0w pl0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=gyGDUPGISfa0ma8yJ4kXIqpj7J8eGCC9t375rKVwEqw=; b=ZQHnJKW7hm4yQEo2cWSd/KyRk0rxdkApx6DlzXUHYjSGlnBrxK7g7jWTgB2j0zgrKO KsEkaK3PLOMgWB0CHK9zw4MPTNco+lKniraSS9Iw7VS+RazzVipuobt0GQkJWZ5Qxow3 VBUxtNOqwojqF4WT2vYw6rVCLkQDMmC65CzlxZAa07dE9M2Fj7mz8YPBGCtveLxFJZPQ E617bQDLr9urmWwa+fG2k5nWqOzgWTphlD2mcWEcecTLo3hgLnwBZicLpz8aaPMTbbp9 19dHPjpE5EtTwHnmuIWgY6l9AIjjAoMIMLA3YAC4fiN90DyCzFLI3DKrhmOPiEV1umbt YUGQ== X-Gm-Message-State: AA6/9RkkHpRJiexl/zSAAoK78caxqnoHNNolgA6nkIZ9q7zTnfTOka+hxgcJxBFjkDrXYg1CurCMhitBMc2HNg== X-Received: by 10.176.67.199 with SMTP id l65mr5719922ual.107.1475524515313; Mon, 03 Oct 2016 12:55:15 -0700 (PDT) MIME-Version: 1.0 Received: by 10.176.86.206 with HTTP; Mon, 3 Oct 2016 12:55:14 -0700 (PDT) Received: by 10.176.86.206 with HTTP; Mon, 3 Oct 2016 12:55:14 -0700 (PDT) In-Reply-To: References: <1475513685-18627-1-git-send-email-bruce.ashfield@windriver.com> From: Khem Raj Date: Mon, 3 Oct 2016 12:55:14 -0700 Message-ID: To: Bruce Ashfield Cc: openembedded-core@lists.openembedded.org Subject: Re: [OE-core] [PATCH] linux-libc-headers: if_tunnel: remove include of if/ip/in6.h X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: openembedded-core-bounces@lists.openembedded.org Errors-To: openembedded-core-bounces@lists.openembedded.org What Repercussion does this have wrt APIs headers for future. Provided this is a local patch. I think removing header includes like this can cause issues. On Oct 3, 2016 9:55 AM, "Bruce Ashfield" wrote: commit 1fe8e0f074c [include/uapi/linux/if_tunnel.h: include linux/if.h, linux/ip.h and linux/in6.h] breaks the builds of net-tools. We remove the new includes until such a time that userspace can adapt to the new kernel headers. Signed-off-by: Bruce Ashfield --- ...1-if_tunnel-remove-include-of-if-ip-in6.h.patch | 33 ++++++++++++++++++++++ .../linux-libc-headers/linux-libc-headers_4.8.bb | 1 + 2 files changed, 34 insertions(+) create mode 100644 meta/recipes-kernel/linux-libc-headers/linux-libc- headers/0001-if_tunnel-remove-include-of-if-ip-in6.h.patch diff --git a/meta/recipes-kernel/linux-libc-headers/linux-libc- headers/0001-if_tunnel-remove-include-of-if-ip-in6.h.patch b/meta/recipes-kernel/linux-libc-headers/linux-libc- headers/0001-if_tunnel-remove-include-of-if-ip-in6.h.patch new file mode 100644 index 000000000000..f2011880dccb --- /dev/null +++ b/meta/recipes-kernel/linux-libc-headers/linux-libc- headers/0001-if_tunnel-remove-include-of-if-ip-in6.h.patch @@ -0,0 +1,33 @@ +From 017ae5929312685c4c044765445bfd4d2a4abb5c Mon Sep 17 00:00:00 2001 +From: Bruce Ashfield +Date: Mon, 3 Oct 2016 12:27:57 -0400 +Subject: [PATCH] if_tunnel: remove include of if/ip/in6.h + +commit 1fe8e0f074c [include/uapi/linux/if_tunnel.h: include linux/if.h, linux/ip.h and linux/in6.h] +breaks the builds of net-tools. + +We remove the new includes until such a time that userspace can adapt to the +new kernel headers. + +Signed-off-by: Bruce Ashfield +--- + include/uapi/linux/if_tunnel.h | 3 --- + 1 file changed, 3 deletions(-) + +diff --git a/include/uapi/linux/if_tunnel.h b/include/uapi/linux/if_ tunnel.h +index 777b6cd..1046f55 100644 +--- a/include/uapi/linux/if_tunnel.h ++++ b/include/uapi/linux/if_tunnel.h +@@ -2,9 +2,6 @@ + #define _UAPI_IF_TUNNEL_H_ + + #include +-#include +-#include +-#include + #include + + +-- +2.7.4 + -- 2.5.0 -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core diff --git a/meta/recipes-kernel/linux-libc-headers/linux-libc- headers_4.8.bb b/meta/recipes-kernel/linux-libc-headers/linux-libc- headers_4.8.bb index 778f0b6e6443..ee2d8293450e 100644 --- a/meta/recipes-kernel/linux-libc-headers/linux-libc-headers_4.8.bb +++ b/meta/recipes-kernel/linux-libc-headers/linux-libc-headers_4.8.bb @@ -10,6 +10,7 @@ SRC_URI_append_libc-musl = "\ SRC_URI_append = "\ file://0001-ppp-fix-in-if.h-includes.patch \ + file://0001-if_tunnel-remove-include-of-if-ip-in6.h.patch \ " SRC_URI[md5sum] = "c1af0afbd3df35c1ccdc7a5118cd2d07"