| Message ID | 20240213-bus_cleanup-soundwire-v1-1-3878b00f6f57@marliere.net |
|---|---|
| State | Accepted |
| Commit | 81a7d0c4d059cb5c122110acbeec7bedfb91a741 |
| Headers | show |
| Series | soundwire: bus_type: make sdw_bus_type const | expand |
On Tue, 13 Feb 2024 11:36:56 -0300, Ricardo B. Marliere wrote: > Since commit d492cc2573a0 ("driver core: device.h: make struct > bus_type a const *"), the driver core can properly handle constant > struct bus_type, move the sdw_bus_type variable to be a constant > structure as well, placing it into read-only memory which can not be > modified at runtime. > > > [...] Applied, thanks! [1/1] soundwire: bus_type: make sdw_bus_type const commit: 81a7d0c4d059cb5c122110acbeec7bedfb91a741 Best regards,
diff --git a/drivers/soundwire/bus_type.c b/drivers/soundwire/bus_type.c index 9fa93bb923d7..fd65b2360fc1 100644 --- a/drivers/soundwire/bus_type.c +++ b/drivers/soundwire/bus_type.c @@ -72,7 +72,7 @@ int sdw_slave_uevent(const struct device *dev, struct kobj_uevent_env *env) return 0; } -struct bus_type sdw_bus_type = { +const struct bus_type sdw_bus_type = { .name = "soundwire", .match = sdw_bus_match, }; diff --git a/include/linux/soundwire/sdw_type.h b/include/linux/soundwire/sdw_type.h index d8c27f1e5559..b445f7200f06 100644 --- a/include/linux/soundwire/sdw_type.h +++ b/include/linux/soundwire/sdw_type.h @@ -4,7 +4,7 @@ #ifndef __SOUNDWIRE_TYPES_H #define __SOUNDWIRE_TYPES_H -extern struct bus_type sdw_bus_type; +extern const struct bus_type sdw_bus_type; extern struct device_type sdw_slave_type; extern struct device_type sdw_master_type;
Since commit d492cc2573a0 ("driver core: device.h: make struct bus_type a const *"), the driver core can properly handle constant struct bus_type, move the sdw_bus_type variable to be a constant structure as well, placing it into read-only memory which can not be modified at runtime. Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net> --- drivers/soundwire/bus_type.c | 2 +- include/linux/soundwire/sdw_type.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) --- base-commit: 9282cfa2eb080e3bbb95f488af35618b614cdf76 change-id: 20240213-bus_cleanup-soundwire-8b56c6862ef1 Best regards,