diff mbox series

[v4,15/39] pinctrl: qcom: apq8016: init pre-reloaction

Message ID 20240215-b4-qcom-common-target-v4-15-ed06355c634a@linaro.org
State Superseded
Headers show
Series Qualcomm generic board support | expand

Commit Message

Caleb Connolly Feb. 15, 2024, 8:52 p.m. UTC
On the DB410c we support running as a first stage bootloader. This
requires initialising the GPIOs which are muxed to UART before they can
be used. Add DM_FLAG_PRE_RELOC to the apq8016 pinctrl driver to ensure
that we do this early enough.

This is required to prevent the first few lines of UART log from being
dropped.

Reported-by: Sumit Garg <sumit.garg@linaro.org>
Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>
---
 drivers/pinctrl/qcom/pinctrl-apq8016.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Neil Armstrong Feb. 19, 2024, 9:50 a.m. UTC | #1
On 15/02/2024 21:52, Caleb Connolly wrote:
> On the DB410c we support running as a first stage bootloader. This
> requires initialising the GPIOs which are muxed to UART before they can
> be used. Add DM_FLAG_PRE_RELOC to the apq8016 pinctrl driver to ensure
> that we do this early enough.
> 
> This is required to prevent the first few lines of UART log from being
> dropped.
> 
> Reported-by: Sumit Garg <sumit.garg@linaro.org>
> Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>
> ---
>   drivers/pinctrl/qcom/pinctrl-apq8016.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/pinctrl/qcom/pinctrl-apq8016.c b/drivers/pinctrl/qcom/pinctrl-apq8016.c
> index 10796710ba7a..df5bd1c19f6e 100644
> --- a/drivers/pinctrl/qcom/pinctrl-apq8016.c
> +++ b/drivers/pinctrl/qcom/pinctrl-apq8016.c
> @@ -73,4 +73,5 @@ U_BOOT_DRIVER(pinctrl_apq8016) = {
>   	.of_match	= msm_pinctrl_ids,
>   	.ops		= &msm_pinctrl_ops,
>   	.bind		= msm_pinctrl_bind,
> +	.flags		= DM_FLAG_PRE_RELOC,
>   };
> 

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Sumit Garg Feb. 20, 2024, 6:31 a.m. UTC | #2
On Fri, 16 Feb 2024 at 02:22, Caleb Connolly <caleb.connolly@linaro.org> wrote:
>
> On the DB410c we support running as a first stage bootloader. This
> requires initialising the GPIOs which are muxed to UART before they can
> be used. Add DM_FLAG_PRE_RELOC to the apq8016 pinctrl driver to ensure
> that we do this early enough.
>
> This is required to prevent the first few lines of UART log from being
> dropped.
>
> Reported-by: Sumit Garg <sumit.garg@linaro.org>
> Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>
> ---
>  drivers/pinctrl/qcom/pinctrl-apq8016.c | 1 +
>  1 file changed, 1 insertion(+)
>

Reviewed-by: Sumit Garg <sumit.garg@linaro.org>

-Sumit

> diff --git a/drivers/pinctrl/qcom/pinctrl-apq8016.c b/drivers/pinctrl/qcom/pinctrl-apq8016.c
> index 10796710ba7a..df5bd1c19f6e 100644
> --- a/drivers/pinctrl/qcom/pinctrl-apq8016.c
> +++ b/drivers/pinctrl/qcom/pinctrl-apq8016.c
> @@ -73,4 +73,5 @@ U_BOOT_DRIVER(pinctrl_apq8016) = {
>         .of_match       = msm_pinctrl_ids,
>         .ops            = &msm_pinctrl_ops,
>         .bind           = msm_pinctrl_bind,
> +       .flags          = DM_FLAG_PRE_RELOC,
>  };
>
> --
> 2.43.1
>
diff mbox series

Patch

diff --git a/drivers/pinctrl/qcom/pinctrl-apq8016.c b/drivers/pinctrl/qcom/pinctrl-apq8016.c
index 10796710ba7a..df5bd1c19f6e 100644
--- a/drivers/pinctrl/qcom/pinctrl-apq8016.c
+++ b/drivers/pinctrl/qcom/pinctrl-apq8016.c
@@ -73,4 +73,5 @@  U_BOOT_DRIVER(pinctrl_apq8016) = {
 	.of_match	= msm_pinctrl_ids,
 	.ops		= &msm_pinctrl_ops,
 	.bind		= msm_pinctrl_bind,
+	.flags		= DM_FLAG_PRE_RELOC,
 };