[edk2] ArmPlatformPkg/PlatformPeiLib: allow patch PCDs for FV base address/size

Message ID 1475853298-28327-1-git-send-email-ard.biesheuvel@linaro.org
State New
Headers show

Commit Message

Ard Biesheuvel Oct. 7, 2016, 3:14 p.m.
Allow patchable or dynamic PCDs to be used for PcdFvBaseAddress and
PcdFvBaseSize, so that platforms whose UEFI image may be loaded anywhere
in memory can use PlatformPeiLib.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

---
 ArmPlatformPkg/PlatformPei/PlatformPeiLib.inf | 11 +----------
 1 file changed, 1 insertion(+), 10 deletions(-)

-- 
2.7.4

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Comments

Ard Biesheuvel Oct. 7, 2016, 3:15 p.m. | #1
On 7 October 2016 at 16:14, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
> Allow patchable or dynamic PCDs to be used for PcdFvBaseAddress and

> PcdFvBaseSize, so that platforms whose UEFI image may be loaded anywhere

> in memory can use PlatformPeiLib.

>


... and also, drop some references to PCDs that are in fact not used.

> Contributed-under: TianoCore Contribution Agreement 1.0

> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

> ---

>  ArmPlatformPkg/PlatformPei/PlatformPeiLib.inf | 11 +----------

>  1 file changed, 1 insertion(+), 10 deletions(-)

>

> diff --git a/ArmPlatformPkg/PlatformPei/PlatformPeiLib.inf b/ArmPlatformPkg/PlatformPei/PlatformPeiLib.inf

> index 314789d0a990..2363d9aa966e 100644

> --- a/ArmPlatformPkg/PlatformPei/PlatformPeiLib.inf

> +++ b/ArmPlatformPkg/PlatformPei/PlatformPeiLib.inf

> @@ -39,15 +39,6 @@ [Ppis]

>    gEfiPeiMasterBootModePpiGuid                  # PPI ALWAYS_PRODUCED

>    gEfiPeiBootInRecoveryModePpiGuid              # PPI SOMETIMES_PRODUCED

>

> -[FixedPcd]

> -  gArmTokenSpaceGuid.PcdFdBaseAddress

> -  gArmTokenSpaceGuid.PcdFdSize

> -

> +[Pcd]

>    gArmTokenSpaceGuid.PcdFvBaseAddress

>    gArmTokenSpaceGuid.PcdFvSize

> -

> -  gEmbeddedTokenSpaceGuid.PcdPrePiCpuMemorySize

> -  gEmbeddedTokenSpaceGuid.PcdPrePiCpuIoSize

> -

> -[depex]

> -  TRUE

> --

> 2.7.4

>

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Leif Lindholm Oct. 7, 2016, 3:51 p.m. | #2
On Fri, Oct 07, 2016 at 04:15:36PM +0100, Ard Biesheuvel wrote:
> On 7 October 2016 at 16:14, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:

> > Allow patchable or dynamic PCDs to be used for PcdFvBaseAddress and

> > PcdFvBaseSize, so that platforms whose UEFI image may be loaded anywhere

> > in memory can use PlatformPeiLib.

> >

> 

> ... and also, drop some references to PCDs that are in fact not used.

> 

> > Contributed-under: TianoCore Contribution Agreement 1.0

> > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

> > ---

> >  ArmPlatformPkg/PlatformPei/PlatformPeiLib.inf | 11 +----------

> >  1 file changed, 1 insertion(+), 10 deletions(-)

> >

> > diff --git a/ArmPlatformPkg/PlatformPei/PlatformPeiLib.inf b/ArmPlatformPkg/PlatformPei/PlatformPeiLib.inf

> > index 314789d0a990..2363d9aa966e 100644

> > --- a/ArmPlatformPkg/PlatformPei/PlatformPeiLib.inf

> > +++ b/ArmPlatformPkg/PlatformPei/PlatformPeiLib.inf

> > @@ -39,15 +39,6 @@ [Ppis]

> >    gEfiPeiMasterBootModePpiGuid                  # PPI ALWAYS_PRODUCED

> >    gEfiPeiBootInRecoveryModePpiGuid              # PPI SOMETIMES_PRODUCED

> >

> > -[FixedPcd]

> > -  gArmTokenSpaceGuid.PcdFdBaseAddress

> > -  gArmTokenSpaceGuid.PcdFdSize

> > -

> > +[Pcd]

> >    gArmTokenSpaceGuid.PcdFvBaseAddress

> >    gArmTokenSpaceGuid.PcdFvSize

> > -

> > -  gEmbeddedTokenSpaceGuid.PcdPrePiCpuMemorySize

> > -  gEmbeddedTokenSpaceGuid.PcdPrePiCpuIoSize

> > -

> > -[depex]

> > -  TRUE


So, especially the depex drop makes me prefer seeing the cleanup as a
separate patch.

Otherwise, looks good to me.

/
    Leif


> > --

> > 2.7.4

> >

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Patch

diff --git a/ArmPlatformPkg/PlatformPei/PlatformPeiLib.inf b/ArmPlatformPkg/PlatformPei/PlatformPeiLib.inf
index 314789d0a990..2363d9aa966e 100644
--- a/ArmPlatformPkg/PlatformPei/PlatformPeiLib.inf
+++ b/ArmPlatformPkg/PlatformPei/PlatformPeiLib.inf
@@ -39,15 +39,6 @@  [Ppis]
   gEfiPeiMasterBootModePpiGuid                  # PPI ALWAYS_PRODUCED
   gEfiPeiBootInRecoveryModePpiGuid              # PPI SOMETIMES_PRODUCED
 
-[FixedPcd]
-  gArmTokenSpaceGuid.PcdFdBaseAddress
-  gArmTokenSpaceGuid.PcdFdSize
-
+[Pcd]
   gArmTokenSpaceGuid.PcdFvBaseAddress
   gArmTokenSpaceGuid.PcdFvSize
-
-  gEmbeddedTokenSpaceGuid.PcdPrePiCpuMemorySize
-  gEmbeddedTokenSpaceGuid.PcdPrePiCpuIoSize
-
-[depex]
-  TRUE