diff mbox

checkpatch: don't try to get maintained status when --no-tree is given

Message ID 1476719709-16668-1-git-send-email-jerome.forissier@linaro.org
State Accepted
Commit f2c19c2f380fcfdc85eb750016d73f7cd3e77573
Headers show

Commit Message

Jerome Forissier Oct. 17, 2016, 3:55 p.m. UTC
Fixes the following warning:
Use of uninitialized value $root in concatenation (.) or string at /path/to/checkpatch.pl line 764.

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>

---
 scripts/checkpatch.pl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.7.4

Comments

Joe Perches Oct. 17, 2016, 4:56 p.m. UTC | #1
On Mon, 2016-10-17 at 17:55 +0200, Jerome Forissier wrote:
> Fixes the following warning:

> Use of uninitialized value $root in concatenation (.) or string at /path/to/checkpatch.pl line 764.


Thanks Jerome.

> Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>


Acked-by: Joe Perches <joe@perches.com>


> ---

>  scripts/checkpatch.pl | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

> 

> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl

> index a8368d1..aa694bc 100755

> --- a/scripts/checkpatch.pl

> +++ b/scripts/checkpatch.pl

> @@ -761,7 +761,7 @@ sub seed_camelcase_file {

>  sub is_maintained_obsolete {

>  	my ($filename) = @_;

>  

> -	return 0 if (!(-e "$root/scripts/get_maintainer.pl"));

> +	return 0 if (!$tree || !(-e "$root/scripts/get_maintainer.pl"));

>  

>  	my $status = `perl $root/scripts/get_maintainer.pl --status --nom --nol --nogit --nogit-fallback -f $filename 2>&1`;
diff mbox

Patch

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index a8368d1..aa694bc 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -761,7 +761,7 @@  sub seed_camelcase_file {
 sub is_maintained_obsolete {
 	my ($filename) = @_;
 
-	return 0 if (!(-e "$root/scripts/get_maintainer.pl"));
+	return 0 if (!$tree || !(-e "$root/scripts/get_maintainer.pl"));
 
 	my $status = `perl $root/scripts/get_maintainer.pl --status --nom --nol --nogit --nogit-fallback -f $filename 2>&1`;