diff mbox series

[29/43] drm/renesas/rz-du: Use fbdev-dma

Message ID 20240312154834.26178-30-tzimmermann@suse.de
State Superseded
Headers show
Series drm: Provide fbdev emulation per memory manager | expand

Commit Message

Thomas Zimmermann March 12, 2024, 3:45 p.m. UTC
Implement fbdev emulation with fbdev-dma. Fbdev-dma now supports
damage handling, which is required by rz-du. Avoids the overhead of
fbdev-generic's additional shadow buffering. No functional changes.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Biju Das <biju.das.jz@bp.renesas.com>
---
 drivers/gpu/drm/renesas/rz-du/rzg2l_du_drv.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Biju Das March 12, 2024, 7:14 p.m. UTC | #1
Hi Thomas,

> -----Original Message-----
> From: Thomas Zimmermann <tzimmermann@suse.de>
> Sent: Tuesday, March 12, 2024 3:45 PM
> To: daniel@ffwll.ch; airlied@gmail.com; deller@gmx.de; javierm@redhat.com
> Cc: linux-fbdev@vger.kernel.org; dri-devel@lists.freedesktop.org; Thomas Zimmermann
> <tzimmermann@suse.de>; Biju Das <biju.das.jz@bp.renesas.com>
> Subject: [PATCH 29/43] drm/renesas/rz-du: Use fbdev-dma
> 
> Implement fbdev emulation with fbdev-dma. Fbdev-dma now supports damage handling, which is required by
> rz-du. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes.
> 
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>


Tested-by: Biju Das <biju.das.jz@bp.renesas.com>

Cheers,
Biju

> Cc: Biju Das <biju.das.jz@bp.renesas.com>
> ---
>  drivers/gpu/drm/renesas/rz-du/rzg2l_du_drv.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/renesas/rz-du/rzg2l_du_drv.c b/drivers/gpu/drm/renesas/rz-
> du/rzg2l_du_drv.c
> index 470d34da1d6c4..e5eca8691a331 100644
> --- a/drivers/gpu/drm/renesas/rz-du/rzg2l_du_drv.c
> +++ b/drivers/gpu/drm/renesas/rz-du/rzg2l_du_drv.c
> @@ -14,7 +14,7 @@
> 
>  #include <drm/drm_atomic_helper.h>
>  #include <drm/drm_drv.h>
> -#include <drm/drm_fbdev_generic.h>
> +#include <drm/drm_fbdev_dma.h>
>  #include <drm/drm_gem_dma_helper.h>
>  #include <drm/drm_probe_helper.h>
> 
> @@ -149,7 +149,7 @@ static int rzg2l_du_probe(struct platform_device *pdev)
> 
>  	drm_info(&rcdu->ddev, "Device %s probed\n", dev_name(&pdev->dev));
> 
> -	drm_fbdev_generic_setup(&rcdu->ddev, 32);
> +	drm_fbdev_dma_setup(&rcdu->ddev, 32);
> 
>  	return 0;
> 
> --
> 2.44.0
Thomas Zimmermann March 13, 2024, 8:30 a.m. UTC | #2
Hi

Am 12.03.24 um 20:14 schrieb Biju Das:
> Hi Thomas,
>
>> -----Original Message-----
>> From: Thomas Zimmermann <tzimmermann@suse.de>
>> Sent: Tuesday, March 12, 2024 3:45 PM
>> To: daniel@ffwll.ch; airlied@gmail.com; deller@gmx.de; javierm@redhat.com
>> Cc: linux-fbdev@vger.kernel.org; dri-devel@lists.freedesktop.org; Thomas Zimmermann
>> <tzimmermann@suse.de>; Biju Das <biju.das.jz@bp.renesas.com>
>> Subject: [PATCH 29/43] drm/renesas/rz-du: Use fbdev-dma
>>
>> Implement fbdev emulation with fbdev-dma. Fbdev-dma now supports damage handling, which is required by
>> rz-du. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes.
>>
>> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
>
> Tested-by: Biju Das <biju.das.jz@bp.renesas.com>

Thanks a lot.

I just noticed that the drivers under renesas/ don't require damage 
handling, so the commit message needs a change.

Best regards
Thomas

>
> Cheers,
> Biju
>
>> Cc: Biju Das <biju.das.jz@bp.renesas.com>
>> ---
>>   drivers/gpu/drm/renesas/rz-du/rzg2l_du_drv.c | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/renesas/rz-du/rzg2l_du_drv.c b/drivers/gpu/drm/renesas/rz-
>> du/rzg2l_du_drv.c
>> index 470d34da1d6c4..e5eca8691a331 100644
>> --- a/drivers/gpu/drm/renesas/rz-du/rzg2l_du_drv.c
>> +++ b/drivers/gpu/drm/renesas/rz-du/rzg2l_du_drv.c
>> @@ -14,7 +14,7 @@
>>
>>   #include <drm/drm_atomic_helper.h>
>>   #include <drm/drm_drv.h>
>> -#include <drm/drm_fbdev_generic.h>
>> +#include <drm/drm_fbdev_dma.h>
>>   #include <drm/drm_gem_dma_helper.h>
>>   #include <drm/drm_probe_helper.h>
>>
>> @@ -149,7 +149,7 @@ static int rzg2l_du_probe(struct platform_device *pdev)
>>
>>   	drm_info(&rcdu->ddev, "Device %s probed\n", dev_name(&pdev->dev));
>>
>> -	drm_fbdev_generic_setup(&rcdu->ddev, 32);
>> +	drm_fbdev_dma_setup(&rcdu->ddev, 32);
>>
>>   	return 0;
>>
>> --
>> 2.44.0
diff mbox series

Patch

diff --git a/drivers/gpu/drm/renesas/rz-du/rzg2l_du_drv.c b/drivers/gpu/drm/renesas/rz-du/rzg2l_du_drv.c
index 470d34da1d6c4..e5eca8691a331 100644
--- a/drivers/gpu/drm/renesas/rz-du/rzg2l_du_drv.c
+++ b/drivers/gpu/drm/renesas/rz-du/rzg2l_du_drv.c
@@ -14,7 +14,7 @@ 
 
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_drv.h>
-#include <drm/drm_fbdev_generic.h>
+#include <drm/drm_fbdev_dma.h>
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_probe_helper.h>
 
@@ -149,7 +149,7 @@  static int rzg2l_du_probe(struct platform_device *pdev)
 
 	drm_info(&rcdu->ddev, "Device %s probed\n", dev_name(&pdev->dev));
 
-	drm_fbdev_generic_setup(&rcdu->ddev, 32);
+	drm_fbdev_dma_setup(&rcdu->ddev, 32);
 
 	return 0;