diff mbox

[Linaro-uefi,v2,04/24] Hisilicon/Hi1610/PCIe: Remove lane reversal code

Message ID 1476796207-94336-5-git-send-email-heyi.guo@linaro.org
State Accepted
Commit c58960c3cd1f9cf31dbf348b9e3ef1194cbd0316
Headers show

Commit Message

gary guo Oct. 18, 2016, 1:09 p.m. UTC 
Lane reversal is the default setting of chip and it is unnecessary for
software to do that.
We made a mistake to do it in software, and this patch is to remove
the duplication.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: hensonwang <wanghuiqiang@huawei.com>
Signed-off-by: Heyi Guo <heyi.guo@linaro.org>
---
 Chips/Hisilicon/Hi1610/Drivers/PcieInit1610/PcieInitLib.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Leif Lindholm Oct. 27, 2016, 12:05 p.m. UTC | #1 
On Tue, Oct 18, 2016 at 09:09:48PM +0800, Heyi Guo wrote:
> Lane reversal is the default setting of chip and it is unnecessary for
> software to do that.
> We made a mistake to do it in software, and this patch is to remove
> the duplication.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: hensonwang <wanghuiqiang@huawei.com>
> Signed-off-by: Heyi Guo <heyi.guo@linaro.org>

Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
Pushed as c58960c.

> ---
>  Chips/Hisilicon/Hi1610/Drivers/PcieInit1610/PcieInitLib.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/Chips/Hisilicon/Hi1610/Drivers/PcieInit1610/PcieInitLib.c b/Chips/Hisilicon/Hi1610/Drivers/PcieInit1610/PcieInitLib.c
> index 3a2bee0..730bdb0 100644
> --- a/Chips/Hisilicon/Hi1610/Drivers/PcieInit1610/PcieInitLib.c
> +++ b/Chips/Hisilicon/Hi1610/Drivers/PcieInit1610/PcieInitLib.c
> @@ -971,7 +971,6 @@ PciePortInit (
>       (VOID)PciePcsInit(soctype, HostBridgeNum, PortIndex);
>  
>       (VOID)PcieModeSet(soctype, HostBridgeNum, PortIndex,PcieCfg->PortInfo.PortType);
> -     (VOID)PcieLaneReversalSet(soctype, HostBridgeNum, PortIndex);
>       (VOID)PcieSpdSet(soctype, HostBridgeNum, PortIndex, 3);
>       (VOID)PciePortNumSet(soctype, HostBridgeNum, PortIndex, 0);
>       /* setup root complex */
> -- 
> 1.9.1
>
diff mbox

Patch

diff --git a/Chips/Hisilicon/Hi1610/Drivers/PcieInit1610/PcieInitLib.c b/Chips/Hisilicon/Hi1610/Drivers/PcieInit1610/PcieInitLib.c
index 3a2bee0..730bdb0 100644
--- a/Chips/Hisilicon/Hi1610/Drivers/PcieInit1610/PcieInitLib.c
+++ b/Chips/Hisilicon/Hi1610/Drivers/PcieInit1610/PcieInitLib.c
@@ -971,7 +971,6 @@  PciePortInit (
      (VOID)PciePcsInit(soctype, HostBridgeNum, PortIndex);
 
      (VOID)PcieModeSet(soctype, HostBridgeNum, PortIndex,PcieCfg->PortInfo.PortType);
-     (VOID)PcieLaneReversalSet(soctype, HostBridgeNum, PortIndex);
      (VOID)PcieSpdSet(soctype, HostBridgeNum, PortIndex, 3);
      (VOID)PciePortNumSet(soctype, HostBridgeNum, PortIndex, 0);
      /* setup root complex */