| Message ID | 20240313154857.12949-3-tzimmermann@suse.de |
|---|---|
| State | Superseded |
| Headers | show |
| Series | backlight: Remove struct backlight_properties.fb_blank | expand |
On Wed, 13 Mar 2024, Thomas Zimmermann wrote: > The callback set_power in struct omap_backlight_config is not > implemented anywhere. Remove it from the structure and driver. > > Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> > --- > drivers/video/backlight/omap1_bl.c | 3 --- > include/linux/platform_data/omap1_bl.h | 1 - > 2 files changed, 4 deletions(-) Just a quick one - I'm sure Daniel will be here soon to conduct a proper review. Could you attempt to use the subject line format expected by a given subsystem please? `git log --oneline -- <subsystem>` is your friend. Thanks.
On Wed, Mar 13, 2024 at 04:45:01PM +0100, Thomas Zimmermann wrote: > The callback set_power in struct omap_backlight_config is not > implemented anywhere. Remove it from the structure and driver. > > Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> Reviewed-by: Sam Ravnborg <sam@ravnborg.org> > --- > drivers/video/backlight/omap1_bl.c | 3 --- > include/linux/platform_data/omap1_bl.h | 1 - > 2 files changed, 4 deletions(-) > > diff --git a/drivers/video/backlight/omap1_bl.c b/drivers/video/backlight/omap1_bl.c > index 69a49384b3de4..84d148f385951 100644 > --- a/drivers/video/backlight/omap1_bl.c > +++ b/drivers/video/backlight/omap1_bl.c > @@ -39,9 +39,6 @@ static inline void omapbl_send_enable(int enable) > > static void omapbl_blank(struct omap_backlight *bl, int mode) > { > - if (bl->pdata->set_power) > - bl->pdata->set_power(bl->dev, mode); > - > switch (mode) { > case FB_BLANK_NORMAL: > case FB_BLANK_VSYNC_SUSPEND: > diff --git a/include/linux/platform_data/omap1_bl.h b/include/linux/platform_data/omap1_bl.h > index 5e8b17d77a5fe..3d0bab31a0a94 100644 > --- a/include/linux/platform_data/omap1_bl.h > +++ b/include/linux/platform_data/omap1_bl.h > @@ -6,7 +6,6 @@ > > struct omap_backlight_config { > int default_intensity; > - int (*set_power)(struct device *dev, int state); > }; > > #endif > -- > 2.44.0
On Wed, Mar 13, 2024 at 04:45:01PM +0100, Thomas Zimmermann wrote: > The callback set_power in struct omap_backlight_config is not > implemented anywhere. Remove it from the structure and driver. > > Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org> Daniel.
diff --git a/drivers/video/backlight/omap1_bl.c b/drivers/video/backlight/omap1_bl.c index 69a49384b3de4..84d148f385951 100644 --- a/drivers/video/backlight/omap1_bl.c +++ b/drivers/video/backlight/omap1_bl.c @@ -39,9 +39,6 @@ static inline void omapbl_send_enable(int enable) static void omapbl_blank(struct omap_backlight *bl, int mode) { - if (bl->pdata->set_power) - bl->pdata->set_power(bl->dev, mode); - switch (mode) { case FB_BLANK_NORMAL: case FB_BLANK_VSYNC_SUSPEND: diff --git a/include/linux/platform_data/omap1_bl.h b/include/linux/platform_data/omap1_bl.h index 5e8b17d77a5fe..3d0bab31a0a94 100644 --- a/include/linux/platform_data/omap1_bl.h +++ b/include/linux/platform_data/omap1_bl.h @@ -6,7 +6,6 @@ struct omap_backlight_config { int default_intensity; - int (*set_power)(struct device *dev, int state); }; #endif
The callback set_power in struct omap_backlight_config is not implemented anywhere. Remove it from the structure and driver. Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> --- drivers/video/backlight/omap1_bl.c | 3 --- include/linux/platform_data/omap1_bl.h | 1 - 2 files changed, 4 deletions(-)