[Linaro-uefi,v2,19/24] OemMiscLib: Add interface for SAS driver

Message ID 1476796207-94336-20-git-send-email-heyi.guo@linaro.org
State New
Headers show

Commit Message

gary guo Oct. 18, 2016, 1:10 p.m.
Add OemIsNeedDisableExpanderBuffer() interface for SAS driver.

Change-Id: I85262a7800cb0a22e6ddc072d566b9df4405a126
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Heyi Guo <guoheyi@huawei.com>
---
 Chips/Hisilicon/Include/Library/OemMiscLib.h | 1 +
 1 file changed, 1 insertion(+)

Comments

Leif Lindholm Oct. 27, 2016, 3:10 p.m. | #1
On Tue, Oct 18, 2016 at 09:10:03PM +0800, Heyi Guo wrote:
> Add OemIsNeedDisableExpanderBuffer() interface for SAS driver.
> 
> Change-Id: I85262a7800cb0a22e6ddc072d566b9df4405a126

Ah, a gerrit user :)

Please drop the Change-Id.

Same comment as for previous declaration-only patch: would it not make
more sense to squash this in with the patch adding the actual
implementation?

> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Heyi Guo <guoheyi@huawei.com>
> ---
>  Chips/Hisilicon/Include/Library/OemMiscLib.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Chips/Hisilicon/Include/Library/OemMiscLib.h b/Chips/Hisilicon/Include/Library/OemMiscLib.h
> index 19d92e0..6f18c0f 100644
> --- a/Chips/Hisilicon/Include/Library/OemMiscLib.h
> +++ b/Chips/Hisilicon/Include/Library/OemMiscLib.h
> @@ -44,6 +44,7 @@ BOOLEAN OemIsMpBoot();
>  UINT32 OemIsWarmBoot();
>  
>  VOID OemBiosSwitch(UINT32 Master);
> +BOOLEAN OemIsNeedDisableExpanderBuffer(VOID);
>  
>  extern EFI_STRING_ID gDimmToDevLocator[MAX_SOCKET][MAX_CHANNEL][MAX_DIMM];
>  EFI_HII_HANDLE EFIAPI OemGetPackages ();
> -- 
> 1.9.1
>

Patch

diff --git a/Chips/Hisilicon/Include/Library/OemMiscLib.h b/Chips/Hisilicon/Include/Library/OemMiscLib.h
index 19d92e0..6f18c0f 100644
--- a/Chips/Hisilicon/Include/Library/OemMiscLib.h
+++ b/Chips/Hisilicon/Include/Library/OemMiscLib.h
@@ -44,6 +44,7 @@  BOOLEAN OemIsMpBoot();
 UINT32 OemIsWarmBoot();
 
 VOID OemBiosSwitch(UINT32 Master);
+BOOLEAN OemIsNeedDisableExpanderBuffer(VOID);
 
 extern EFI_STRING_ID gDimmToDevLocator[MAX_SOCKET][MAX_CHANNEL][MAX_DIMM];
 EFI_HII_HANDLE EFIAPI OemGetPackages ();