[Linaro-uefi,v2,20/24] D03/OemNicConfig: add CpldIoLib to avoid potential build error

Message ID 1476796207-94336-21-git-send-email-heyi.guo@linaro.org
State New
Headers show

Commit Message

gary guo Oct. 18, 2016, 1:10 p.m.
D03 OemNicConfig driver is using CpldIoLib, so CpldIoLib needs
to be added to the INF file to avoid potential build error.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Heyi Guo <heyi.guo@linaro.org>
---
 Platforms/Hisilicon/D03/Drivers/OemNicConfig2PHi1610/OemNicConfig2P.inf | 1 +
 1 file changed, 1 insertion(+)

Comments

Leif Lindholm Oct. 27, 2016, 3:13 p.m. | #1
On Tue, Oct 18, 2016 at 09:10:04PM +0800, Heyi Guo wrote:
> D03 OemNicConfig driver is using CpldIoLib, so CpldIoLib needs
> to be added to the INF file to avoid potential build error.

Was this problem always here, or was in introduced by some more recent
changes?

> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Heyi Guo <heyi.guo@linaro.org>
> ---
>  Platforms/Hisilicon/D03/Drivers/OemNicConfig2PHi1610/OemNicConfig2P.inf | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Platforms/Hisilicon/D03/Drivers/OemNicConfig2PHi1610/OemNicConfig2P.inf b/Platforms/Hisilicon/D03/Drivers/OemNicConfig2PHi1610/OemNicConfig2P.inf
> index 4327406..7867fd0 100644
> --- a/Platforms/Hisilicon/D03/Drivers/OemNicConfig2PHi1610/OemNicConfig2P.inf
> +++ b/Platforms/Hisilicon/D03/Drivers/OemNicConfig2PHi1610/OemNicConfig2P.inf
> @@ -41,6 +41,7 @@
>    TimerLib
>    I2CLib
>    PcdLib
> +  CpldIoLib

I won't ask you to re-sort the .inf, but could you please insert this
new one before I2CLib to at least not make the order more random?

>  
>  [FixedPcd]
>  
> -- 
> 1.9.1
>

Patch

diff --git a/Platforms/Hisilicon/D03/Drivers/OemNicConfig2PHi1610/OemNicConfig2P.inf b/Platforms/Hisilicon/D03/Drivers/OemNicConfig2PHi1610/OemNicConfig2P.inf
index 4327406..7867fd0 100644
--- a/Platforms/Hisilicon/D03/Drivers/OemNicConfig2PHi1610/OemNicConfig2P.inf
+++ b/Platforms/Hisilicon/D03/Drivers/OemNicConfig2PHi1610/OemNicConfig2P.inf
@@ -41,6 +41,7 @@ 
   TimerLib
   I2CLib
   PcdLib
+  CpldIoLib
 
 [FixedPcd]