[2/2] scripts/gdb: fixup some pep8 errors in proc.py

Message ID 1476803249-23328-2-git-send-email-peter.griffin@linaro.org
State New
Headers show

Commit Message

Peter Griffin Oct. 18, 2016, 3:07 p.m.
proc.py:22:1: E302 expected 2 blank lines, found 1
proc.py:200:1: E302 expected 2 blank lines, found 1

Signed-off-by: Peter Griffin <peter.griffin@linaro.org>

---
 scripts/gdb/linux/proc.py | 2 ++
 1 file changed, 2 insertions(+)

-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Kieran Bingham Oct. 18, 2016, 3:27 p.m. | #1
Hi Pete,

On 18/10/16 16:07, Peter Griffin wrote:
> proc.py:22:1: E302 expected 2 blank lines, found 1

> proc.py:200:1: E302 expected 2 blank lines, found 1

> 

> Signed-off-by: Peter Griffin <peter.griffin@linaro.org>

> ---

>  scripts/gdb/linux/proc.py | 2 ++

>  1 file changed, 2 insertions(+)

> 

> diff --git a/scripts/gdb/linux/proc.py b/scripts/gdb/linux/proc.py

> index f20fcfa..2d6f74e 100644

> --- a/scripts/gdb/linux/proc.py

> +++ b/scripts/gdb/linux/proc.py

> @@ -18,6 +18,7 @@ from linux import tasks

>  from linux import lists

>  from struct import *

>  

> +


This was added by patch 1, and can be squashed there.

>  class LxCmdLine(gdb.Command):

>      """ Report the Linux Commandline used in the current kernel.

>          Equivalent to cat /proc/cmdline on a running target"""

> @@ -196,6 +197,7 @@ values of that process namespace"""

>  

>  LxMounts()

>  

> +


Likewise...

>  class LxFdtDump(gdb.Command):

>      """Output Flattened Device Tree header and dump FDT blob to a file

>         Equivalent to 'cat /proc/fdt > fdtdump.dtb' on a running target"""

> 


-- 
Regards

Kieran Bingham
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Peter Griffin Oct. 18, 2016, 3:57 p.m. | #2
Hi Kieran,

On Tue, 18 Oct 2016, Kieran Bingham wrote:

> Hi Pete,

> 

> On 18/10/16 16:07, Peter Griffin wrote:

> > proc.py:22:1: E302 expected 2 blank lines, found 1

> > proc.py:200:1: E302 expected 2 blank lines, found 1

> > 

> > Signed-off-by: Peter Griffin <peter.griffin@linaro.org>

> > ---

> >  scripts/gdb/linux/proc.py | 2 ++

> >  1 file changed, 2 insertions(+)

> > 

> > diff --git a/scripts/gdb/linux/proc.py b/scripts/gdb/linux/proc.py

> > index f20fcfa..2d6f74e 100644

> > --- a/scripts/gdb/linux/proc.py

> > +++ b/scripts/gdb/linux/proc.py

> > @@ -18,6 +18,7 @@ from linux import tasks

> >  from linux import lists

> >  from struct import *

> >  

> > +

> 

> This was added by patch 1, and can be squashed there.


Doh, I had deliberately done it as a separate commit, as I thought it was
a pre-existing pep8 error.

Will squash in v2.

regards,

Peter.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch hide | download patch | download mbox

diff --git a/scripts/gdb/linux/proc.py b/scripts/gdb/linux/proc.py
index f20fcfa..2d6f74e 100644
--- a/scripts/gdb/linux/proc.py
+++ b/scripts/gdb/linux/proc.py
@@ -18,6 +18,7 @@  from linux import tasks
 from linux import lists
 from struct import *
 
+
 class LxCmdLine(gdb.Command):
     """ Report the Linux Commandline used in the current kernel.
         Equivalent to cat /proc/cmdline on a running target"""
@@ -196,6 +197,7 @@  values of that process namespace"""
 
 LxMounts()
 
+
 class LxFdtDump(gdb.Command):
     """Output Flattened Device Tree header and dump FDT blob to a file
        Equivalent to 'cat /proc/fdt > fdtdump.dtb' on a running target"""