| Message ID | 20240327-module-owner-virtio-v1-9-0feffab77d99@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | virtio: store owner from modules with register_virtio_driver() | expand |
On 27-03-24, 13:41, Krzysztof Kozlowski wrote: > virtio core already sets the .owner, so driver does not need to. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > --- > > Depends on the first patch. > --- > drivers/gpio/gpio-virtio.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpio/gpio-virtio.c b/drivers/gpio/gpio-virtio.c > index fcc5e8c08973..9fae8e396c58 100644 > --- a/drivers/gpio/gpio-virtio.c > +++ b/drivers/gpio/gpio-virtio.c > @@ -653,7 +653,6 @@ static struct virtio_driver virtio_gpio_driver = { > .remove = virtio_gpio_remove, > .driver = { > .name = KBUILD_MODNAME, > - .owner = THIS_MODULE, > }, > }; > module_virtio_driver(virtio_gpio_driver); Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
On Fri, Mar 29, 2024 at 11:27:19AM +0100, Bartosz Golaszewski wrote: >On Wed, Mar 27, 2024 at 1:45 PM Krzysztof Kozlowski ><krzysztof.kozlowski@linaro.org> wrote: >> >> virtio core already sets the .owner, so driver does not need to. >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> >> --- >> >> Depends on the first patch. >> --- >> drivers/gpio/gpio-virtio.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/drivers/gpio/gpio-virtio.c b/drivers/gpio/gpio-virtio.c >> index fcc5e8c08973..9fae8e396c58 100644 >> --- a/drivers/gpio/gpio-virtio.c >> +++ b/drivers/gpio/gpio-virtio.c >> @@ -653,7 +653,6 @@ static struct virtio_driver virtio_gpio_driver = { >> .remove = virtio_gpio_remove, >> .driver = { >> .name = KBUILD_MODNAME, >> - .owner = THIS_MODULE, >> }, >> }; >> module_virtio_driver(virtio_gpio_driver); >> >> -- >> 2.34.1 >> > >Applied, thanks! Did you also applied the first patch of this series? Without that I'm not sure it's a good idea to apply this patch as also Krzysztof mentioned after ---. Thanks, Stefano
On Fri, Mar 29, 2024 at 12:35 PM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 29/03/2024 11:27, Bartosz Golaszewski wrote: > > On Wed, Mar 27, 2024 at 1:45 PM Krzysztof Kozlowski > > <krzysztof.kozlowski@linaro.org> wrote: > >> > >> virtio core already sets the .owner, so driver does not need to. > >> > >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > >> > >> --- > >> > >> Depends on the first patch. > >> --- > >> drivers/gpio/gpio-virtio.c | 1 - > >> 1 file changed, 1 deletion(-) > >> > >> diff --git a/drivers/gpio/gpio-virtio.c b/drivers/gpio/gpio-virtio.c > >> index fcc5e8c08973..9fae8e396c58 100644 > >> --- a/drivers/gpio/gpio-virtio.c > >> +++ b/drivers/gpio/gpio-virtio.c > >> @@ -653,7 +653,6 @@ static struct virtio_driver virtio_gpio_driver = { > >> .remove = virtio_gpio_remove, > >> .driver = { > >> .name = KBUILD_MODNAME, > >> - .owner = THIS_MODULE, > >> }, > >> }; > >> module_virtio_driver(virtio_gpio_driver); > >> > >> -- > >> 2.34.1 > >> > > > > Applied, thanks! > > I expressed dependency in two places: cover letter and this patch. > Please drop it, because without dependency this won't work. Patch could > go with the dependency and with your ack or next cycle. > > Best regards, > Krzysztof > Dropped, and: Acked-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
diff --git a/drivers/gpio/gpio-virtio.c b/drivers/gpio/gpio-virtio.c index fcc5e8c08973..9fae8e396c58 100644 --- a/drivers/gpio/gpio-virtio.c +++ b/drivers/gpio/gpio-virtio.c @@ -653,7 +653,6 @@ static struct virtio_driver virtio_gpio_driver = { .remove = virtio_gpio_remove, .driver = { .name = KBUILD_MODNAME, - .owner = THIS_MODULE, }, }; module_virtio_driver(virtio_gpio_driver);
virtio core already sets the .owner, so driver does not need to. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- Depends on the first patch. --- drivers/gpio/gpio-virtio.c | 1 - 1 file changed, 1 deletion(-)