diff mbox series

[v2,5/6] platform/chrome: cros_kbd_led_backlight: shrink the driver name

Message ID 20240401030052.2887845-6-tzungbi@kernel.org
State New
Headers show
Series provide ID table for avoiding fallback match | expand

Commit Message

Tzung-Bi Shih April 1, 2024, 3 a.m. UTC 
Prepare to provide platform_device_id table.  Shrink the driver name for
fitting to [1].

[1]: https://elixir.bootlin.com/linux/v6.8/source/include/linux/mod_devicetable.h#L608

Reviewed-by: Benson Leung <bleung@chromium.org>
Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org>
---
Changes from v1 (https://patchwork.kernel.org/project/chrome-platform/patch/20240329075630.2069474-15-tzungbi@kernel.org/):
- Split from "platform/chrome: cros_kbd_led_backlight: provide ID table for
  avoiding fallback match".
- Add R-b tags.

 drivers/platform/chrome/cros_kbd_led_backlight.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Tzung-Bi Shih April 1, 2024, 10:42 a.m. UTC | #1 
On Mon, Apr 01, 2024 at 12:19:16PM +0200, Krzysztof Kozlowski wrote:
> On 01/04/2024 12:02, Krzysztof Kozlowski wrote:
> > On 01/04/2024 05:00, Tzung-Bi Shih wrote:
> >> Prepare to provide platform_device_id table.  Shrink the driver name for
> >> fitting to [1].
> > 
> > Instead of linking to external resources, please describe the problem
> > and the bug you are fixing here.
> > 
> >>
> >> [1]: https://elixir.bootlin.com/linux/v6.8/source/include/linux/mod_devicetable.h#L608
> >>
> >> Reviewed-by: Benson Leung <bleung@chromium.org>
> >> Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org>
> > 
> > Missing fixes tag and Cc-stable.
> 
> Ah, now I read your answer to v1 discussion. So this was not a bug in
> the first place? Hm, then probably my comment was not really correct and
> we should not split it.

Correct, this wasn't a bug in the first place.  Only if moving the string into
struct platform_device_id, the compiler emits errors about the oversize.

I'm fine with both versions.  But let's go back to adopt v1 (no split) if no
strong objections.

Thanks a lot for your review again.
diff mbox series

Patch

diff --git a/drivers/platform/chrome/cros_kbd_led_backlight.c b/drivers/platform/chrome/cros_kbd_led_backlight.c
index 793fd3f1015d..814846a66e95 100644
--- a/drivers/platform/chrome/cros_kbd_led_backlight.c
+++ b/drivers/platform/chrome/cros_kbd_led_backlight.c
@@ -249,7 +249,7 @@  MODULE_DEVICE_TABLE(of, keyboard_led_of_match);
 
 static struct platform_driver keyboard_led_driver = {
 	.driver		= {
-		.name	= "chromeos-keyboard-leds",
+		.name	= "cros-keyboard-leds",
 		.acpi_match_table = ACPI_PTR(keyboard_led_acpi_match),
 		.of_match_table = of_match_ptr(keyboard_led_of_match),
 	},
@@ -260,4 +260,4 @@  module_platform_driver(keyboard_led_driver);
 MODULE_AUTHOR("Simon Que <sque@chromium.org>");
 MODULE_DESCRIPTION("ChromeOS Keyboard backlight LED Driver");
 MODULE_LICENSE("GPL");
-MODULE_ALIAS("platform:chromeos-keyboard-leds");
+MODULE_ALIAS("platform:cros-keyboard-leds");