| Message ID | 20240408042331.403103-3-quic_mohs@quicinc.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add support for QCM6490 and QCS6490 | expand |
On 08/04/2024 14:45, Bjorn Andersson wrote: > On Mon, Apr 08, 2024 at 09:53:31AM +0530, Mohammad Rafi Shaik wrote: >> Add compatibles for sound card on Qualcomm QCM6490 IDP and >> QCS6490 RB3Gen2 boards. >> >> Signed-off-by: Mohammad Rafi Shaik <quic_mohs@quicinc.com> >> --- >> sound/soc/qcom/sc8280xp.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/sound/soc/qcom/sc8280xp.c b/sound/soc/qcom/sc8280xp.c >> index b7fd503a1666..878bd50ad4a7 100644 >> --- a/sound/soc/qcom/sc8280xp.c >> +++ b/sound/soc/qcom/sc8280xp.c >> @@ -169,6 +169,8 @@ static int sc8280xp_platform_probe(struct platform_device *pdev) >> } >> >> static const struct of_device_id snd_sc8280xp_dt_match[] = { >> + {.compatible = "qcom,qcm6490-idp-sndcard", "qcm6490"}, >> + {.compatible = "qcom,qcs6490-rb3gen2-sndcard", "qcs6490"}, > > We now have 4 <platform>-sndcard and two <board>-sndcard compatibles > here. > > Not saying that your patch is wrong, but is this driver board-specific > or soc-specific? Srinivas, Krzysztof? To my understanding this is mostly board specific, but it is also partially a software construct thus we simplify it by using SoC compatible for all boards with given SoC. I have no clue whether this applies here. I think we asked about clarifying the differences, but as you can see nothing improved in the commit msg. Best regards, Krzysztof
diff --git a/sound/soc/qcom/sc8280xp.c b/sound/soc/qcom/sc8280xp.c index b7fd503a1666..878bd50ad4a7 100644 --- a/sound/soc/qcom/sc8280xp.c +++ b/sound/soc/qcom/sc8280xp.c @@ -169,6 +169,8 @@ static int sc8280xp_platform_probe(struct platform_device *pdev) } static const struct of_device_id snd_sc8280xp_dt_match[] = { + {.compatible = "qcom,qcm6490-idp-sndcard", "qcm6490"}, + {.compatible = "qcom,qcs6490-rb3gen2-sndcard", "qcs6490"}, {.compatible = "qcom,sc8280xp-sndcard", "sc8280xp"}, {.compatible = "qcom,sm8450-sndcard", "sm8450"}, {.compatible = "qcom,sm8550-sndcard", "sm8550"},
Add compatibles for sound card on Qualcomm QCM6490 IDP and QCS6490 RB3Gen2 boards. Signed-off-by: Mohammad Rafi Shaik <quic_mohs@quicinc.com> --- sound/soc/qcom/sc8280xp.c | 2 ++ 1 file changed, 2 insertions(+)