[1/2] drm/msm: add missing header dependencies

Message ID 1477127865-9381-2-git-send-email-baoyou.xie@linaro.org
State New
Headers show

Commit Message

Baoyou Xie Oct. 22, 2016, 9:17 a.m.
We get 2 warnings when building kernel with W=1:
drivers/gpu/drm/msm/msm_debugfs.c:141:5: warning: no previous prototype for 'msm_debugfs_init' [-Wmissing-prototypes]
drivers/gpu/drm/msm/msm_debugfs.c:158:6: warning: no previous prototype for 'msm_debugfs_cleanup' [-Wmissing-prototypes]

In fact, these functions are declared in
drivers/gpu/drm/msm/msm_debugfs.h.
So this patch adds missing header dependencies.

Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>

---
 drivers/gpu/drm/msm/msm_debugfs.c | 1 +
 1 file changed, 1 insertion(+)

-- 
2.7.4

--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Daniel Vetter Oct. 24, 2016, 2:31 p.m. | #1
On Mon, Oct 24, 2016 at 12:13:40PM +0200, Arnd Bergmann wrote:
> On Saturday, October 22, 2016 5:17:45 PM CEST Baoyou Xie wrote:

> > We get 2 warnings when building kernel with W=1:

> > drivers/gpu/drm/msm/msm_debugfs.c:141:5: warning: no previous prototype for 'msm_debugfs_init' [-Wmissing-prototypes]

> > drivers/gpu/drm/msm/msm_debugfs.c:158:6: warning: no previous prototype for 'msm_debugfs_cleanup' [-Wmissing-prototypes]

> > 

> > In fact, these functions are declared in

> > drivers/gpu/drm/msm/msm_debugfs.h.

> > So this patch adds missing header dependencies.

> > 

> > Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>

> > 

> 

> Both patches

> 

> Reviewed-by: Arnd Bergmann <arnd@arndb.de>


Both applied to drm-misc, thanks.

> Strangely, something caused the second mail to show up as a reply to the

> first. No idea how that happened, but you may want to check the procedure

> you used for sending the mails.


Not generated as a series, but individual patches, but then send out using
just 1 invocation of git send-email? "add" sorts before "adreno", and git
format-patch changes every non-alphanumeric character to a '-'.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch hide | download patch | download mbox

diff --git a/drivers/gpu/drm/msm/msm_debugfs.c b/drivers/gpu/drm/msm/msm_debugfs.c
index 663f2b6..3c85373 100644
--- a/drivers/gpu/drm/msm/msm_debugfs.c
+++ b/drivers/gpu/drm/msm/msm_debugfs.c
@@ -18,6 +18,7 @@ 
 #ifdef CONFIG_DEBUG_FS
 #include "msm_drv.h"
 #include "msm_gpu.h"
+#include "msm_debugfs.h"
 
 static int msm_gpu_show(struct drm_device *dev, struct seq_file *m)
 {