| Message ID | 1477129318-29677-1-git-send-email-baoyou.xie@linaro.org |
|---|---|
| State | Accepted |
| Commit | d6c6035af7ccadd647832681d6b2a53d4c8705de |
| Headers | show |
I think it would be better to squash those commits: 1. for the includes 2. for static declerations 2016-10-22 11:41 GMT+02:00 Baoyou Xie <baoyou.xie@linaro.org>: > We get 2 warnings when building kernel with W=1: > drivers/gpu/drm/nouveau/nvkm/core/firmware.c:34:1: warning: no previous prototype for 'nvkm_firmware_get' [-Wmissing-prototypes] > drivers/gpu/drm/nouveau/nvkm/core/firmware.c:58:1: warning: no previous prototype for 'nvkm_firmware_put' [-Wmissing-prototypes] > > In fact, these functions are declared in > drivers/gpu/drm/nouveau/include/nvkm/core/firmware.h. > So this patch adds missing header dependencies. > > Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org> > --- > drivers/gpu/drm/nouveau/nvkm/core/firmware.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/nouveau/nvkm/core/firmware.c b/drivers/gpu/drm/nouveau/nvkm/core/firmware.c > index 34ecd4a..058ff46 100644 > --- a/drivers/gpu/drm/nouveau/nvkm/core/firmware.c > +++ b/drivers/gpu/drm/nouveau/nvkm/core/firmware.c > @@ -20,6 +20,7 @@ > * DEALINGS IN THE SOFTWARE. > */ > #include <core/device.h> > +#include <core/firmware.h> > > /** > * nvkm_firmware_get - load firmware from the official nvidia/chip/ directory > -- > 2.7.4 > > _______________________________________________ > Nouveau mailing list > Nouveau@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/nouveau
2016-10-24 9:13 GMT+02:00 Baoyou Xie <baoyou.xie@linaro.org>: > > > On 23 October 2016 at 01:32, Karol Herbst <karolherbst@gmail.com> wrote: >> >> I think it would be better to squash those commits: >> 1. for the includes >> 2. for static declerations >> > OK, I have resent new patch that squash those commits. > thanks, this is much easier to review and keeps the git history clean :) Will try to make a test with those patches over the next days, but it looks fine as it is already. >> >> 2016-10-22 11:41 GMT+02:00 Baoyou Xie <baoyou.xie@linaro.org>: >> > We get 2 warnings when building kernel with W=1: >> > drivers/gpu/drm/nouveau/nvkm/core/firmware.c:34:1: warning: no previous >> > prototype for 'nvkm_firmware_get' [-Wmissing-prototypes] >> > drivers/gpu/drm/nouveau/nvkm/core/firmware.c:58:1: warning: no previous >> > prototype for 'nvkm_firmware_put' [-Wmissing-prototypes] >> > >> > In fact, these functions are declared in >> > drivers/gpu/drm/nouveau/include/nvkm/core/firmware.h. >> > So this patch adds missing header dependencies. >> > >> > Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org> >> > --- >> > drivers/gpu/drm/nouveau/nvkm/core/firmware.c | 1 + >> > 1 file changed, 1 insertion(+) >> > >> > diff --git a/drivers/gpu/drm/nouveau/nvkm/core/firmware.c >> > b/drivers/gpu/drm/nouveau/nvkm/core/firmware.c >> > index 34ecd4a..058ff46 100644 >> > --- a/drivers/gpu/drm/nouveau/nvkm/core/firmware.c >> > +++ b/drivers/gpu/drm/nouveau/nvkm/core/firmware.c >> > @@ -20,6 +20,7 @@ >> > * DEALINGS IN THE SOFTWARE. >> > */ >> > #include <core/device.h> >> > +#include <core/firmware.h> >> > >> > /** >> > * nvkm_firmware_get - load firmware from the official nvidia/chip/ >> > directory >> > -- >> > 2.7.4 >> > >> > _______________________________________________ >> > Nouveau mailing list >> > Nouveau@lists.freedesktop.org >> > https://lists.freedesktop.org/mailman/listinfo/nouveau > >
diff --git a/drivers/gpu/drm/nouveau/nvkm/core/firmware.c b/drivers/gpu/drm/nouveau/nvkm/core/firmware.c index 34ecd4a..058ff46 100644 --- a/drivers/gpu/drm/nouveau/nvkm/core/firmware.c +++ b/drivers/gpu/drm/nouveau/nvkm/core/firmware.c @@ -20,6 +20,7 @@ * DEALINGS IN THE SOFTWARE. */ #include <core/device.h> +#include <core/firmware.h> /** * nvkm_firmware_get - load firmware from the official nvidia/chip/ directory
We get 2 warnings when building kernel with W=1: drivers/gpu/drm/nouveau/nvkm/core/firmware.c:34:1: warning: no previous prototype for 'nvkm_firmware_get' [-Wmissing-prototypes] drivers/gpu/drm/nouveau/nvkm/core/firmware.c:58:1: warning: no previous prototype for 'nvkm_firmware_put' [-Wmissing-prototypes] In fact, these functions are declared in drivers/gpu/drm/nouveau/include/nvkm/core/firmware.h. So this patch adds missing header dependencies. Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org> --- drivers/gpu/drm/nouveau/nvkm/core/firmware.c | 1 + 1 file changed, 1 insertion(+) -- 2.7.4