diff mbox

[v2,2/4] ti_omap5_common: Respect USB controller number in fastboot

Message ID 20161024154113.19607-3-semen.protsenko@linaro.org
State Accepted
Commit ada03c3c3d41ba9b9886c5d4ba75e744c2b0cf88
Headers show

Commit Message

Sam Protsenko Oct. 24, 2016, 3:41 p.m. UTC
On "fastboot reboot-bootloader" we check "dofastboot" variable and do
"fastboot 0" command in U-Boot if it's 1. But there are boards which have
USB controller number other than 0, so it should be respected when
performing "fastboot" command.

This patch reuses CONFIG_FASTBOOT_USB_DEV option toprovide correct USB
controller number to "fastboot" command.

Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>

---
Changes in v2:
  - Remove unnecessary check for CONFIG_FASTBOOT_USB_DEV

 include/configs/ti_omap5_common.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

-- 
2.9.3

_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Comments

Tom Rini Oct. 24, 2016, 4:12 p.m. UTC | #1
On Mon, Oct 24, 2016 at 06:41:11PM +0300, Sam Protsenko wrote:

> On "fastboot reboot-bootloader" we check "dofastboot" variable and do

> "fastboot 0" command in U-Boot if it's 1. But there are boards which have

> USB controller number other than 0, so it should be respected when

> performing "fastboot" command.

> 

> This patch reuses CONFIG_FASTBOOT_USB_DEV option toprovide correct USB

> controller number to "fastboot" command.

> 

> Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>


Reviewed-by: Tom Rini <trini@konsulko.com>


-- 
Tom
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Tom Rini Nov. 22, 2016, 2:43 a.m. UTC | #2
On Mon, Oct 24, 2016 at 06:41:11PM +0300, Semen Protsenko wrote:

> On "fastboot reboot-bootloader" we check "dofastboot" variable and do

> "fastboot 0" command in U-Boot if it's 1. But there are boards which have

> USB controller number other than 0, so it should be respected when

> performing "fastboot" command.

> 

> This patch reuses CONFIG_FASTBOOT_USB_DEV option toprovide correct USB

> controller number to "fastboot" command.

> 

> Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>

> Reviewed-by: Tom Rini <trini@konsulko.com>


Applied to u-boot/master, thanks!

-- 
Tom
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
diff mbox

Patch

diff --git a/include/configs/ti_omap5_common.h b/include/configs/ti_omap5_common.h
index 29b7d96..b85fae3 100644
--- a/include/configs/ti_omap5_common.h
+++ b/include/configs/ti_omap5_common.h
@@ -114,7 +114,8 @@ 
 	"if test ${dofastboot} -eq 1; then " \
 		"echo Boot fastboot requested, resetting dofastboot ...;" \
 		"setenv dofastboot 0; saveenv;" \
-		"echo Booting into fastboot ...; fastboot 0;" \
+		"echo Booting into fastboot ...; " \
+		"fastboot " __stringify(CONFIG_FASTBOOT_USB_DEV) "; " \
 	"fi;" \
 	"run findfdt; " \
 	"run envboot; " \