diff mbox series

leds: aat1290: Remove an unused field in struct aat1290_led

Message ID f7c8c22242544b11e95d9a77d7d0ea17f5a24fd5.1714318454.git.christophe.jaillet@wanadoo.fr
State New
Headers show
Series leds: aat1290: Remove an unused field in struct aat1290_led | expand

Commit Message

Christophe JAILLET April 28, 2024, 3:34 p.m. UTC
In "struct aat1290_led", the 'torch_brightness' field is unused.
Remove it.

Found with cppcheck, unusedStructMember.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
Compile tested only.

It was added added in commit 49c34b8e0f43 ("leds: Add driver for AAT1290
flash LED controller") and its only user was removed in commit 269e92da8b07
("leds: aat1290: Remove work queue").
---
 drivers/leds/flash/leds-aat1290.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Lee Jones May 2, 2024, 5:09 p.m. UTC | #1
On Sun, 28 Apr 2024 17:34:55 +0200, Christophe JAILLET wrote:
> In "struct aat1290_led", the 'torch_brightness' field is unused.
> Remove it.
> 
> Found with cppcheck, unusedStructMember.
> 
> 

Applied, thanks!

[1/1] leds: aat1290: Remove an unused field in struct aat1290_led
      commit: 678ba7d25467c06850d0d2922108573ea7346a48

--
Lee Jones [李琼斯]
diff mbox series

Patch

diff --git a/drivers/leds/flash/leds-aat1290.c b/drivers/leds/flash/leds-aat1290.c
index 0195935a7c99..e8f9dd293592 100644
--- a/drivers/leds/flash/leds-aat1290.c
+++ b/drivers/leds/flash/leds-aat1290.c
@@ -77,8 +77,6 @@  struct aat1290_led {
 	int *mm_current_scale;
 	/* device mode */
 	bool movie_mode;
-	/* brightness cache */
-	unsigned int torch_brightness;
 };
 
 static struct aat1290_led *fled_cdev_to_led(