| Message ID | 20240425-mark_ethernet_devices_dma_coherent-v1-1-ad0755044e26@quicinc.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | arm64: dts: qcom: sa8775p: mark ethernet devices as DMA-coherent | expand |
On Thu, Apr 25, 2024 at 04:07:10PM -0700, Sagar Cheluvegowda wrote: > Ethernet devices are cache coherent, mark it as such in the dtsi. > > Change-Id: Id180fae617f2e348c0a80c6664b131cc57fcb4d6 > Signed-off-by: Sagar Cheluvegowda <quic_scheluve@quicinc.com> In addition to what others have said, I think you should include fixes tags for this, so something like: Fixes: ff499a0fbb23 ("arm64: dts: qcom: sa8775p: add the first 1Gb ethernet interface") Fixes: e952348a7cc7 ("arm64: dts: qcom: sa8775p: add a node for EMAC1") to indicate this isn't just an improvement, but a proper bug fix. Thanks, Andrew
diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi index 231cea1f0fa8..5ab4ca978837 100644 --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi @@ -2504,6 +2504,7 @@ ethernet1: ethernet@23000000 { phy-names = "serdes"; iommus = <&apps_smmu 0x140 0xf>; + dma-coherent; snps,tso; snps,pbl = <32>; @@ -2538,6 +2539,7 @@ ethernet0: ethernet@23040000 { phy-names = "serdes"; iommus = <&apps_smmu 0x120 0xf>; + dma-coherent; snps,tso; snps,pbl = <32>;
Ethernet devices are cache coherent, mark it as such in the dtsi. Change-Id: Id180fae617f2e348c0a80c6664b131cc57fcb4d6 Signed-off-by: Sagar Cheluvegowda <quic_scheluve@quicinc.com> --- arch/arm64/boot/dts/qcom/sa8775p.dtsi | 2 ++ 1 file changed, 2 insertions(+) --- base-commit: a93289b830ce783955b22fbe5d1274a464c05acf change-id: 20240425-mark_ethernet_devices_dma_coherent-6c6154b84165 Best regards,