diff mbox series

[net-next] test: hsr: Call cleanup_all_ns when hsr_redbox.sh script exits

Message ID 20240507091155.3504198-1-lukma@denx.de
State Accepted
Commit 252aa6d53931381bd774acd06866ed0fb1976ead
Headers show
Series [net-next] test: hsr: Call cleanup_all_ns when hsr_redbox.sh script exits | expand

Commit Message

Lukasz Majewski May 7, 2024, 9:11 a.m. UTC
Without this change the created netns instances are not cleared after
this script execution. To fix this problem the cleanup_all_ns function
from ../lib.sh is called.

Signed-off-by: Lukasz Majewski <lukma@denx.de>
---
 tools/testing/selftests/net/hsr/hsr_redbox.sh | 2 ++
 1 file changed, 2 insertions(+)

Comments

Simon Horman May 8, 2024, 9:07 a.m. UTC | #1
On Tue, May 07, 2024 at 11:11:55AM +0200, Lukasz Majewski wrote:
> Without this change the created netns instances are not cleared after
> this script execution. To fix this problem the cleanup_all_ns function
> from ../lib.sh is called.
> 
> Signed-off-by: Lukasz Majewski <lukma@denx.de>

Reviewed-by: Simon Horman <horms@kernel.org>
patchwork-bot+netdevbpf@kernel.org May 8, 2024, 11:30 a.m. UTC | #2
Hello:

This patch was applied to netdev/net-next.git (main)
by David S. Miller <davem@davemloft.net>:

On Tue,  7 May 2024 11:11:55 +0200 you wrote:
> Without this change the created netns instances are not cleared after
> this script execution. To fix this problem the cleanup_all_ns function
> from ../lib.sh is called.
> 
> Signed-off-by: Lukasz Majewski <lukma@denx.de>
> ---
>  tools/testing/selftests/net/hsr/hsr_redbox.sh | 2 ++
>  1 file changed, 2 insertions(+)

Here is the summary with links:
  - [net-next] test: hsr: Call cleanup_all_ns when hsr_redbox.sh script exits
    https://git.kernel.org/netdev/net-next/c/252aa6d53931

You are awesome, thank you!
diff mbox series

Patch

diff --git a/tools/testing/selftests/net/hsr/hsr_redbox.sh b/tools/testing/selftests/net/hsr/hsr_redbox.sh
index 52e0412c32e6..db69be95ecb3 100755
--- a/tools/testing/selftests/net/hsr/hsr_redbox.sh
+++ b/tools/testing/selftests/net/hsr/hsr_redbox.sh
@@ -86,6 +86,8 @@  setup_hsr_interfaces()
 check_prerequisites
 setup_ns ns1 ns2 ns3
 
+trap cleanup_all_ns EXIT
+
 setup_hsr_interfaces 1
 do_complete_ping_test