diff mbox

[Linaro-uefi,25/26] D03/USB: fix ehci interrupt pin number

Message ID 1477538129-118465-24-git-send-email-heyi.guo@linaro.org
State Superseded
Headers show

Commit Message

gary guo Oct. 27, 2016, 3:15 a.m. UTC
The ehci hardware pin number should be 641, correct it.i

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Kefeng Wang <wangkefeng@huawei.com>
Signed-off-by: Heyi Guo <heyi.guo@linaro.org>
---
 Chips/Hisilicon/Hi1610/Hi1610AcpiTables/Dsdt/D03Mbig.asl | 2 +-
 Chips/Hisilicon/Hi1610/Hi1610AcpiTables/Dsdt/D03Usb.asl  | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Leif Lindholm Nov. 5, 2016, 11:42 p.m. UTC | #1
On Thu, Oct 27, 2016 at 11:15:28AM +0800, Heyi Guo wrote:
> The ehci hardware pin number should be 641, correct it.i

Drop the trailing 'i'.

> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Kefeng Wang <wangkefeng@huawei.com>
> Signed-off-by: Heyi Guo <heyi.guo@linaro.org>
> ---
>  Chips/Hisilicon/Hi1610/Hi1610AcpiTables/Dsdt/D03Mbig.asl | 2 +-
>  Chips/Hisilicon/Hi1610/Hi1610AcpiTables/Dsdt/D03Usb.asl  | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Chips/Hisilicon/Hi1610/Hi1610AcpiTables/Dsdt/D03Mbig.asl b/Chips/Hisilicon/Hi1610/Hi1610AcpiTables/Dsdt/D03Mbig.asl
> index afd6b47..36a9c0c 100644
> --- a/Chips/Hisilicon/Hi1610/Hi1610AcpiTables/Dsdt/D03Mbig.asl
> +++ b/Chips/Hisilicon/Hi1610/Hi1610AcpiTables/Dsdt/D03Mbig.asl
> @@ -23,7 +23,7 @@ Scope(_SB)
>      })
>  
>     Name(_PRS, ResourceTemplate() {
> -       Interrupt(ResourceProducer, Edge, ActiveHigh, Exclusive, 0,,) {0x41, 0x42}
> +       Interrupt(ResourceProducer, Edge, ActiveHigh, Exclusive, 0,,) {640, 641}

This gets confusing though - this is changing 0x41 to 640 (which is
not mentioned in commit message) and 0x42 to 641...

>         })
>  
>     Name(_DSD, Package () {
> diff --git a/Chips/Hisilicon/Hi1610/Hi1610AcpiTables/Dsdt/D03Usb.asl b/Chips/Hisilicon/Hi1610/Hi1610AcpiTables/Dsdt/D03Usb.asl
> index 8429a4b..5bb03eb 100644
> --- a/Chips/Hisilicon/Hi1610/Hi1610AcpiTables/Dsdt/D03Usb.asl
> +++ b/Chips/Hisilicon/Hi1610/Hi1610AcpiTables/Dsdt/D03Usb.asl
> @@ -34,7 +34,7 @@ Scope(_SB)
>                          )
>                      Interrupt (ResourceConsumer, Level, ActiveHigh, Exclusive, 0, "\\_SB.MBI0")
>                      {
> -                        0x00000041,
> +                        641,

Whereas this is changing a 0x41 to 641.

>                      }
>                  })
>                  Return (RBUF) /* \_SB_.USB0._CRS.RBUF */
> -- 
> 1.9.1
>
diff mbox

Patch

diff --git a/Chips/Hisilicon/Hi1610/Hi1610AcpiTables/Dsdt/D03Mbig.asl b/Chips/Hisilicon/Hi1610/Hi1610AcpiTables/Dsdt/D03Mbig.asl
index afd6b47..36a9c0c 100644
--- a/Chips/Hisilicon/Hi1610/Hi1610AcpiTables/Dsdt/D03Mbig.asl
+++ b/Chips/Hisilicon/Hi1610/Hi1610AcpiTables/Dsdt/D03Mbig.asl
@@ -23,7 +23,7 @@  Scope(_SB)
     })
 
    Name(_PRS, ResourceTemplate() {
-       Interrupt(ResourceProducer, Edge, ActiveHigh, Exclusive, 0,,) {0x41, 0x42}
+       Interrupt(ResourceProducer, Edge, ActiveHigh, Exclusive, 0,,) {640, 641}
        })
 
    Name(_DSD, Package () {
diff --git a/Chips/Hisilicon/Hi1610/Hi1610AcpiTables/Dsdt/D03Usb.asl b/Chips/Hisilicon/Hi1610/Hi1610AcpiTables/Dsdt/D03Usb.asl
index 8429a4b..5bb03eb 100644
--- a/Chips/Hisilicon/Hi1610/Hi1610AcpiTables/Dsdt/D03Usb.asl
+++ b/Chips/Hisilicon/Hi1610/Hi1610AcpiTables/Dsdt/D03Usb.asl
@@ -34,7 +34,7 @@  Scope(_SB)
                         )
                     Interrupt (ResourceConsumer, Level, ActiveHigh, Exclusive, 0, "\\_SB.MBI0")
                     {
-                        0x00000041,
+                        641,
                     }
                 })
                 Return (RBUF) /* \_SB_.USB0._CRS.RBUF */