| Message ID | 20240510070653.537089-1-m.szyprowski@samsung.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v3] clk: samsung: exynos-clkout: Remove misleading of_match_table/MODULE_DEVICE_TABLE | expand |
On Fri, May 10, 2024 at 2:07 AM Marek Szyprowski <m.szyprowski@samsung.com> wrote: > > Since commit 9484f2cb8332 ("clk: samsung: exynos-clkout: convert to > module driver") this driver is instantiated as MFD-cell (matched by > platform device name) not as a real platform device created by OF code. > Remove then of_match_table and change related MODULE_DEVICE_TABLE to > simple MODULE_ALIAS to avoid further confusion. > > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> > --- > v3: > - Use '#define DRV_NAME' based alias. I see no point bloating the driver > with another platform device IDs array, as I don't expect this driver to > be used with any other platform device ID. Driver variants are already > selected based on the parent PMU device compatible. > > v2: > - added MODULE_ALIAS > --- Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org> [snip]
On 05/10/2024, Sam Protsenko wrote: > On Fri, May 10, 2024 at 2:07 AM Marek Szyprowski > <m.szyprowski@samsung.com> wrote: > > > > Since commit 9484f2cb8332 ("clk: samsung: exynos-clkout: convert to > > module driver") this driver is instantiated as MFD-cell (matched by > > platform device name) not as a real platform device created by OF code. > > Remove then of_match_table and change related MODULE_DEVICE_TABLE to > > simple MODULE_ALIAS to avoid further confusion. > > > > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> > > --- > > v3: > > - Use '#define DRV_NAME' based alias. I see no point bloating the driver > > with another platform device IDs array, as I don't expect this driver to > > be used with any other platform device ID. Driver variants are already > > selected based on the parent PMU device compatible. Sure, I'm fine with this either way. Thanks for following up! > > > > v2: > > - added MODULE_ALIAS > > --- > > Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org> Reviewed-by: Will McVicker <willmcvicker@google.com> > > [snip]
diff --git a/drivers/clk/samsung/clk-exynos-clkout.c b/drivers/clk/samsung/clk-exynos-clkout.c index 503c6f5b20d5..89cf2000884f 100644 --- a/drivers/clk/samsung/clk-exynos-clkout.c +++ b/drivers/clk/samsung/clk-exynos-clkout.c @@ -17,6 +17,8 @@ #include <linux/platform_device.h> #include <linux/pm.h> +#define DRV_NAME "exynos-clkout" + #define EXYNOS_CLKOUT_NR_CLKS 1 #define EXYNOS_CLKOUT_PARENTS 32 @@ -75,7 +77,6 @@ static const struct of_device_id exynos_clkout_ids[] = { .data = &exynos_clkout_exynos5, }, { } }; -MODULE_DEVICE_TABLE(of, exynos_clkout_ids); /* * Device will be instantiated as child of PMU device without its own @@ -236,8 +237,7 @@ static SIMPLE_DEV_PM_OPS(exynos_clkout_pm_ops, exynos_clkout_suspend, static struct platform_driver exynos_clkout_driver = { .driver = { - .name = "exynos-clkout", - .of_match_table = exynos_clkout_ids, + .name = DRV_NAME, .pm = &exynos_clkout_pm_ops, }, .probe = exynos_clkout_probe, @@ -248,4 +248,5 @@ module_platform_driver(exynos_clkout_driver); MODULE_AUTHOR("Krzysztof Kozlowski <krzk@kernel.org>"); MODULE_AUTHOR("Tomasz Figa <tomasz.figa@gmail.com>"); MODULE_DESCRIPTION("Samsung Exynos clock output driver"); +MODULE_ALIAS("platform:" DRV_NAME); MODULE_LICENSE("GPL");
Since commit 9484f2cb8332 ("clk: samsung: exynos-clkout: convert to module driver") this driver is instantiated as MFD-cell (matched by platform device name) not as a real platform device created by OF code. Remove then of_match_table and change related MODULE_DEVICE_TABLE to simple MODULE_ALIAS to avoid further confusion. Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> --- v3: - Use '#define DRV_NAME' based alias. I see no point bloating the driver with another platform device IDs array, as I don't expect this driver to be used with any other platform device ID. Driver variants are already selected based on the parent PMU device compatible. v2: - added MODULE_ALIAS --- drivers/clk/samsung/clk-exynos-clkout.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)