| Message ID | 20240517092039.688-1-shenghao-ding@ti.com |
|---|---|
| State | New |
| Headers | show |
| Series | [RESEND,v5,1/3] ASoC: tas2781: Fix wrong loading calibrated data sequence | expand |
On Fri, 17 May 2024 11:20:36 +0200, Shenghao Ding wrote: > > Remove declaration of unused API which load calibrated data in wrong > sequence, changed the copyright year and correct file name in license > header. > > Fixes: ef3bcde75d06 ("ASoc: tas2781: Add tas2781 driver") > Signed-off-by: Shenghao Ding <shenghao-ding@ti.com> First off, this breaks the build. You are removing the function that is still called. You will remove the caller in a later patch, but it's still there at this point. That's what Andy suggested for the whole time. Try to apply only this patch and build module. You'll get a compile error. This must be avoided. Second, it makes little sense to split the patches in that way. A copyright year change can be folded into the same patch. If any, a patch to correct the ifdef as a separate patch, as it's completely irrelevant with the fix itself. thanks, Takashi
diff --git a/include/sound/tas2781-dsp.h b/include/sound/tas2781-dsp.h index ea9af2726a53..7fba7ea26a4b 100644 --- a/include/sound/tas2781-dsp.h +++ b/include/sound/tas2781-dsp.h @@ -2,7 +2,7 @@ // // ALSA SoC Texas Instruments TAS2781 Audio Smart Amplifier // -// Copyright (C) 2022 - 2023 Texas Instruments Incorporated +// Copyright (C) 2022 - 2024 Texas Instruments Incorporated // https://www.ti.com // // The TAS2781 driver implements a flexible and configurable @@ -13,8 +13,8 @@ // Author: Kevin Lu <kevin-lu@ti.com> // -#ifndef __TASDEVICE_DSP_H__ -#define __TASDEVICE_DSP_H__ +#ifndef __TAS2781_DSP_H__ +#define __TAS2781_DSP_H__ #define MAIN_ALL_DEVICES 0x0d #define MAIN_DEVICE_A 0x01 @@ -180,7 +180,6 @@ void tasdevice_calbin_remove(void *context); int tasdevice_select_tuningprm_cfg(void *context, int prm, int cfg_no, int rca_conf_no); int tasdevice_prmg_load(void *context, int prm_no); -int tasdevice_prmg_calibdata_load(void *context, int prm_no); void tasdevice_tuning_switch(void *context, int state); int tas2781_load_calibration(void *context, char *file_name, unsigned short i);
Remove declaration of unused API which load calibrated data in wrong sequence, changed the copyright year and correct file name in license header. Fixes: ef3bcde75d06 ("ASoc: tas2781: Add tas2781 driver") Signed-off-by: Shenghao Ding <shenghao-ding@ti.com> --- v5: - correct changelog has no much relationship with the patch v4: - Use the the culprit of the bug itself as the fixes tag v3: - No changes. v2: - In the Subject, fixed --> Fix - Add Fixes tag - Changed the copyright year to 2024 in the related files - In tas2781-dsp.h, __TASDEVICE_DSP_H__ --> __TAS2781_DSP_H__ v1: - Download calibrated data after loading the new DSP config params - Remove tasdevice_prmg_calibdata_load, because it is unnecessary to load calibrated data after loading DSP program. --- include/sound/tas2781-dsp.h | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)