diff mbox series

[v2,1/2] media: dt-bindings: Add ST VD56G3 camera sensor binding

Message ID 20240521162950.6987-2-sylvain.petinot@foss.st.com
State New
Headers show
Series media: Add driver for ST VD56G3 camera sensor | expand

Commit Message

Sylvain Petinot May 21, 2024, 4:29 p.m. UTC 
Add devicetree bindings Documentation for ST VD56G3 & ST VD66GY camera
sensors. Update MAINTAINERS file.

Signed-off-by: Sylvain Petinot <sylvain.petinot@foss.st.com>
---
 .../bindings/media/i2c/st,st-vd56g3.yaml      | 132 ++++++++++++++++++
 MAINTAINERS                                   |   9 ++
 2 files changed, 141 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/media/i2c/st,st-vd56g3.yaml

Comments

Sakari Ailus May 28, 2024, 10:01 a.m. UTC | #1 
Hi Krzysztof,

On Tue, May 28, 2024 at 11:46:00AM +0200, Krzysztof Kozlowski wrote:
> On 28/05/2024 11:22, Sakari Ailus wrote:
> > Hi Krzysztof,
> > 
> > On Mon, May 27, 2024 at 09:04:38PM +0200, Krzysztof Kozlowski wrote:
> >> On 21/05/2024 18:29, Sylvain Petinot wrote:
> >>> Add devicetree bindings Documentation for ST VD56G3 & ST VD66GY camera
> >>> sensors. Update MAINTAINERS file.
> >>>
> >>> Signed-off-by: Sylvain Petinot <sylvain.petinot@foss.st.com>
> >>
> >>
> >>> diff --git a/MAINTAINERS b/MAINTAINERS
> >>> index ef6be9d95143..554e6861425b 100644
> >>> --- a/MAINTAINERS
> >>> +++ b/MAINTAINERS
> >>> @@ -20885,6 +20885,15 @@ S:	Maintained
> >>>  F:	Documentation/hwmon/stpddc60.rst
> >>>  F:	drivers/hwmon/pmbus/stpddc60.c
> >>>  
> >>> +ST VD56G3 DRIVER
> > 
> > I might add this is a sensor, i.e. "ST VD653G IMAGE SENSOR DRIVER".
> > 
> >>> +M:	Benjamin Mugnier <benjamin.mugnier@foss.st.com>
> >>> +M:	Sylvain Petinot <sylvain.petinot@foss.st.com>
> >>> +L:	linux-media@vger.kernel.org
> >>> +S:	Maintained
> >>> +T:	git git://linuxtv.org/media_tree.git
> >>
> >> This is a friendly reminder during the review process.
> >>
> >> It seems my or other reviewer's previous comments were not fully
> >> addressed. Maybe the feedback got lost between the quotes, maybe you
> >> just forgot to apply it. Please go back to the previous discussion and
> >> either implement all requested changes or keep discussing them.
> > 
> > The above MAINTAINERS entry is roughly in line with what else we have for
> > the Media tree. I'm in favour of listing the people who would look after
> > the driver, not just those who merge the patches (or even send PRs to
> > Linus).
> 
> I did not propose to drop the entry.
> 
> > 
> > In other words, I think the above entry is fine as-is.
> 
> I propose to drop duplicated, redundant git entry. Maintainer of this

Ah, I agree, that makes sense.

> driver does not have access to git tree and the git tree is already
> explained in media subsystem entry. If you ever update the git tree, you
> need to update 100 driver entries which is meaningless...
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/media/i2c/st,st-vd56g3.yaml b/Documentation/devicetree/bindings/media/i2c/st,st-vd56g3.yaml
new file mode 100644
index 000000000000..22cb2557e311
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/i2c/st,st-vd56g3.yaml
@@ -0,0 +1,132 @@ 
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+# Copyright (c) 2024 STMicroelectronics SA.
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/media/i2c/st,st-vd56g3.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: STMicroelectronics VD56G3 Global Shutter Image Sensor
+
+maintainers:
+  - Benjamin Mugnier <benjamin.mugnier@foss.st.com>
+  - Sylvain Petinot <sylvain.petinot@foss.st.com>
+
+description: |-
+  The STMicroelectronics VD56G3 is a 1.5 M pixel global shutter image sensor
+  with an active array size of 1124 x 1364 (portrait orientation). It is
+  programmable through I2C, the address is fixed to 0x10. The sensor output is
+  available via CSI-2, which is configured as either 1 or 2 data lanes. The
+  sensor provides 8 GPIOS that can be used for external LED signal
+  (synchronized with sensor integration periods)
+
+properties:
+  compatible:
+    enum:
+      - st,st-vd56g3
+      - st,st-vd66gy
+    description:
+      Two variants are availables; VD56G3 is a monochrome sensor while VD66GY
+      is a colour variant.
+
+  reg:
+    maxItems: 1
+
+  clocks:
+    maxItems: 1
+
+  vcore-supply:
+    description: Digital core power supply (1.15V)
+
+  vddio-supply:
+    description: Digital IO power supply (1.8V)
+
+  vana-supply:
+    description: Analog power supply (2.8V)
+
+  reset-gpios:
+    description: Sensor reset active low GPIO (XSHUTDOWN)
+    maxItems: 1
+
+  st,leds:
+    description:
+      Sensor's GPIOs used for external LED control. Signal being the enveloppe
+      of the integration time.
+    $ref: /schemas/types.yaml#/definitions/uint32-array
+    minItems: 1
+    maxItems: 8
+    items:
+      minimum: 0
+      maximum: 7
+
+  port:
+    $ref: /schemas/graph.yaml#/$defs/port-base
+
+    properties:
+      endpoint:
+        $ref: /schemas/media/video-interfaces.yaml#
+        unevaluatedProperties: false
+
+        properties:
+          data-lanes:
+            minItems: 1
+            maxItems: 2
+            items:
+              enum: [1, 2]
+
+          link-frequencies:
+            minItems: 1
+            maxItems: 1
+            items:
+              enum: [402000000, 750000000]
+
+          lane-polarities:
+            minItems: 1
+            maxItems: 3
+            description: Any lane can be inverted or not.
+
+        required:
+          - data-lanes
+          - link-frequencies
+
+required:
+  - compatible
+  - reg
+  - clocks
+  - vcore-supply
+  - vddio-supply
+  - vana-supply
+  - reset-gpios
+  - port
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/gpio/gpio.h>
+
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        camera-sensor@10 {
+            compatible = "st,st-vd56g3";
+            reg = <0x10>;
+
+            clocks = <&camera_clk_12M>;
+
+            vcore-supply = <&camera_vcore_v1v15>;
+            vddio-supply = <&camera_vddio_v1v8>;
+            vana-supply = <&camera_vana_v2v8>;
+
+            reset-gpios = <&gpio 5 GPIO_ACTIVE_LOW>;
+            st,leds = <6>;
+
+            port {
+                endpoint {
+                    data-lanes = <1 2>;
+                    link-frequencies = /bits/ 64 <402000000>;
+                    remote-endpoint = <&csiphy0_ep>;
+                };
+            };
+        };
+    };
diff --git a/MAINTAINERS b/MAINTAINERS
index ef6be9d95143..554e6861425b 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -20885,6 +20885,15 @@  S:	Maintained
 F:	Documentation/hwmon/stpddc60.rst
 F:	drivers/hwmon/pmbus/stpddc60.c
 
+ST VD56G3 DRIVER
+M:	Benjamin Mugnier <benjamin.mugnier@foss.st.com>
+M:	Sylvain Petinot <sylvain.petinot@foss.st.com>
+L:	linux-media@vger.kernel.org
+S:	Maintained
+T:	git git://linuxtv.org/media_tree.git
+F:	Documentation/devicetree/bindings/media/i2c/st,st-vd56g3.yaml
+F:	drivers/media/i2c/st-vd56g3.c
+
 ST VGXY61 DRIVER
 M:	Benjamin Mugnier <benjamin.mugnier@foss.st.com>
 M:	Sylvain Petinot <sylvain.petinot@foss.st.com>