[gas/ARM] Add support for Cortex-M23

Message ID ce166e92-f8e4-3d06-5e4f-3f68235f1adb@foss.arm.com
State New
Headers show

Commit Message

Thomas Preudhomme Oct. 28, 2016, 2:32 p.m.
On 27/10/16 13:44, Richard Earnshaw (lists) wrote:
> OK.  Don't forget to update the NEWS file.


I wasn't sure I should. I didn't see any entry for new processor support in the 
NEWS file. It seems we (ARM but also the community in general I think) only 
mention architecture.

I'm happy to change our behavior (and I think it makes sense to announce any 
interface change) but I just want an extra confirmation from you:

*** gas/ChangeLog ***

2016-10-27  Thomas Preud'homme  <thomas.preudhomme@arm.com>

         * config/tc-arm.c (cortex-m23): Declare new processor.
         * doc/c-arm.texi (-mcpu ARM command line option): Document new
         Cortex-M23 processor.
         * NEWS: Mention Cortex-M23 support.


Ok for master?

Best regards,

Thomas

Comments

Richard Earnshaw (lists) Oct. 31, 2016, 1:45 p.m. | #1
On 28/10/16 15:32, Thomas Preudhomme wrote:
> On 27/10/16 13:44, Richard Earnshaw (lists) wrote:

>> OK.  Don't forget to update the NEWS file.

> 

> I wasn't sure I should. I didn't see any entry for new processor support

> in the NEWS file. It seems we (ARM but also the community in general I

> think) only mention architecture.

> 

> I'm happy to change our behavior (and I think it makes sense to announce

> any interface change) but I just want an extra confirmation from you:


OK, I'd missed that we don't normally mention CPU names.  I'll let Nick
make the call on which version he wants (NEWS or no-NEWS).

R.

> 

> *** gas/ChangeLog ***

> 

> 2016-10-27  Thomas Preud'homme  <thomas.preudhomme@arm.com>

> 

>         * config/tc-arm.c (cortex-m23): Declare new processor.

>         * doc/c-arm.texi (-mcpu ARM command line option): Document new

>         Cortex-M23 processor.

>         * NEWS: Mention Cortex-M23 support.

> 

> 

> Ok for master?

> 

> Best regards,

> 

> Thomas

> 

> add_gas_cortex-m23_support.patch

> 

> 

> diff --git a/gas/NEWS b/gas/NEWS

> index 2dd2245d6e7fd762d02c7bbeff11aab7e536ecb5..a2a62563f867edf26462a08a23950b179710d288 100644

> --- a/gas/NEWS

> +++ b/gas/NEWS

> @@ -1,5 +1,9 @@

>  -*- text -*-

>  

> +Changes in 2.28:

> +

> +* Add support for the Cortex-M23 processor.

> +

>  Changes in 2.27:

>  

>  * Default to --enable-compressed-debug-sections=gas for Linux/x86 targets.

> diff --git a/gas/config/tc-arm.c b/gas/config/tc-arm.c

> index 73f8396396ff85276dc5bc92f79764d6d194b3d3..69dfe989133cbdc12f2da9d2864e6788eace3353 100644

> --- a/gas/config/tc-arm.c

> +++ b/gas/config/tc-arm.c

> @@ -25406,6 +25406,8 @@ static const struct arm_cpu_option_table arm_cpus[] =

>    ARM_CPU_OPT ("cortex-r8",	ARM_ARCH_V7R_IDIV,

>  						 FPU_ARCH_VFP_V3D16,

>  								  "Cortex-R8"),

> +  ARM_CPU_OPT ("cortex-m23",	ARM_ARCH_V8M_BASE,

> +						 FPU_NONE,	  "Cortex-M23"),

>    ARM_CPU_OPT ("cortex-m7",	ARM_ARCH_V7EM,	 FPU_NONE,	  "Cortex-M7"),

>    ARM_CPU_OPT ("cortex-m4",	ARM_ARCH_V7EM,	 FPU_NONE,	  "Cortex-M4"),

>    ARM_CPU_OPT ("cortex-m3",	ARM_ARCH_V7M,	 FPU_NONE,	  "Cortex-M3"),

> diff --git a/gas/doc/c-arm.texi b/gas/doc/c-arm.texi

> index 0cf7390dc5f28dc34b33c377ff59f06f5aee2a89..565ef73250e957e2da11cc261ec9d4b5ccb9c7c2 100644

> --- a/gas/doc/c-arm.texi

> +++ b/gas/doc/c-arm.texi

> @@ -131,6 +131,7 @@ recognized:

>  @code{cortex-r5},

>  @code{cortex-r7},

>  @code{cortex-r8},

> +@code{cortex-m23},

>  @code{cortex-m7},

>  @code{cortex-m4},

>  @code{cortex-m3},

>
Thomas Preudhomme Nov. 2, 2016, 10:11 a.m. | #2
Nick: ping?

Is this ok for ARM to mention support for new Cortex-M23 and Cortex-M33 
processors in gas/NEWS?

Best regards,

Thomas

On 31/10/16 13:45, Richard Earnshaw (lists) wrote:
> On 28/10/16 15:32, Thomas Preudhomme wrote:

>> On 27/10/16 13:44, Richard Earnshaw (lists) wrote:

>>> OK.  Don't forget to update the NEWS file.

>>

>> I wasn't sure I should. I didn't see any entry for new processor support

>> in the NEWS file. It seems we (ARM but also the community in general I

>> think) only mention architecture.

>>

>> I'm happy to change our behavior (and I think it makes sense to announce

>> any interface change) but I just want an extra confirmation from you:

>

> OK, I'd missed that we don't normally mention CPU names.  I'll let Nick

> make the call on which version he wants (NEWS or no-NEWS).

>

> R.

>

>>

>> *** gas/ChangeLog ***

>>

>> 2016-10-27  Thomas Preud'homme  <thomas.preudhomme@arm.com>

>>

>>         * config/tc-arm.c (cortex-m23): Declare new processor.

>>         * doc/c-arm.texi (-mcpu ARM command line option): Document new

>>         Cortex-M23 processor.

>>         * NEWS: Mention Cortex-M23 support.

>>

>>

>> Ok for master?

>>

>> Best regards,

>>

>> Thomas

>>

>> add_gas_cortex-m23_support.patch

>>

>>

>> diff --git a/gas/NEWS b/gas/NEWS

>> index 2dd2245d6e7fd762d02c7bbeff11aab7e536ecb5..a2a62563f867edf26462a08a23950b179710d288 100644

>> --- a/gas/NEWS

>> +++ b/gas/NEWS

>> @@ -1,5 +1,9 @@

>>  -*- text -*-

>>

>> +Changes in 2.28:

>> +

>> +* Add support for the Cortex-M23 processor.

>> +

>>  Changes in 2.27:

>>

>>  * Default to --enable-compressed-debug-sections=gas for Linux/x86 targets.

>> diff --git a/gas/config/tc-arm.c b/gas/config/tc-arm.c

>> index 73f8396396ff85276dc5bc92f79764d6d194b3d3..69dfe989133cbdc12f2da9d2864e6788eace3353 100644

>> --- a/gas/config/tc-arm.c

>> +++ b/gas/config/tc-arm.c

>> @@ -25406,6 +25406,8 @@ static const struct arm_cpu_option_table arm_cpus[] =

>>    ARM_CPU_OPT ("cortex-r8",	ARM_ARCH_V7R_IDIV,

>>  						 FPU_ARCH_VFP_V3D16,

>>  								  "Cortex-R8"),

>> +  ARM_CPU_OPT ("cortex-m23",	ARM_ARCH_V8M_BASE,

>> +						 FPU_NONE,	  "Cortex-M23"),

>>    ARM_CPU_OPT ("cortex-m7",	ARM_ARCH_V7EM,	 FPU_NONE,	  "Cortex-M7"),

>>    ARM_CPU_OPT ("cortex-m4",	ARM_ARCH_V7EM,	 FPU_NONE,	  "Cortex-M4"),

>>    ARM_CPU_OPT ("cortex-m3",	ARM_ARCH_V7M,	 FPU_NONE,	  "Cortex-M3"),

>> diff --git a/gas/doc/c-arm.texi b/gas/doc/c-arm.texi

>> index 0cf7390dc5f28dc34b33c377ff59f06f5aee2a89..565ef73250e957e2da11cc261ec9d4b5ccb9c7c2 100644

>> --- a/gas/doc/c-arm.texi

>> +++ b/gas/doc/c-arm.texi

>> @@ -131,6 +131,7 @@ recognized:

>>  @code{cortex-r5},

>>  @code{cortex-r7},

>>  @code{cortex-r8},

>> +@code{cortex-m23},

>>  @code{cortex-m7},

>>  @code{cortex-m4},

>>  @code{cortex-m3},

>>

>
Nick Clifton Nov. 4, 2016, 3:29 p.m. | #3
Hi Thomas,

> Nick: ping?


oops - sorry,

> Is this ok for ARM to mention support for new Cortex-M23 and Cortex-M33 processors in gas/NEWS?


Yes.

>>> *** gas/ChangeLog ***

>>>

>>> 2016-10-27  Thomas Preud'homme  <thomas.preudhomme@arm.com>

>>>

>>>         * config/tc-arm.c (cortex-m23): Declare new processor.

>>>         * doc/c-arm.texi (-mcpu ARM command line option): Document new

>>>         Cortex-M23 processor.

>>>         * NEWS: Mention Cortex-M23 support.


Approved - please apply.

Cheers
  Nick
Thomas Preudhomme Nov. 4, 2016, 4:26 p.m. | #4
Committed with ARM Cortex-M23 instead of Cortex-M23 in ChangeLog and NEWS entry. 
Likewise for Cortex-M33.

Best regards,

Thomas

On 04/11/16 15:29, Nick Clifton wrote:
> Hi Thomas,

>

>> Nick: ping?

>

> oops - sorry,

>

>> Is this ok for ARM to mention support for new Cortex-M23 and Cortex-M33 processors in gas/NEWS?

>

> Yes.

>

>>>> *** gas/ChangeLog ***

>>>>

>>>> 2016-10-27  Thomas Preud'homme  <thomas.preudhomme@arm.com>

>>>>

>>>>         * config/tc-arm.c (cortex-m23): Declare new processor.

>>>>         * doc/c-arm.texi (-mcpu ARM command line option): Document new

>>>>         Cortex-M23 processor.

>>>>         * NEWS: Mention Cortex-M23 support.

>

> Approved - please apply.

>

> Cheers

>   Nick

>
Thomas Preudhomme Nov. 4, 2016, 4:34 p.m. | #5
Made a follow-up commit because I forgot the ChangeLog entry for changes in 
include directory for Cortex-M33 support.

My apologize.

Best regards,

Thomas

On 04/11/16 16:26, Thomas Preudhomme wrote:
> Committed with ARM Cortex-M23 instead of Cortex-M23 in ChangeLog and NEWS entry.

> Likewise for Cortex-M33.

>

> Best regards,

>

> Thomas

>

> On 04/11/16 15:29, Nick Clifton wrote:

>> Hi Thomas,

>>

>>> Nick: ping?

>>

>> oops - sorry,

>>

>>> Is this ok for ARM to mention support for new Cortex-M23 and Cortex-M33

>>> processors in gas/NEWS?

>>

>> Yes.

>>

>>>>> *** gas/ChangeLog ***

>>>>>

>>>>> 2016-10-27  Thomas Preud'homme  <thomas.preudhomme@arm.com>

>>>>>

>>>>>         * config/tc-arm.c (cortex-m23): Declare new processor.

>>>>>         * doc/c-arm.texi (-mcpu ARM command line option): Document new

>>>>>         Cortex-M23 processor.

>>>>>         * NEWS: Mention Cortex-M23 support.

>>

>> Approved - please apply.

>>

>> Cheers

>>   Nick

>>

Patch

diff --git a/gas/NEWS b/gas/NEWS
index 2dd2245d6e7fd762d02c7bbeff11aab7e536ecb5..a2a62563f867edf26462a08a23950b179710d288 100644
--- a/gas/NEWS
+++ b/gas/NEWS
@@ -1,5 +1,9 @@ 
 -*- text -*-
 
+Changes in 2.28:
+
+* Add support for the Cortex-M23 processor.
+
 Changes in 2.27:
 
 * Default to --enable-compressed-debug-sections=gas for Linux/x86 targets.
diff --git a/gas/config/tc-arm.c b/gas/config/tc-arm.c
index 73f8396396ff85276dc5bc92f79764d6d194b3d3..69dfe989133cbdc12f2da9d2864e6788eace3353 100644
--- a/gas/config/tc-arm.c
+++ b/gas/config/tc-arm.c
@@ -25406,6 +25406,8 @@  static const struct arm_cpu_option_table arm_cpus[] =
   ARM_CPU_OPT ("cortex-r8",	ARM_ARCH_V7R_IDIV,
 						 FPU_ARCH_VFP_V3D16,
 								  "Cortex-R8"),
+  ARM_CPU_OPT ("cortex-m23",	ARM_ARCH_V8M_BASE,
+						 FPU_NONE,	  "Cortex-M23"),
   ARM_CPU_OPT ("cortex-m7",	ARM_ARCH_V7EM,	 FPU_NONE,	  "Cortex-M7"),
   ARM_CPU_OPT ("cortex-m4",	ARM_ARCH_V7EM,	 FPU_NONE,	  "Cortex-M4"),
   ARM_CPU_OPT ("cortex-m3",	ARM_ARCH_V7M,	 FPU_NONE,	  "Cortex-M3"),
diff --git a/gas/doc/c-arm.texi b/gas/doc/c-arm.texi
index 0cf7390dc5f28dc34b33c377ff59f06f5aee2a89..565ef73250e957e2da11cc261ec9d4b5ccb9c7c2 100644
--- a/gas/doc/c-arm.texi
+++ b/gas/doc/c-arm.texi
@@ -131,6 +131,7 @@  recognized:
 @code{cortex-r5},
 @code{cortex-r7},
 @code{cortex-r8},
+@code{cortex-m23},
 @code{cortex-m7},
 @code{cortex-m4},
 @code{cortex-m3},