| Message ID | 20240617070039.30824-1-quic_janathot@quicinc.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v1] Bluetooth: hci_qca: Increase settling time for baudrate change VSC | expand |
Dear Janaki, Thank you for your patch. Please be more specific in the summary/title: > Increase settling time for baudrate change VSC to 30 ms Am 17.06.24 um 09:00 schrieb Janaki Ramaiah Thota: > This change is done to align the settling time and > synchronization for baudrate VSC for WCN6750. > > In logging disabled builds and few devices > baudrate change and flow control is taking time > so increasing the wait time to controller and uart > to handle baudrate change request properly. Is the 30 ms documented in some datasheet? Please use 75 characters per line. Please document the test system. > Signed-off-by: Janaki Ramaiah Thota <quic_janathot@quicinc.com> > --- > drivers/bluetooth/hci_qca.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c > index 0c9c9ee56592..667687835306 100644 > --- a/drivers/bluetooth/hci_qca.c > +++ b/drivers/bluetooth/hci_qca.c > @@ -1356,12 +1356,15 @@ static int qca_set_baudrate(struct hci_dev *hdev, uint8_t baudrate) > case QCA_WCN3990: > case QCA_WCN3991: > case QCA_WCN3998: > - case QCA_WCN6750: > case QCA_WCN6855: > case QCA_WCN7850: > usleep_range(1000, 10000); > break; > > + case QCA_WCN6750: > + msleep(30); Why not usleep_range? > + break; > + > default: > msleep(300); > } Kind regards, Paul
diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c index 0c9c9ee56592..667687835306 100644 --- a/drivers/bluetooth/hci_qca.c +++ b/drivers/bluetooth/hci_qca.c @@ -1356,12 +1356,15 @@ static int qca_set_baudrate(struct hci_dev *hdev, uint8_t baudrate) case QCA_WCN3990: case QCA_WCN3991: case QCA_WCN3998: - case QCA_WCN6750: case QCA_WCN6855: case QCA_WCN7850: usleep_range(1000, 10000); break; + case QCA_WCN6750: + msleep(30); + break; + default: msleep(300); }
This change is done to align the settling time and synchronization for baudrate VSC for WCN6750. In logging disabled builds and few devices baudrate change and flow control is taking time so increasing the wait time to controller and uart to handle baudrate change request properly. Signed-off-by: Janaki Ramaiah Thota <quic_janathot@quicinc.com> --- drivers/bluetooth/hci_qca.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)